Findbugs. CodePro Audit. Checkstyle. Unit test refactoring.

James Moger

2011-05-26 2a7306a1d92522569a8bb6e5a7c0bcdd5cf4cfaa

 src/com/gitblit/wicket/panels/UsersPanel.java

@@ -42,9 +42,10 @@
      add(adminLinks.setVisible(showAdmin));



      final List<String> usernames = GitBlit.self().getAllUsernames();

      DataView<String> usersView = new DataView<String>("userRow", new ListDataProvider<String>(usernames)) {

      DataView<String> usersView = new DataView<String>("userRow", new ListDataProvider<String>(

            usernames)) {

         private static final long serialVersionUID = 1L;

         private int counter = 0;

         private int counter;

         

         @Override

         protected void onBeforeRender() {

@@ -54,11 +55,13 @@


         public void populateItem(final Item<String> item) {

            final String entry = item.getModelObject();

            LinkPanel editLink = new LinkPanel("username", "list", entry, EditUserPage.class, WicketUtils.newUsernameParameter(entry));

            LinkPanel editLink = new LinkPanel("username", "list", entry, EditUserPage.class,

                  WicketUtils.newUsernameParameter(entry));

            WicketUtils.setHtmlTooltip(editLink, getString("gb.edit") + " " + entry);

            item.add(editLink);

            Fragment userLinks = new Fragment("userLinks", "userAdminLinks", this);

            userLinks.add(new BookmarkablePageLink<Void>("editUser", EditUserPage.class, WicketUtils.newUsernameParameter(entry)));

            userLinks.add(new BookmarkablePageLink<Void>("editUser", EditUserPage.class,

                  WicketUtils.newUsernameParameter(entry)));

            Link<Void> deleteLink = new Link<Void>("deleteUser") {



               private static final long serialVersionUID = 1L;

@@ -73,7 +76,8 @@
                  }

               }

            };

            deleteLink.add(new JavascriptEventConfirmation("onclick", MessageFormat.format("Delete user \"{0}\"?", entry)));

            deleteLink.add(new JavascriptEventConfirmation("onclick", MessageFormat.format(

                  "Delete user \"{0}\"?", entry)));

            userLinks.add(deleteLink);

            item.add(userLinks);