From 2a7306a1d92522569a8bb6e5a7c0bcdd5cf4cfaa Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Thu, 26 May 2011 17:11:38 -0400 Subject: [PATCH] Findbugs. CodePro Audit. Checkstyle. Unit test refactoring. --- src/com/gitblit/wicket/panels/UsersPanel.java | 16 ++++++++++------ 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/com/gitblit/wicket/panels/UsersPanel.java b/src/com/gitblit/wicket/panels/UsersPanel.java index c227ef9..27bc334 100644 --- a/src/com/gitblit/wicket/panels/UsersPanel.java +++ b/src/com/gitblit/wicket/panels/UsersPanel.java @@ -42,10 +42,11 @@ add(adminLinks.setVisible(showAdmin)); final List<String> usernames = GitBlit.self().getAllUsernames(); - DataView<String> usersView = new DataView<String>("userRow", new ListDataProvider<String>(usernames)) { + DataView<String> usersView = new DataView<String>("userRow", new ListDataProvider<String>( + usernames)) { private static final long serialVersionUID = 1L; - private int counter = 0; - + private int counter; + @Override protected void onBeforeRender() { super.onBeforeRender(); @@ -54,11 +55,13 @@ public void populateItem(final Item<String> item) { final String entry = item.getModelObject(); - LinkPanel editLink = new LinkPanel("username", "list", entry, EditUserPage.class, WicketUtils.newUsernameParameter(entry)); + LinkPanel editLink = new LinkPanel("username", "list", entry, EditUserPage.class, + WicketUtils.newUsernameParameter(entry)); WicketUtils.setHtmlTooltip(editLink, getString("gb.edit") + " " + entry); item.add(editLink); Fragment userLinks = new Fragment("userLinks", "userAdminLinks", this); - userLinks.add(new BookmarkablePageLink<Void>("editUser", EditUserPage.class, WicketUtils.newUsernameParameter(entry))); + userLinks.add(new BookmarkablePageLink<Void>("editUser", EditUserPage.class, + WicketUtils.newUsernameParameter(entry))); Link<Void> deleteLink = new Link<Void>("deleteUser") { private static final long serialVersionUID = 1L; @@ -73,7 +76,8 @@ } } }; - deleteLink.add(new JavascriptEventConfirmation("onclick", MessageFormat.format("Delete user \"{0}\"?", entry))); + deleteLink.add(new JavascriptEventConfirmation("onclick", MessageFormat.format( + "Delete user \"{0}\"?", entry))); userLinks.add(deleteLink); item.add(userLinks); -- Gitblit v1.9.1