From f06aa8058b7e32ba32d4551074b6e0b8a300f751 Mon Sep 17 00:00:00 2001 From: Thomas Bruederli <thomas@roundcube.net> Date: Mon, 21 Oct 2013 15:02:40 -0400 Subject: [PATCH] Bump version after security fix --- program/steps/utils/error.inc | 32 ++++++++++++++++++++++---------- 1 files changed, 22 insertions(+), 10 deletions(-) diff --git a/program/steps/utils/error.inc b/program/steps/utils/error.inc index 422827a..1344060 100644 --- a/program/steps/utils/error.inc +++ b/program/steps/utils/error.inc @@ -5,8 +5,11 @@ | program/steps/utils/error.inc | | | | This file is part of the Roundcube Webmail client | - | Copyright (C) 2005-2010, The Roundcube Dev Team | - | Licensed under the GNU GPL | + | Copyright (C) 2005-2012, The Roundcube Dev Team | + | | + | Licensed under the GNU General Public License version 3 or | + | any later version with exceptions for skins & plugins. | + | See the README file for a full license statement. | | | | PURPOSE: | | Display error message page | @@ -22,15 +25,15 @@ // browser is not compatible with this application if ($ERROR_CODE==409) { - $user_agent = $GLOBALS['HTTP_SERVER_VARS']['HTTP_USER_AGENT']; + $user_agent = htmlentities($_SERVER['HTTP_USER_AGENT']); $__error_title = 'Your browser does not suit the requirements for this application'; $__error_text = <<<EOF <i>Supported browsers:</i><br /> -» Netscape 7+<br /> -» Microsoft Internet Explorer 6+<br /> -» Mozilla Firefox 1.0+<br /> -» Opera 8.0+<br /> -» Safari 1.2+<br /> +» Microsoft Internet Explorer 7+<br /> +» Mozilla Firefox 3+<br /> +» Chrome 10+<br /> +» Safari 4+<br /> +» Opera 8+<br /> <br /> » JavaScript enabled<br /> » Support for XMLHTTPRequest<br /> @@ -44,6 +47,13 @@ else if ($ERROR_CODE==401) { $__error_title = "AUTHORIZATION FAILED"; $__error_text = "Could not verify that you are authorized to access this service!<br />\n". + "Please contact your server-administrator."; +} + +// forbidden due to request check +else if ($ERROR_CODE==403) { + $__error_title = "REQUEST CHECK FAILED"; + $__error_text = "Access to this service was denied due to failing security checks!<br />\n". "Please contact your server-administrator."; } @@ -84,10 +94,11 @@ $__error_text = sprintf('Error No. [%s]', $ERROR_CODE); } +$HTTP_ERR_CODE = $ERROR_CODE && $ERROR_CODE < 600 ? $ERROR_CODE : 500; // Ajax request if ($OUTPUT && ($OUTPUT instanceof rcube_json_output)) { - header("HTTP/1.0 $ERROR_CODE $__error_title"); + header("HTTP/1.0 $HTTP_ERR_CODE $__error_title"); die; } @@ -105,12 +116,13 @@ } $__skin = $CONFIG->skin ? $CONFIG->skin : 'default'; +$__productname = $CONFIG['product_name'] ? $CONFIG['product_name'] : 'Roundcube Webmail'; // print system error page print <<<EOF <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"><head> -<title>Roundcube|Mail : ERROR $ERROR_CODE</title> +<title>$__productname :: ERROR</title> <link rel="stylesheet" type="text/css" href="skins/$__skin/common.css" /> </head> <body> -- Gitblit v1.9.1