From f06aa8058b7e32ba32d4551074b6e0b8a300f751 Mon Sep 17 00:00:00 2001 From: Thomas Bruederli <thomas@roundcube.net> Date: Mon, 21 Oct 2013 15:02:40 -0400 Subject: [PATCH] Bump version after security fix --- program/include/rcube_plugin.php | 157 ++++++++++++++++++++++++++++++++++++++++++---------- 1 files changed, 127 insertions(+), 30 deletions(-) diff --git a/program/include/rcube_plugin.php b/program/include/rcube_plugin.php index b356c22..de0aabb 100644 --- a/program/include/rcube_plugin.php +++ b/program/include/rcube_plugin.php @@ -5,8 +5,11 @@ | program/include/rcube_plugin.php | | | | This file is part of the Roundcube Webmail client | - | Copyright (C) 2008-2009, Roundcube Dev. - Switzerland | - | Licensed under the GNU GPL | + | Copyright (C) 2008-2009, The Roundcube Dev Team | + | | + | Licensed under the GNU General Public License version 3 or | + | any later version with exceptions for skins & plugins. | + | See the README file for a full license statement. | | | | PURPOSE: | | Abstract plugins interface/class | @@ -14,9 +17,6 @@ +-----------------------------------------------------------------------+ | Author: Thomas Bruederli <roundcube@gmail.com> | +-----------------------------------------------------------------------+ - - $Id$ - */ /** @@ -26,18 +26,53 @@ */ abstract class rcube_plugin { + /** + * Class name of the plugin instance + * + * @var string + */ public $ID; /** - * Holds an istance of Plugin API + * Instance of Plugin API * * @var rcube_plugin_api */ public $api; + + /** + * Regular expression defining task(s) to bind with + * + * @var string + */ public $task; + + /** + * Disables plugin in AJAX requests + * + * @var boolean + */ + public $noajax = false; + + /** + * Disables plugin in framed mode + * + * @var boolean + */ + public $noframe = false; + + /** + * A list of config option names that can be modified + * by the user via user interface (with save-pref command) + * + * @var array + */ + public $allowed_prefs; + protected $home; protected $urlbase; private $mytask; + /** * Default constructor. @@ -48,15 +83,28 @@ { $this->ID = get_class($this); $this->api = $api; - $this->home = $api->dir . DIRECTORY_SEPARATOR . $this->ID; + $this->home = $api->dir . $this->ID; $this->urlbase = $api->url . $this->ID . '/'; } - + /** * Initialization method, needs to be implemented by the plugin itself */ abstract function init(); - + + + /** + * Attempt to load the given plugin which is required for the current plugin + * + * @param string Plugin name + * @return boolean True on success, false on failure + */ + public function require_plugin($plugin_name) + { + return $this->api->load_plugin($plugin_name); + } + + /** * Load local config file from plugins directory. * The loaded values are patched over the global configuration. @@ -74,7 +122,7 @@ 'message' => "Failed to load config from $fpath"), true, false); return false; } - + return true; } @@ -88,7 +136,18 @@ { $this->api->register_hook($hook, $callback); } - + + /** + * Unregister a callback function for a specific (server-side) hook. + * + * @param string $hook Hook name + * @param mixed $callback Callback function as string or array with object reference and method name + */ + public function remove_hook($hook, $callback) + { + $this->api->unregister_hook($hook, $callback); + } + /** * Load localized texts from the plugins dir * @@ -98,15 +157,51 @@ public function add_texts($dir, $add2client = false) { $domain = $this->ID; - - $lang = $_SESSION['language']; + $lang = $_SESSION['language']; + $langs = array_unique(array('en_US', $lang)); $locdir = slashify(realpath(slashify($this->home) . $dir)); - $texts = array(); - - foreach (array('en_US', $lang) as $lng) { - @include($locdir . $lng . '.inc'); - $texts = (array)$labels + (array)$messages + (array)$texts; + $texts = array(); + + // Language aliases used to find localization in similar lang, see below + $aliases = array( + 'de_CH' => 'de_DE', + 'es_AR' => 'es_ES', + 'fa_AF' => 'fa_IR', + 'nl_BE' => 'nl_NL', + 'pt_BR' => 'pt_PT', + 'zh_CN' => 'zh_TW', + ); + + // use buffering to handle empty lines/spaces after closing PHP tag + ob_start(); + + foreach ($langs as $lng) { + $fpath = $locdir . $lng . '.inc'; + if (is_file($fpath) && is_readable($fpath)) { + include $fpath; + $texts = (array)$labels + (array)$messages + (array)$texts; + } + else if ($lng != 'en_US') { + // Find localization in similar language (#1488401) + $alias = null; + if (!empty($aliases[$lng])) { + $alias = $aliases[$lng]; + } + else if ($key = array_search($lng, $aliases)) { + $alias = $key; + } + + if (!empty($alias)) { + $fpath = $locdir . $alias . '.inc'; + if (is_file($fpath) && is_readable($fpath)) { + include $fpath; + $texts = (array)$labels + (array)$messages + (array)$texts; + } + } + } } + + ob_end_clean(); // prepend domain to text keys and add to the application texts repository if (!empty($texts)) { @@ -116,7 +211,7 @@ $rcmail = rcmail::get_instance(); $rcmail->load_language($lang, $add); - + // add labels to client if ($add2client) { $js_labels = is_array($add2client) ? array_map(array($this, 'label_map_callback'), $add2client) : array_keys($add); @@ -124,7 +219,7 @@ } } } - + /** * Wrapper for rcmail::gettext() adding the plugin ID as domain * @@ -194,7 +289,7 @@ { $this->api->include_stylesheet($this->resource_url($fn)); } - + /** * Append a button to a certain container * @@ -209,11 +304,11 @@ foreach (array('imagepas', 'imageact', 'imagesel') as $key) if ($p[$key]) $p[$key] = $this->api->url . $this->resource_url($p[$key]); - + $this->api->add_content($this->api->output->button($p), $container); } } - + /** * Generate an absolute URL to the given resource within the current * plugin directory @@ -238,18 +333,22 @@ else return $fn; } - + /** * Provide path to the currently selected skin folder within the plugin directory * with a fallback to the default skin folder. * * @return string Skin path relative to plugins directory */ - protected function local_skin_path() + public function local_skin_path() { - $skin_path = 'skins/'.$this->api->config->get('skin'); - if (!is_dir(realpath(slashify($this->home) . $skin_path))) - $skin_path = 'skins/default'; + $rcmail = rcmail::get_instance(); + foreach (array($rcmail->config->get('skin'), 'larry') as $skin) { + $skin_path = 'skins/' . $skin; + if (is_dir(realpath(slashify($this->home) . $skin_path))) + break; + } + return $skin_path; } @@ -264,6 +363,4 @@ return $this->ID.'.'.$key; } - } - -- Gitblit v1.9.1