From ed302bbbedaca1d0fd71b0cbc2b6136a12f75dd4 Mon Sep 17 00:00:00 2001
From: alecpl <alec@alec.pl>
Date: Fri, 10 Sep 2010 06:44:02 -0400
Subject: [PATCH] - Code improvements + more infinite loop prevention
---
program/include/rcube_imap_generic.php | 187 ++++++++++++++++++++--------------------------
1 files changed, 81 insertions(+), 106 deletions(-)
diff --git a/program/include/rcube_imap_generic.php b/program/include/rcube_imap_generic.php
index cd6a58d..2dc1e37 100644
--- a/program/include/rcube_imap_generic.php
+++ b/program/include/rcube_imap_generic.php
@@ -119,7 +119,7 @@
{
}
- private function putLine($string, $endln=true)
+ function putLine($string, $endln=true)
{
if (!$this->fp)
return false;
@@ -128,14 +128,21 @@
write_log('imap', 'C: '. rtrim($string));
}
- return fputs($this->fp, $string . ($endln ? "\r\n" : ''));
+ $res = fwrite($this->fp, $string . ($endln ? "\r\n" : ''));
+
+ if ($res === false) {
+ @fclose($this->fp);
+ $this->fp = null;
+ }
+
+ return $res;
}
// $this->putLine replacement with Command Continuation Requests (RFC3501 7.5) support
- private function putLineC($string, $endln=true)
+ function putLineC($string, $endln=true)
{
if (!$this->fp)
- return NULL;
+ return false;
if ($endln)
$string .= "\r\n";
@@ -166,7 +173,7 @@
return $res;
}
- private function readLine($size=1024)
+ function readLine($size=1024)
{
$line = '';
@@ -191,7 +198,7 @@
break;
}
if (!empty($this->prefs['debug_mode'])) {
- write_log('imap', 'S: '. chop($buffer));
+ write_log('imap', 'S: '. rtrim($buffer));
}
$line .= $buffer;
} while ($buffer[strlen($buffer)-1] != "\n");
@@ -199,9 +206,9 @@
return $line;
}
- private function multLine($line, $escape=false)
+ function multLine($line, $escape=false)
{
- $line = chop($line);
+ $line = rtrim($line);
if (preg_match('/\{[0-9]+\}$/', $line)) {
$out = '';
@@ -220,7 +227,7 @@
return $line;
}
- private function readBytes($bytes)
+ function readBytes($bytes)
{
$data = '';
$len = 0;
@@ -242,7 +249,7 @@
}
// don't use it in loops, until you exactly know what you're doing
- private function readReply(&$untagged=null)
+ function readReply(&$untagged=null)
{
do {
$line = trim($this->readLine(1024));
@@ -257,7 +264,7 @@
return $line;
}
- private function parseResult($string)
+ function parseResult($string)
{
$a = explode(' ', trim($string));
if (count($a) >= 2) {
@@ -278,7 +285,7 @@
}
// check if $string starts with $match (or * BYE/BAD)
- private function startsWith($string, $match, $error=false, $nonempty=false)
+ function startsWith($string, $match, $error=false, $nonempty=false)
{
$len = strlen($match);
if ($len == 0) {
@@ -288,31 +295,6 @@
return true;
}
if (strncmp($string, $match, $len) == 0) {
- return true;
- }
- if ($error && preg_match('/^\* (BYE|BAD) /i', $string, $m)) {
- if (strtoupper($m[1]) == 'BYE') {
- @fclose($this->fp);
- $this->fp = null;
- }
- return true;
- }
- if ($nonempty && !strlen($string)) {
- return true;
- }
- return false;
- }
-
- private function startsWithI($string, $match, $error=false, $nonempty=false)
- {
- $len = strlen($match);
- if ($len == 0) {
- return false;
- }
- if (!$this->fp) {
- return true;
- }
- if (strncasecmp($string, $match, $len) == 0) {
return true;
}
if ($error && preg_match('/^\* (BYE|BAD) /i', $string, $m)) {
@@ -346,14 +328,10 @@
}
do {
$line = trim($this->readLine(1024));
- $a = explode(' ', $line);
- if ($line[0] == '*') {
- while (list($k, $w) = each($a)) {
- if ($w != '*' && $w != 'CAPABILITY')
- $this->capability[] = strtoupper($w);
- }
- }
- } while ($a[0] != 'cp01');
+ if (preg_match('/^\* CAPABILITY (.+)/i', $line, $matches)) {
+ $this->capability = explode(' ', strtoupper($matches[1]));
+ }
+ } while (!$this->startsWith($line, 'cp01', true));
$this->capability_readed = true;
@@ -454,7 +432,7 @@
}
do {
$line = $this->readLine(1024);
- if ($this->startsWith($line, '* NAMESPACE')) {
+ if (preg_match('/^\* NAMESPACE/', $line)) {
$i = 0;
$line = $this->unEscape($line);
$data = $this->parseNamespace(substr($line,11), $i, 0, 0);
@@ -532,7 +510,7 @@
do {
$line = $this->readLine(1024);
- if ($this->startsWith($line, '* NAMESPACE')) {
+ if (preg_match('/^\* NAMESPACE/', $line)) {
$i = 0;
$line = $this->unEscape($line);
$data = $this->parseNamespace(substr($line,11), $i, 0, 0);
@@ -655,7 +633,7 @@
$this->putLine("tls0 STARTTLS");
$line = $this->readLine(4096);
- if (!$this->startsWith($line, "tls0 OK")) {
+ if (!preg_match('/^tls0 OK/', $line)) {
$this->error = "Server responded to STARTTLS with: $line";
$this->errornum = -2;
return false;
@@ -716,6 +694,7 @@
}
$this->getNamespace();
$this->logged = true;
+
return true;
} else {
return false;
@@ -748,31 +727,24 @@
if ($this->putLine("sel1 SELECT \"".$this->escape($mailbox).'"')) {
do {
- $line = chop($this->readLine(300));
- $a = explode(' ', $line);
- if (count($a) == 3) {
- $token = strtoupper($a[2]);
- if ($token == 'EXISTS') {
- $this->exists = (int) $a[1];
- }
- else if ($token == 'RECENT') {
- $this->recent = (int) $a[1];
- }
+ $line = rtrim($this->readLine(512));
+
+ if (preg_match('/^\* ([0-9]+) (EXISTS|RECENT)$/', $line, $m)) {
+ $token = strtolower($m[2]);
+ $this->$token = (int) $m[1];
}
else if (preg_match('/\[?PERMANENTFLAGS\s+\(([^\)]+)\)\]/U', $line, $match)) {
$this->permanentflags = explode(' ', $match[1]);
}
} while (!$this->startsWith($line, 'sel1', true, true));
- if (strcasecmp($a[1], 'OK') == 0) {
+ if ($this->parseResult($line) == 0) {
$this->selected = $mailbox;
return true;
}
- else {
- $this->error = "Couldn't select $mailbox";
- }
}
+ $this->error = "Couldn't select $mailbox";
return false;
}
@@ -830,7 +802,8 @@
$add = $this->compressMessageSet(join(',', $add));
$command = "s ".$is_uid."SORT ($field) $encoding ALL";
- $line = $data = '';
+ $line = '';
+ $data = '';
if (!empty($add))
$command .= ' '.$add;
@@ -839,8 +812,8 @@
return false;
}
do {
- $line = chop($this->readLine());
- if ($this->startsWith($line, '* SORT')) {
+ $line = rtrim($this->readLine());
+ if (!$data && preg_match('/^\* SORT/', $line)) {
$data .= substr($line, 7);
} else if (preg_match('/^[0-9 ]+$/', $line)) {
$data .= $line;
@@ -923,7 +896,7 @@
$result = array();
do {
- $line = chop($this->readLine(200));
+ $line = rtrim($this->readLine(200));
$line = $this->multLine($line);
if (preg_match('/^\* ([0-9]+) FETCH/', $line, $m)) {
@@ -1052,7 +1025,7 @@
$result = -1;
if ($this->putLine("fuid FETCH $id (UID)")) {
do {
- $line = chop($this->readLine(1024));
+ $line = rtrim($this->readLine(1024));
if (preg_match("/^\* $id FETCH \(UID (.*)\)/i", $line, $r)) {
$result = $r[1];
}
@@ -1110,10 +1083,8 @@
if (!$line)
break;
- $a = explode(' ', $line);
-
- if (($line[0] == '*') && ($a[2] == 'FETCH')) {
- $id = $a[1];
+ if (preg_match('/^\* ([0-9]+) FETCH/', $line, $m)) {
+ $id = $m[1];
$result[$id] = new rcube_mail_header;
$result[$id]->id = $id;
@@ -1187,7 +1158,7 @@
// to the next valid header line.
do {
- $line = chop($this->readLine(300), "\r\n");
+ $line = rtrim($this->readLine(300), "\r\n");
// The preg_match below works around communigate imap, which outputs " UID <number>)".
// Without this, the while statement continues on and gets the "FH0 OK completed" message.
@@ -1266,7 +1237,7 @@
}
break;
case 'in-reply-to':
- $result[$id]->in_reply_to = preg_replace('/[\n<>]/', '', $string);
+ $result[$id]->in_reply_to = str_replace(array("\n", '<', '>'), '', $string);
break;
case 'references':
$result[$id]->references = $string;
@@ -1289,8 +1260,6 @@
break;
} // end switch ()
} // end while ()
- } else {
- $a = explode(' ', $line);
}
// process flags
@@ -1299,7 +1268,6 @@
$flags_a = explode(' ', $flags_str);
if (is_array($flags_a)) {
- // reset($flags_a);
foreach($flags_a as $flag) {
$flag = strtoupper($flag);
if ($flag == 'SEEN') {
@@ -1450,7 +1418,7 @@
}
do {
- $line = $this->readLine(1000);
+ $line = $this->readLine();
if ($line[0] == '*') {
$c++;
}
@@ -1573,7 +1541,7 @@
}
do {
$line = trim($this->readLine());
- if ($this->startsWith($line, '* THREAD')) {
+ if (!$data && preg_match('/^\* THREAD/', $line)) {
$data .= substr($line, 9);
} else if (preg_match('/^[0-9() ]+$/', $line)) {
$data .= $line;
@@ -1606,7 +1574,7 @@
}
$data = '';
- $query = 'srch1 ' . ($return_uid ? 'UID ' : '') . 'SEARCH ' . chop($criteria);
+ $query = 'srch1 ' . ($return_uid ? 'UID ' : '') . 'SEARCH ' . trim($criteria);
if (!$this->putLineC($query)) {
return false;
@@ -1614,7 +1582,7 @@
do {
$line = trim($this->readLine());
- if ($this->startsWith($line, '* SEARCH')) {
+ if (!$data && preg_match('/^\* SEARCH/', $line)) {
$data .= substr($line, 8);
} else if (preg_match('/^[0-9 ]+$/', $line)) {
$data .= $line;
@@ -1673,8 +1641,11 @@
$command = 'LIST';
}
+ $ref = $this->escape($ref);
+ $mailbox = $this->escape($mailbox);
+
// send command
- if (!$this->putLine($key." ".$command." \"". $this->escape($ref) ."\" \"". $this->escape($mailbox) ."\"")) {
+ if (!$this->putLine($key." ".$command." \"". $ref ."\" \"". $mailbox ."\"")) {
$this->error = "Couldn't send $command command";
return false;
}
@@ -1683,16 +1654,15 @@
do {
$line = $this->readLine(500);
$line = $this->multLine($line, true);
- $a = explode(' ', $line);
+ $line = trim($line);
- if (($line[0] == '*') && ($a[1] == $command)) {
- $line = rtrim($line);
- // split one line
- $a = rcube_explode_quoted_string(' ', $line);
- // last string is folder name
- $folders[] = preg_replace(array('/^"/', '/"$/'), '', $this->unEscape($a[count($a)-1]));
- // second from last is delimiter
- $delim = trim($a[count($a)-2], '"');
+ if (preg_match('/^\* '.$command.' \(([^\)]*)\) "*([^"]+)"* (.*)$/', $line, $m)) {
+ // folder name
+ $folders[] = preg_replace(array('/^"/', '/"$/'), '', $this->unEscape($m[3]));
+ // attributes
+// $attrib = explode(' ', $m[1]);
+ // delimiter
+// $delim = $m[2];
}
} while (!$this->startsWith($line, $key, true));
@@ -1731,7 +1701,7 @@
}
do {
- $line = $this->readLine(1000);
+ $line = $this->readLine(1024);
$line = $this->multLine($line);
if (preg_match('/BODY\[([0-9\.]+)\.'.$type.'\]/', $line, $matches)) {
@@ -1775,12 +1745,11 @@
$mode = 0;
}
- $reply_key = '* ' . $id;
- $result = false;
-
// format request
- $key = 'ftch0';
- $request = $key . ($is_uid ? ' UID' : '') . " FETCH $id (BODY.PEEK[$part])";
+ $reply_key = '* ' . $id;
+ $key = 'ftch0';
+ $request = $key . ($is_uid ? ' UID' : '') . " FETCH $id (BODY.PEEK[$part])";
+
// send request
if (!$this->putLine($request)) {
return false;
@@ -1788,11 +1757,12 @@
// receive reply line
do {
- $line = chop($this->readLine(1000));
+ $line = rtrim($this->readLine(1024));
$a = explode(' ', $line);
} while (!($end = $this->startsWith($line, $key, true)) && $a[2] != 'FETCH');
- $len = strlen($line);
+ $len = strlen($line);
+ $result = false;
// handle empty "* X FETCH ()" response
if ($line[$len-1] == ')' && $line[$len-2] != '(') {
@@ -1825,6 +1795,10 @@
while ($bytes > 0) {
$line = $this->readLine(1024);
+
+ if ($line === NULL)
+ break;
+
$len = strlen($line);
if ($len > $bytes) {
@@ -1888,7 +1862,7 @@
$line = $this->readLine(1024);
} while (!$this->startsWith($line, $key, true));
- if ($result) {
+ if ($result !== false) {
if ($file) {
fwrite($file, $result);
} else if ($print) {
@@ -2005,7 +1979,7 @@
return false;
}
- function appendFromFile($folder, $path, $headers=null, $separator="\n\n")
+ function appendFromFile($folder, $path, $headers=null)
{
if (!$folder) {
return false;
@@ -2021,14 +1995,16 @@
return false;
}
+ $body_separator = "\r\n\r\n";
$len = filesize($path);
+
if (!$len) {
return false;
}
if ($headers) {
$headers = preg_replace('/[\r\n]+$/', '', $headers);
- $len += strlen($headers) + strlen($separator);
+ $len += strlen($headers) + strlen($body_separator);
}
// send APPEND command
@@ -2044,7 +2020,7 @@
// send headers with body separator
if ($headers) {
- $this->putLine($headers . $separator, false);
+ $this->putLine($headers . $body_separator, false);
}
// send file
@@ -2112,8 +2088,8 @@
// get line(s) containing quota info
if ($this->putLine('QUOT1 GETQUOTAROOT "INBOX"')) {
do {
- $line = chop($this->readLine(5000));
- if ($this->startsWith($line, '* QUOTA ')) {
+ $line = rtrim($this->readLine(5000));
+ if (preg_match('/^\* QUOTA /', $line)) {
$quota_lines[] = $line;
}
} while (!$this->startsWith($line, 'QUOT1', true, true));
@@ -2122,7 +2098,7 @@
// return false if not found, parse if found
$min_free = PHP_INT_MAX;
foreach ($quota_lines as $key => $quota_line) {
- $quota_line = preg_replace('/[()]/', '', $quota_line);
+ $quota_line = str_replace(array('(', ')'), '', $quota_line);
$parts = explode(' ', $quota_line);
$storage_part = array_search('STORAGE', $parts);
@@ -2235,4 +2211,3 @@
}
-?>
--
Gitblit v1.9.1