From e019f2d0f2dc2fbfa345ab5d7ae85e67bfdd76b8 Mon Sep 17 00:00:00 2001 From: alecpl <alec@alec.pl> Date: Sat, 25 Sep 2010 09:03:53 -0400 Subject: [PATCH] - s/RoundCube/Roundcube/ --- program/steps/mail/compose.inc | 225 +++++++++++++++++++++++++++++++++++-------------------- 1 files changed, 142 insertions(+), 83 deletions(-) diff --git a/program/steps/mail/compose.inc b/program/steps/mail/compose.inc index 0765930..521a0f7 100644 --- a/program/steps/mail/compose.inc +++ b/program/steps/mail/compose.inc @@ -4,8 +4,8 @@ +-----------------------------------------------------------------------+ | program/steps/mail/compose.inc | | | - | This file is part of the RoundCube Webmail client | - | Copyright (C) 2005-2009, RoundCube Dev. - Switzerland | + | This file is part of the Roundcube Webmail client | + | Copyright (C) 2005-2009, Roundcube Dev. - Switzerland | | Licensed under the GNU GPL | | | | PURPOSE: | @@ -55,9 +55,12 @@ } } + // select folder where to save the sent message + $_SESSION['compose']['param']['sent_mbox'] = $RCMAIL->config->get('sent_mbox'); + // pipe compose parameters thru plugins $plugin = $RCMAIL->plugins->exec_hook('message_compose', $_SESSION['compose']); - $_SESSION['compose']['param'] = array_merge($_SESSION['compose']['param'], $plugin['param']); + $_SESSION['compose']['param'] = array_merge($_SESSION['compose']['param'], $plugin['param']); // add attachments listed by message_compose hook if (is_array($plugin['attachments'])) { @@ -78,7 +81,7 @@ // save attachment if valid if (($attachment['data'] && $attachment['name']) || ($attachment['path'] && file_exists($attachment['path']))) { - $attachment = rcmail::get_instance()->plugins->exec_hook('save_attachment', $attachment); + $attachment = rcmail::get_instance()->plugins->exec_hook('attachment_save', $attachment); } if ($attachment['status'] && !$attachment['abort']) { @@ -86,6 +89,15 @@ $_SESSION['compose']['attachments'][$attachment['id']] = $attachment; } } + } + + // check if folder for saving sent messages exists and is subscribed (#1486802) + if (($sent_folder = $_SESSION['compose']['param']['sent_mbox']) && !$IMAP->mailbox_exists($sent_folder, true)) { + // folder may exist but isn't subscribed (#1485241) + if (!$IMAP->mailbox_exists($sent_folder)) + $IMAP->create_mailbox($sent_folder, true); + else + $IMAP->subscribe($sent_folder); } // redirect to a unique URL with all parameters stored in session @@ -131,7 +143,7 @@ $OUTPUT->set_env('show_sig', false); // set line length for body wrapping -$LINE_LENGTH = $RCMAIL->config->get('line_length', 75); +$LINE_LENGTH = $RCMAIL->config->get('line_length', 72); if (!empty($msg_uid)) { @@ -140,6 +152,10 @@ $CONFIG['prefer_html'] = $CONFIG['prefer_html'] || $CONFIG['htmleditor'] || $compose_mode == RCUBE_COMPOSE_DRAFT || $compose_mode == RCUBE_COMPOSE_EDIT; $MESSAGE = new rcube_message($msg_uid); + // make sure message is marked as read + if ($MESSAGE && $MESSAGE->headers && !$MESSAGE->headers->seen) + $IMAP->set_flag($msg_uid, 'SEEN'); + if (!empty($MESSAGE->headers->charset)) $IMAP->set_charset($MESSAGE->headers->charset); @@ -181,8 +197,11 @@ } } -/****** compose mode functions ********/ +// process $MESSAGE body/attachments, set $MESSAGE_BODY/$HTML_MODE vars and some session data +$MESSAGE_BODY = rcmail_prepare_message_body(); + +/****** compose mode functions ********/ function rcmail_compose_headers($attrib) { @@ -190,23 +209,23 @@ static $sa_recipients = array(); list($form_start, $form_end) = get_form_tags($attrib); - + $out = ''; $part = strtolower($attrib['part']); - + switch ($part) { case 'from': - return rcmail_compose_header_from($attrib); + return $form_start . rcmail_compose_header_from($attrib); case 'to': $fname = '_to'; $header = $param = 'to'; - + // we have a set of recipients stored is session if (($mailto_id = $_SESSION['compose']['param']['mailto']) && $_SESSION['mailto'][$mailto_id]) $fvalue = urldecode($_SESSION['mailto'][$mailto_id]); - + case 'cc': if (!$fname) { @@ -219,7 +238,7 @@ $fname = '_bcc'; $header = $param = 'bcc'; } - + $allow_attrib = array('id', 'class', 'style', 'cols', 'rows', 'tabindex'); $field_type = 'html_textarea'; break; @@ -309,7 +328,6 @@ return $out; } - function rcmail_compose_header_from($attrib) @@ -404,25 +422,14 @@ $input_from = new html_inputfield($field_attrib); $out = $input_from->show($_POST['_from']); } - - if ($form_start) - $out = $form_start.$out; return $out; } -function rcmail_compose_body($attrib) +function rcmail_prepare_message_body() { - global $RCMAIL, $CONFIG, $OUTPUT, $MESSAGE, $compose_mode, $LINE_LENGTH; - - list($form_start, $form_end) = get_form_tags($attrib); - unset($attrib['form']); - - if (empty($attrib['id'])) - $attrib['id'] = 'rcmComposeBody'; - - $attrib['name'] = '_message'; + global $RCMAIL, $CONFIG, $MESSAGE, $compose_mode, $LINE_LENGTH, $HTML_MODE; if ($CONFIG['htmleditor'] || (($compose_mode == RCUBE_COMPOSE_DRAFT || $compose_mode == RCUBE_COMPOSE_EDIT) && $MESSAGE->has_html_part())) $isHtml = true; @@ -490,6 +497,25 @@ } } + $HTML_MODE = $isHtml; + + return $body; +} + +function rcmail_compose_body($attrib) +{ + global $RCMAIL, $CONFIG, $OUTPUT, $MESSAGE, $compose_mode, $LINE_LENGTH, $HTML_MODE, $MESSAGE_BODY; + + list($form_start, $form_end) = get_form_tags($attrib); + unset($attrib['form']); + + if (empty($attrib['id'])) + $attrib['id'] = 'rcmComposeBody'; + + $attrib['name'] = '_message'; + + $isHtml = $HTML_MODE; + $out = $form_start ? "$form_start\n" : ''; $saveid = new html_hiddenfield(array('name' => '_draft_saveid', 'value' => $compose_mode==RCUBE_COMPOSE_DRAFT ? str_replace(array('<','>'), "", $MESSAGE->headers->messageID) : '')); @@ -504,7 +530,7 @@ // If desired, set this textarea to be editable by TinyMCE if ($isHtml) $attrib['class'] = 'mce_editor'; $textarea = new html_textarea($attrib); - $out .= $textarea->show($body); + $out .= $textarea->show($MESSAGE_BODY); $out .= $form_end ? "\n$form_end" : ''; $OUTPUT->set_env('composebody', $attrib['id']); @@ -515,20 +541,40 @@ // include GoogieSpell if (!empty($CONFIG['enable_spellcheck'])) { - $lang = strtolower(substr($_SESSION['language'], 0, 2)); - - $spellcheck_langs = (array)$RCMAIL->config->get('spellcheck_languages', array('da'=>'Dansk', 'de'=>'Deutsch', 'en' => 'English', 'es'=>'Español', 'fr'=>'Français', 'it'=>'Italiano', 'nl'=>'Nederlands', 'pl'=>'Polski', 'pt'=>'Português', 'fi'=>'Suomi', 'sv'=>'Svenska')); + $engine = $RCMAIL->config->get('spellcheck_engine','googie'); + $spellcheck_langs = (array) $RCMAIL->config->get('spellcheck_languages', + array('da'=>'Dansk', 'de'=>'Deutsch', 'en' => 'English', 'es'=>'Español', + 'fr'=>'Français', 'it'=>'Italiano', 'nl'=>'Nederlands', 'pl'=>'Polski', + 'pt'=>'Português', 'fi'=>'Suomi', 'sv'=>'Svenska')); + + // googie works only with two-letter codes + if ($engine == 'googie') { + $lang = strtolower(substr($_SESSION['language'], 0, 2)); + + $spellcheck_langs_googie = array(); + foreach ($spellcheck_langs as $key => $name) + $spellcheck_langs_googie[strtolower(substr($key,0,2))] = $name; + $spellcheck_langs = $spellcheck_langs_googie; + } + else { + $lang = $_SESSION['language']; + + // if not found in the list, try with two-letter code + if (!$spellcheck_langs[$lang]) + $lang = strtolower(substr($lang, 0, 2)); + } + if (!$spellcheck_langs[$lang]) $lang = 'en'; - + $editor_lang_set = array(); foreach ($spellcheck_langs as $key => $name) { $editor_lang_set[] = ($key == $lang ? '+' : '') . JQ($name).'='.JQ($key); - } + } $OUTPUT->include_script('googiespell.js'); $OUTPUT->add_script(sprintf( - "var googie = new GoogieSpell('\$__skin_path/images/googiespell/','%s&_action=spell&lang=');\n". + "var googie = new GoogieSpell('\$__skin_path/images/googiespell/','?_task=utils&_action=spell&lang=');\n". "googie.lang_chck_spell = \"%s\";\n". "googie.lang_rsm_edt = \"%s\";\n". "googie.lang_close = \"%s\";\n". @@ -539,7 +585,6 @@ "googie.setSpellContainer('spellcheck-control');\n". "googie.decorateTextarea('%s');\n". "%s.set_env('spellcheck', googie);", - $RCMAIL->comm_path, JQ(Q(rcube_label('checkspelling'))), JQ(Q(rcube_label('resumeediting'))), JQ(Q(rcube_label('close'))), @@ -565,36 +610,29 @@ global $RCMAIL, $MESSAGE, $LINE_LENGTH; if (!$bodyIsHtml) { + $body = preg_replace('/\r?\n/', "\n", $body); + // try to remove the signature - if ($RCMAIL->config->get('strip_existing_sig', true) && ($sp = strrpos($body, '-- ')) !== false && ($sp == 0 || $body{$sp-1} == "\n")) { - if ($body{$sp+3}==' ' || $body{$sp+3}=="\n" || $body{$sp+3}=="\r") - $body = substr($body, 0, max(0, $sp-1)); - } - - // soft-wrap message first - $body = rcmail_wrap_quoted($body, $LINE_LENGTH); - - $body = rtrim($body, "\r\n"); - - if ($body) { - // split body into single lines - $a_lines = preg_split('/\r?\n/', $body); - - // add > to each line - for ($n=0; $n<sizeof($a_lines); $n++) { - if (strpos($a_lines[$n], '>')===0) - $a_lines[$n] = '>'.$a_lines[$n]; - else - $a_lines[$n] = '> '.$a_lines[$n]; + if ($RCMAIL->config->get('strip_existing_sig', true)) { + $len = strlen($body); + while (($sp = strrpos($body, "-- \n", $sp ? -$len+$sp-1 : 0)) !== false) { + if ($sp == 0 || $body[$sp-1] == "\n") { + // do not touch blocks with more that X lines + if (substr_count($body, "\n", $sp) < $RCMAIL->config->get('sig_max_lines', 15)) { + $body = substr($body, 0, max(0, $sp-1)); + } + break; + } } - - $body = join("\n", $a_lines); } + + // soft-wrap and quote message text + $body = rcmail_wrap_and_quote(rtrim($body, "\n"), $LINE_LENGTH); // add title line(s) - $prefix = rc_wordwrap(sprintf("On %s, %s wrote:\n", + $prefix = sprintf("On %s, %s wrote:\n", $MESSAGE->headers->date, - $MESSAGE->get_header('from')), $LINE_LENGTH); + $MESSAGE->get_header('from')); $suffix = ''; @@ -613,7 +651,7 @@ $prefix = sprintf("<p>On %s, %s wrote:</p>\n", $MESSAGE->headers->date, htmlspecialchars(Q($MESSAGE->get_header('from'), 'replace'), ENT_COMPAT, $RCMAIL->output->get_charset())); - $prefix .= '<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px; width:100%">'; + $prefix .= '<blockquote>'; if ($RCMAIL->config->get('top_posting')) { $prefix = '<br>' . $prefix; @@ -712,16 +750,33 @@ { global $OUTPUT; - $cid_map = array(); + $cid_map = $messages = array(); foreach ((array)$message->mime_parts as $pid => $part) { if (($part->ctype_primary != 'message' || !$bodyIsHtml) && $part->ctype_primary != 'multipart' && - ($part->disposition == 'attachment' || ($part->disposition == 'inline' && $bodyIsHtml) || $part->filename)) - { - if ($attachment = rcmail_save_attachment($message, $pid)) { + ($part->disposition == 'attachment' || ($part->disposition == 'inline' && $bodyIsHtml) || $part->filename) + && $part->mimetype != 'application/ms-tnef' + ) { + $skip = false; + if ($part->mimetype == 'message/rfc822') { + $messages[] = $part->mime_id; + } else if ($messages) { + // skip attachments included in message/rfc822 attachment (#1486487) + foreach ($messages as $mimeid) + if (strpos($part->mime_id, $mimeid.'.') === 0) { + $skip = true; + break; + } + } + + if (!$skip && ($attachment = rcmail_save_attachment($message, $pid))) { $_SESSION['compose']['attachments'][$attachment['id']] = $attachment; - if ($bodyIsHtml && $part->content_id) { - $cid_map['cid:'.$part->content_id] = $OUTPUT->app->comm_path.'&_action=display-attachment&_file=rcmfile'.$attachment['id']; + if ($bodyIsHtml && ($part->content_id || $part->content_location)) { + $url = $OUTPUT->app->comm_path.'&_action=display-attachment&_file=rcmfile'.$attachment['id']; + if ($part->content_id) + $cid_map['cid:'.$part->content_id] = $url; + else + $cid_map[$part->content_location] = $url; } } } @@ -739,14 +794,18 @@ $cid_map = array(); foreach ((array)$message->mime_parts as $pid => $part) { - if ($part->content_id && $part->filename) { + if (($part->content_id || $part->content_location) && $part->filename) { if ($attachment = rcmail_save_attachment($message, $pid)) { $_SESSION['compose']['attachments'][$attachment['id']] = $attachment; - $cid_map['cid:'.$part->content_id] = $OUTPUT->app->comm_path.'&_action=display-attachment&_file=rcmfile'.$attachment['id']; + $url = $OUTPUT->app->comm_path.'&_action=display-attachment&_file=rcmfile'.$attachment['id']; + if ($part->content_id) + $cid_map['cid:'.$part->content_id] = $url; + else + $cid_map[$part->content_location] = $url; } } } - + return $cid_map; } @@ -780,7 +839,7 @@ 'size' => $path ? filesize($path) : strlen($data), ); - $attachment = rcmail::get_instance()->plugins->exec_hook('save_attachment', $attachment); + $attachment = rcmail::get_instance()->plugins->exec_hook('attachment_save', $attachment); if ($attachment['status']) { unset($attachment['data'], $attachment['status'], $attachment['content_id'], $attachment['abort']); @@ -804,7 +863,7 @@ 'size' => strlen($data), ); - $attachment = rcmail::get_instance()->plugins->exec_hook('save_attachment', $attachment); + $attachment = rcmail::get_instance()->plugins->exec_hook('attachment_save', $attachment); if ($attachment['status']) { unset($attachment['data'], $attachment['status'], $attachment['content_id'], $attachment['abort']); @@ -881,7 +940,7 @@ $out = "\n"; $jslist = array(); - + if (is_array($_SESSION['compose']['attachments'])) { if ($attrib['deleteicon']) { @@ -941,7 +1000,7 @@ $button = new html_inputfield(array('type' => 'button')); $out = html::div($attrib, - $OUTPUT->form_tag(array('name' => 'form', 'method' => 'post', 'enctype' => 'multipart/form-data'), + $OUTPUT->form_tag(array('name' => 'uploadform', 'method' => 'post', 'enctype' => 'multipart/form-data'), html::div(null, rcmail_compose_attachment_field(array('size' => $attrib[attachmentfieldsize]))) . html::div('hint', rcube_label(array('name' => 'maxuploadsize', 'vars' => array('size' => $max_filesize)))) . html::div('buttons', @@ -971,7 +1030,7 @@ list($form_start, $form_end) = get_form_tags($attrib); unset($attrib['form']); - + $attrib['name'] = '_priority'; $selector = new html_select($attrib); @@ -981,7 +1040,7 @@ rcube_label('high'), rcube_label('highest')), array(5, 4, 0, 2, 1)); - + if (isset($_POST['_priority'])) $sel = $_POST['_priority']; else if (intval($MESSAGE->headers->priority) != 3) @@ -992,7 +1051,7 @@ $out = $form_start ? "$form_start\n" : ''; $out .= $selector->show($sel); $out .= $form_end ? "\n$form_end" : ''; - + return $out; } @@ -1000,10 +1059,10 @@ function rcmail_receipt_checkbox($attrib) { global $MESSAGE, $compose_mode; - + list($form_start, $form_end) = get_form_tags($attrib); unset($attrib['form']); - + if (!isset($attrib['id'])) $attrib['id'] = 'receipt'; @@ -1036,7 +1095,7 @@ if (empty($attrib['name'])) $attrib['name'] = 'editorSelect'; - + $attrib['onchange'] = "return rcmail_toggle_editor(this, '".$attrib['editorid']."', '_is_html')"; $select = new html_select($attrib); @@ -1061,7 +1120,7 @@ { $attrib['name'] = '_store_target'; $select = rcmail_mailbox_select(array_merge($attrib, array('noselection' => '- '.rcube_label('dontsave').' -'))); - return $select->show(rcmail::get_instance()->config->get('sent_mbox'), $attrib); + return $select->show($_SESSION['compose']['param']['sent_mbox'], $attrib); } @@ -1070,7 +1129,7 @@ global $RCMAIL, $MESSAGE_FORM; $form_start = ''; - if (!strlen($MESSAGE_FORM)) + if (!$MESSAGE_FORM) { $hiddenfields = new html_hiddenfield(array('name' => '_task', 'value' => $RCMAIL->task)); $hiddenfields->add(array('name' => '_action', 'value' => 'send')); @@ -1079,10 +1138,10 @@ $form_start .= $hiddenfields->show(); } - $form_end = (strlen($MESSAGE_FORM) && !strlen($attrib['form'])) ? '</form>' : ''; + $form_end = ($MESSAGE_FORM && !strlen($attrib['form'])) ? '</form>' : ''; $form_name = !empty($attrib['form']) ? $attrib['form'] : 'form'; - if (!strlen($MESSAGE_FORM)) + if (!$MESSAGE_FORM) $RCMAIL->output->add_gui_object('messageform', $form_name); $MESSAGE_FORM = $form_name; @@ -1107,4 +1166,4 @@ $OUTPUT->send('compose'); -?> + -- Gitblit v1.9.1