From e019f2d0f2dc2fbfa345ab5d7ae85e67bfdd76b8 Mon Sep 17 00:00:00 2001 From: alecpl <alec@alec.pl> Date: Sat, 25 Sep 2010 09:03:53 -0400 Subject: [PATCH] - s/RoundCube/Roundcube/ --- program/include/rcube_smtp.php | 39 +++++++++++++++++++-------------------- 1 files changed, 19 insertions(+), 20 deletions(-) diff --git a/program/include/rcube_smtp.php b/program/include/rcube_smtp.php index 4471435..3c9f669 100644 --- a/program/include/rcube_smtp.php +++ b/program/include/rcube_smtp.php @@ -4,8 +4,8 @@ +-----------------------------------------------------------------------+ | program/include/rcube_smtp.php | | | - | This file is part of the RoundCube Webmail client | - | Copyright (C) 2005-2010, RoundCube Dev. - Switzerland | + | This file is part of the Roundcube Webmail client | + | Copyright (C) 2005-2010, Roundcube Dev. - Switzerland | | Licensed under the GNU GPL | | | | PURPOSE: | @@ -38,21 +38,16 @@ /** - * Object constructor - * - * @param - */ - function __construct() - { - } - - - /** * SMTP Connection and authentication + * + * @param string Server host + * @param string Server port + * @param string User name + * @param string Password * * @return bool Returns true on success, or false on error */ - public function connect() + public function connect($host=null, $port=null, $user=null, $pass=null) { $RCMAIL = rcmail::get_instance(); @@ -64,16 +59,16 @@ // let plugins alter smtp connection config $CONFIG = $RCMAIL->plugins->exec_hook('smtp_connect', array( - 'smtp_server' => $RCMAIL->config->get('smtp_server'), - 'smtp_port' => $RCMAIL->config->get('smtp_port', 25), - 'smtp_user' => $RCMAIL->config->get('smtp_user'), - 'smtp_pass' => $RCMAIL->config->get('smtp_pass'), + 'smtp_server' => $host ? $host : $RCMAIL->config->get('smtp_server'), + 'smtp_port' => $port ? $port : $RCMAIL->config->get('smtp_port', 25), + 'smtp_user' => $user ? $user : $RCMAIL->config->get('smtp_user'), + 'smtp_pass' => $pass ? $pass : $RCMAIL->config->get('smtp_pass'), 'smtp_auth_type' => $RCMAIL->config->get('smtp_auth_type'), 'smtp_helo_host' => $RCMAIL->config->get('smtp_helo_host'), 'smtp_timeout' => $RCMAIL->config->get('smtp_timeout'), )); - $smtp_host = str_replace('%h', $_SESSION['imap_host'], $CONFIG['smtp_server']); + $smtp_host = rcube_parse_host($CONFIG['smtp_server']); // when called from Installer it's possible to have empty $smtp_host here if (!$smtp_host) $smtp_host = 'localhost'; $smtp_port = is_numeric($CONFIG['smtp_port']) ? $CONFIG['smtp_port'] : 25; @@ -196,7 +191,9 @@ // set From: address if (PEAR::isError($this->conn->mailFrom($from))) { - $this->error = array('label' => 'smtpfromerror', 'vars' => array('from' => $from, 'code' => $this->conn->_code)); + $err = $this->conn->getResponse(); + $this->error = array('label' => 'smtpfromerror', 'vars' => array( + 'from' => $from, 'code' => $this->conn->_code, 'msg' => $err[1])); $this->response[] .= "Failed to set sender '$from'"; $this->reset(); return false; @@ -215,7 +212,9 @@ foreach ($recipients as $recipient) { if (PEAR::isError($this->conn->rcptTo($recipient))) { - $this->error = array('label' => 'smtptoerror', 'vars' => array('to' => $recipient, 'code' => $this->conn->_code)); + $err = $this->conn->getResponse(); + $this->error = array('label' => 'smtptoerror', 'vars' => array( + 'to' => $recipient, 'code' => $this->conn->_code, 'msg' => $err[1])); $this->response[] .= "Failed to add recipient '$recipient'"; $this->reset(); return false; -- Gitblit v1.9.1