From ed1d212ae2daea5e4bd043417610177093e99f19 Mon Sep 17 00:00:00 2001 From: Aleksander Machniak <alec@alec.pl> Date: Sat, 16 Jan 2016 03:03:51 -0500 Subject: [PATCH] Improved SVG cleanup code --- program/lib/Roundcube/bootstrap.php | 38 ++++++++++++++++++++++---------------- 1 files changed, 22 insertions(+), 16 deletions(-) diff --git a/program/lib/Roundcube/bootstrap.php b/program/lib/Roundcube/bootstrap.php index 7acd4a4..94e628b 100644 --- a/program/lib/Roundcube/bootstrap.php +++ b/program/lib/Roundcube/bootstrap.php @@ -25,8 +25,7 @@ */ $config = array( -// 'error_reporting' => E_ALL & ~E_NOTICE & ~E_STRICT, - 'error_reporting' => E_STRICT, + 'error_reporting' => E_ALL & ~E_NOTICE & ~E_STRICT, // Some users are not using Installer, so we'll check some // critical PHP settings here. Only these, which doesn't provide // an error/warning in the logs later. See (#1486307). @@ -46,8 +45,10 @@ foreach ($config as $optname => $optval) { $ini_optval = filter_var(ini_get($optname), is_bool($optval) ? FILTER_VALIDATE_BOOLEAN : FILTER_VALIDATE_INT); if ($optval != $ini_optval && @ini_set($optname, $optval) === false) { - $error = "ERROR: Wrong '$optname' option value and it wasn't possible to set it to required value ($optval).\n" + $optval = !is_bool($optval) ? $optval : ($optval ? 'On' : 'Off'); + $error = "ERROR: Wrong '$optname' option value and it wasn't possible to set it to required value ($optval).\n" . "Check your PHP configuration (including php_admin_flag)."; + if (defined('STDERR')) fwrite(STDERR, $error); else echo $error; exit(1); } @@ -137,7 +138,7 @@ /** * Parse a human readable string for a number of bytes. * - * @param string $str Input string + * @param string $str Input string * * @return float Number of bytes */ @@ -187,7 +188,7 @@ /** * Returns number of seconds for a specified offset string. * - * @param string $str String representation of the offset (e.g. 20min, 5h, 2days, 1week) + * @param string $str String representation of the offset (e.g. 20min, 5h, 2days, 1week) * * @return int Number of seconds */ @@ -219,12 +220,12 @@ /** * Create a unix timestamp with a specified offset from now. * - * @param string $offset_str String representation of the offset (e.g. 20min, 5h, 2days) - * @param int $factor Factor to multiply with the offset + * @param string $offset_str String representation of the offset (e.g. 20min, 5h, 2days) + * @param int $factor Factor to multiply with the offset * * @return int Unix timestamp */ -function get_offset_time($offset_str, $factor=1) +function get_offset_time($offset_str, $factor = 1) { return time() + get_offset_sec($offset_str) * $factor; } @@ -240,7 +241,7 @@ * * @return string Abbreviated string */ -function abbreviate_string($str, $maxlength, $placeholder='...', $ending=false) +function abbreviate_string($str, $maxlength, $placeholder = '...', $ending = false) { $length = mb_strlen($str); @@ -253,7 +254,9 @@ $first_part_length = floor(($maxlength - $placeholder_length)/2); $second_starting_location = $length - $maxlength + $first_part_length + $placeholder_length; - $str = mb_substr($str, 0, $first_part_length) . $placeholder . mb_substr($str, $second_starting_location); + $prefix = mb_substr($str, 0, $first_part_length); + $suffix = mb_substr($str, $second_starting_location); + $str = $prefix . $placeholder . $suffix; } return $str; @@ -262,7 +265,7 @@ /** * Get all keys from array (recursive). * - * @param array $array Input array + * @param array $array Input array * * @return array List of array keys */ @@ -308,8 +311,8 @@ /** * Compose a valid representation of name and e-mail address * - * @param string $email E-mail address - * @param string $name Person name + * @param string $email E-mail address + * @param string $name Person name * * @return string Formatted string */ @@ -363,7 +366,8 @@ return str_replace( array('-stable', '-git'), array('.0', '.99'), - $version); + $version + ); } /** @@ -377,7 +381,7 @@ static $idn, $loaded; if (!$loaded) { - $idn = new Net_IDNA2(); + $idn = new Net_IDNA2(); $loaded = true; } @@ -388,6 +392,7 @@ catch (Exception $e) { } } + return $domain; } } @@ -399,7 +404,7 @@ static $idn, $loaded; if (!$loaded) { - $idn = new Net_IDNA2(); + $idn = new Net_IDNA2(); $loaded = true; } @@ -410,6 +415,7 @@ catch (Exception $e) { } } + return $domain; } } -- Gitblit v1.9.1