From cb2bc809ef29f349d38c89e202d821e67bb4c947 Mon Sep 17 00:00:00 2001
From: thomascube <thomas@roundcube.net>
Date: Tue, 21 Sep 2010 14:47:55 -0400
Subject: [PATCH] Fix db_mode check in insert_id()
---
program/steps/mail/get.inc | 53 ++++++++++++++++++++++++++++++++++-------------------
1 files changed, 34 insertions(+), 19 deletions(-)
diff --git a/program/steps/mail/get.inc b/program/steps/mail/get.inc
index a41925a..07af755 100644
--- a/program/steps/mail/get.inc
+++ b/program/steps/mail/get.inc
@@ -35,6 +35,29 @@
ob_end_clean();
+// Now we need IMAP connection
+if (!$RCMAIL->imap_connect()) {
+ // Get action is often executed simultanously.
+ // Some servers have MAXPERIP or other limits.
+ // To workaround this we'll wait for some time
+ // and try again (once).
+ // Note: Random sleep interval is used to minimize concurency
+ // in getting message parts
+ if (!isset($_GET['_redirected'])) {
+ usleep(rand(10,30)*100000); // 1-3 sec.
+ header('Location: ' . $_SERVER['REQUEST_URI'] . '&_redirected=1');
+ }
+ else {
+ raise_error(array(
+ 'code' => 500, 'type' => 'php',
+ 'file' => __FILE__, 'line' => __LINE__,
+ 'message' => 'Unable to get/display message part. IMAP connection error'),
+ true, true);
+ }
+ // Don't kill session, just quit (#1486995)
+ exit;
+}
+
// similar code as in program/steps/mail/show.inc
if (!empty($_GET['_uid'])) {
$RCMAIL->config->set('prefer_html', true);
@@ -50,22 +73,13 @@
}
else if ($pid = get_input_value('_part', RCUBE_INPUT_GET)) {
- // TNEF encoded attachment part
- if (preg_match('/^winmail\.([0-9.]+)\.([0-9]+)$/', $pid, $nt)) {
- $pid = $nt[1]; $i = $nt[2];
- if ($part = $MESSAGE->mime_parts[$pid]) {
- $tnef_arr = $IMAP->tnef_decode($part, $MESSAGE->uid);
- if (is_a($tnef_arr[$i], 'rcube_message_part'))
- $MESSAGE->mime_parts[$pid] = $tnef_arr[$i];
- }
- }
-
+
if ($part = $MESSAGE->mime_parts[$pid]) {
$ctype_primary = strtolower($part->ctype_primary);
$ctype_secondary = strtolower($part->ctype_secondary);
$mimetype = sprintf('%s/%s', $ctype_primary, $ctype_secondary);
-
- $browser = new rcube_browser;
+
+ $browser = $RCMAIL->output->browser;
// send download headers
if ($_GET['_download']) {
@@ -82,7 +96,7 @@
}
// deliver part content
- if ($ctype_primary == 'text' && $ctype_secondary == 'html') {
+ if ($ctype_primary == 'text' && $ctype_secondary == 'html' && empty($_GET['_download'])) {
// get part body if not available
if (!$part->body)
$part->body = $MESSAGE->get_part_content($part->mime_id);
@@ -93,20 +107,21 @@
else {
// don't kill the connection if download takes more than 30 sec.
@set_time_limit(0);
-
+
$filename = $part->filename ? $part->filename : ($MESSAGE->subject ? $MESSAGE->subject : 'roundcube') . '.'.$ctype_secondary;
-
+ $filename = preg_replace('[\r\n]', '', $filename);
+
if ($browser->ie && $browser->ver < 7)
$filename = rawurlencode(abbreviate_string($filename, 55));
else if ($browser->ie)
$filename = rawurlencode($filename);
else
$filename = addcslashes($filename, '"');
-
+
$disposition = !empty($_GET['_download']) ? 'attachment' : 'inline';
-
+
header("Content-Disposition: $disposition; filename=\"$filename\"");
-
+
// turn off output buffering and print part content
if ($part->body)
echo $part->body;
@@ -138,4 +153,4 @@
header('HTTP/1.1 404 Not Found');
exit;
-?>
+
--
Gitblit v1.9.1