From c321a955a7b0f6d6b13ffaebf040a6c7091037ae Mon Sep 17 00:00:00 2001 From: thomascube <thomas@roundcube.net> Date: Mon, 16 Jan 2012 10:14:41 -0500 Subject: [PATCH] Merged devel-framework branch (r5746:5779) back into trunk --- program/steps/settings/save_folder.inc | 42 ++++++++++++++++++++++++++++++------------ 1 files changed, 30 insertions(+), 12 deletions(-) diff --git a/program/steps/settings/save_folder.inc b/program/steps/settings/save_folder.inc index d8ba87b..b912c09 100644 --- a/program/steps/settings/save_folder.inc +++ b/program/steps/settings/save_folder.inc @@ -22,7 +22,7 @@ // WARNING: folder names in UI are encoded with RCMAIL_CHARSET // init IMAP connection -$RCMAIL->imap_connect(); +$STORAGE = $RCMAIL->get_storage(); $name = trim(get_input_value('_name', RCUBE_INPUT_POST, true)); @@ -33,13 +33,11 @@ $old_imap = rcube_charset_convert($old, RCMAIL_CHARSET, 'UTF7-IMAP'); // $path is in UTF7-IMAP already -$delimiter = $IMAP->get_hierarchy_delimiter(); -$special = (strlen($old_imap) && in_array($old_imap, (array) $RCMAIL->config->get('default_imap_folders'))); -$protected = ($special && $RCMAIL->config->get('protect_default_folders')); - +$delimiter = $STORAGE->get_hierarchy_delimiter(); +$options = strlen($old_imap) ? rcmail_folder_options($old_imap) : array(); // Folder name checks -if ($protected) { +if ($options['protected'] || $options['norename']) { } else if (!strlen($name)) { $error = rcube_label('cannotbeempty'); @@ -61,15 +59,32 @@ $OUTPUT->command('display_message', $error, 'error'); } else { - if ($protected) { + if ($options['protected'] || $options['norename']) { $name_imap = $old_imap; } else if (strlen($path)) { $name_imap = $path . $delimiter . $name_imap; } + else { + $name_imap = $STORAGE->mod_folder($name_imap, 'in'); + } +} +// Check access rights to the parent folder +if (!$error && strlen($path) && (!strlen($old_imap) || $old_imap != $name_imap)) { + $parent_opts = $STORAGE->folder_info($path); + if ($parent_opts['namespace'] != 'personal' + && (empty($parent_opts['rights']) || !preg_match('/[ck]/', implode($parent_opts))) + ) { + $error = rcube_label('parentnotwritable'); + } +} + +if (!$error) { $folder['name'] = $name_imap; $folder['oldname'] = $old_imap; + $folder['class'] = ''; + $folder['options'] = $options; $folder['settings'] = array( // List view mode: 0-list, 1-threads 'view_mode' => (int) get_input_value('_viewmode', RCUBE_INPUT_POST), @@ -81,12 +96,14 @@ // create a new mailbox if (!$error && !strlen($old)) { + $folder['subscribe'] = true; + $plugin = $RCMAIL->plugins->exec_hook('folder_create', array('record' => $folder)); $folder = $plugin['record']; if (!$plugin['abort']) { - $created = $IMAP->create_mailbox($folder['name'], TRUE); + $created = $STORAGE->create_folder($folder['name'], $folder['subscribe']); } else { $created = $plugin['result']; @@ -105,8 +122,10 @@ $RCMAIL->user->save_prefs(array('message_threading' => $a_threaded)); } + rcmail_update_folder_row($folder['name'], null, $folder['subscribe'], $folder['class']); $OUTPUT->show_message('foldercreated', 'confirmation'); - $OUTPUT->command('reload', 250); + // reset folder preview frame + $OUTPUT->command('subscription_select'); $OUTPUT->send('iframe'); } else { @@ -124,7 +143,7 @@ if (!$plugin['abort']) { if ($rename) { - $updated = $RCMAIL->imap->rename_mailbox($folder['oldname'], $folder['name']); + $updated = $STORAGE->rename_folder($folder['oldname'], $folder['name']); } else { $updated = true; @@ -141,7 +160,6 @@ // In case of name change update names of childrens in settings if ($rename) { - $delimiter = $RCMAIL->imap->get_hierarchy_delimiter(); $oldprefix = '/^' . preg_quote($folder['oldname'] . $delimiter, '/') . '/'; foreach ($a_threaded as $key => $val) { if ($key == $folder['oldname']) { @@ -163,7 +181,7 @@ $OUTPUT->show_message('folderupdated', 'confirmation'); if ($rename) { - $OUTPUT->command('reload', 250); + rcmail_update_folder_row($folder['name'], $folder['oldname'], $folder['subscribe'], $folder['class']); $OUTPUT->send('iframe'); } } -- Gitblit v1.9.1