From ba48318e2c87f4d07982978e539151c1abcf2114 Mon Sep 17 00:00:00 2001 From: Aleksander Machniak <alec@alec.pl> Date: Mon, 28 Sep 2015 13:21:28 -0400 Subject: [PATCH] Fix so database_attachments::cleanup() does not remove attachments from other sessions (#1490542) --- plugins/database_attachments/database_attachments.php | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/plugins/database_attachments/database_attachments.php b/plugins/database_attachments/database_attachments.php index 735915a..31747b3 100644 --- a/plugins/database_attachments/database_attachments.php +++ b/plugins/database_attachments/database_attachments.php @@ -22,7 +22,7 @@ protected $cache; // A prefix for the cache key used in the session and in the key field of the cache table - protected $prefix = "db_attach"; + const PREFIX = "ATTACH"; /** * Save a newly uploaded attachment @@ -153,9 +153,16 @@ $ttl = 12 * 60 * 60; // default: 12 hours $ttl = $rcmail->config->get('database_attachments_cache_ttl', $ttl); $type = $rcmail->config->get('database_attachments_cache', 'db'); + $prefix = self::PREFIX; + + // Add session identifier to the prefix to prevent from removing attachments + // in other sessions of the same user (#1490542) + if ($id = session_id()) { + $prefix .= $id; + } // Init SQL cache (disable cache data serialization) - $this->cache = $rcmail->get_cache($this->prefix, $type, $ttl, false); + $this->cache = $rcmail->get_cache($prefix, $type, $ttl, false); } return $this->cache; -- Gitblit v1.9.1