From b1f0846727331f58342e9cfdd02df03ea8f15181 Mon Sep 17 00:00:00 2001 From: alecpl <alec@alec.pl> Date: Fri, 07 Oct 2011 04:33:24 -0400 Subject: [PATCH] - Make sure LDAP name fields aren't arrays (#1488108) --- program/steps/mail/search.inc | 33 ++++++++++++++++++--------------- 1 files changed, 18 insertions(+), 15 deletions(-) diff --git a/program/steps/mail/search.inc b/program/steps/mail/search.inc index cfdb6fb..2e7fd13 100644 --- a/program/steps/mail/search.inc +++ b/program/steps/mail/search.inc @@ -27,10 +27,11 @@ $imap_charset = RCMAIL_CHARSET; // get search string -$str = get_input_value('_q', RCUBE_INPUT_GET); -$filter = get_input_value('_filter', RCUBE_INPUT_GET); -$mbox = get_input_value('_mbox', RCUBE_INPUT_GET); +$str = get_input_value('_q', RCUBE_INPUT_GET, true); +$mbox = get_input_value('_mbox', RCUBE_INPUT_GET, true); +$filter = get_input_value('_filter', RCUBE_INPUT_GET); $headers = get_input_value('_headers', RCUBE_INPUT_GET); + $search_request = md5($mbox.$filter.$str); // add list filter string @@ -77,12 +78,11 @@ case 'text': $subject['text'] = 'TEXT'; break; default: $subject[$header] = 'HEADER '.strtoupper($header); } - + // save search modifiers for the current folder to user prefs $search_mods = $RCMAIL->config->get('search_mods', $SEARCH_MODS_DEFAULT); $search_mods[$mbox] = array_fill_keys(array_keys($subject), 1); $RCMAIL->user->save_prefs(array('search_mods' => $search_mods)); - console($search_mods); } else { // search in subject by default $subject['subject'] = 'HEADER SUBJECT'; @@ -105,34 +105,37 @@ // Get the headers $result_h = $IMAP->list_headers($mbox, 1, $_SESSION['sort_col'], $_SESSION['sort_order']); -$count = $IMAP->messagecount(); +$count = $IMAP->messagecount(NULL, $IMAP->threading ? 'THREADS' : 'ALL'); // save search results in session if (!is_array($_SESSION['search'])) $_SESSION['search'] = array(); if ($search_str) { - $_SESSION['search'][$search_request] = $IMAP->get_search_set(); + $_SESSION['search'] = $IMAP->get_search_set(); $_SESSION['last_text_search'] = $str; } +$_SESSION['search_request'] = $search_request; // Make sure we got the headers -if (!empty($result_h)) -{ +if (!empty($result_h)) { rcmail_js_message_list($result_h); if ($search_str) - $OUTPUT->show_message('searchsuccessful', 'confirmation', array('nr' => $count)); + $OUTPUT->show_message('searchsuccessful', 'confirmation', array('nr' => $IMAP->messagecount(NULL, 'ALL'))); } -else -{ +// handle IMAP errors (e.g. #1486905) +else if ($err_code = $IMAP->get_error_code()) { + rcmail_display_server_error(); +} +else { $OUTPUT->show_message('searchnomatch', 'notice'); } // update message count display -$OUTPUT->set_env('search_request', $search_str ? $search_request : -1); +$OUTPUT->set_env('search_request', $search_str ? $search_request : ''); $OUTPUT->set_env('messagecount', $count); $OUTPUT->set_env('pagecount', ceil($count/$IMAP->page_size)); -$OUTPUT->command('set_rowcount', rcmail_get_messagecount_text($count, 1)); +$OUTPUT->command('set_rowcount', rcmail_get_messagecount_text($count, 1), $mbox); $OUTPUT->send(); -?> + -- Gitblit v1.9.1