From ae0c133d45fbb95a8266db505033690af46b4363 Mon Sep 17 00:00:00 2001 From: Aleksander Machniak <alec@alec.pl> Date: Fri, 26 Apr 2013 05:28:50 -0400 Subject: [PATCH] Fix error handling in CLI mode, use STDERR and non-empty exit code (#1489043) --- installer/rcube_install.php | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/installer/rcube_install.php b/installer/rcube_install.php index b86ccab..2e12987 100644 --- a/installer/rcube_install.php +++ b/installer/rcube_install.php @@ -637,8 +637,10 @@ */ function update_db($version) { - system(INSTALL_PATH . "bin/updatedb.sh --package=roundcube --version=" . $version - . " --dir=" . INSTALL_PATH . "SQL", $result); + system(INSTALL_PATH . "bin/updatedb.sh --package=roundcube" + . " --version=" . escapeshellarg($version) + . " --dir=" . INSTALL_PATH . "SQL" + . " 2>&1", $result); return !$result; } -- Gitblit v1.9.1