From a172f39ff75da0aee00bbfb993c356d0aeba1df0 Mon Sep 17 00:00:00 2001
From: Aleksander Machniak <alec@alec.pl>
Date: Wed, 11 Mar 2015 14:35:07 -0400
Subject: [PATCH] Fix bug where TinyMCE area height was too small on slow network connection (#1490310)
---
program/js/editor.js | 178 ++++++++++++++++++++++++++++++++++++++++------------------
1 files changed, 122 insertions(+), 56 deletions(-)
diff --git a/program/js/editor.js b/program/js/editor.js
index 0dd8fef..296a161 100644
--- a/program/js/editor.js
+++ b/program/js/editor.js
@@ -36,11 +36,13 @@
function rcube_text_editor(config, id)
{
var ref = this,
+ abs_url = location.href.replace(/[?#].*$/, '').replace(/\/$/, ''),
conf = {
selector: '#' + ($('#' + id).is('.mce_editor') ? id : 'fake-editor-id'),
+ cache_suffix: 's=4010900',
theme: 'modern',
language: config.lang,
- content_css: 'program/js/tinymce/roundcube/content.css?v1',
+ content_css: rcmail.assets_path('program/js/tinymce/roundcube/content.css'),
menubar: false,
statusbar: false,
toolbar_items_size: 'small',
@@ -50,7 +52,8 @@
convert_urls: false, // #1486944
image_description: false,
paste_webkit_style: "color font-size font-family",
- paste_data_images: true
+ paste_data_images: true,
+ browser_spellcheck: true
};
// register spellchecker for plain text editor
@@ -60,6 +63,15 @@
if (config.spellcheck_observer) {
this.spellchecker.spelling_state_observer = this.spellcheck_observer = config.spellcheck_observer;
}
+ }
+
+ // secure spellchecker requests with Roundcube token
+ // Note: must be registered only once (#1490311)
+ if (!tinymce.registered_request_token) {
+ tinymce.registered_request_token = true;
+ tinymce.util.XHR.on('beforeSend', function(e) {
+ e.xhr.setRequestHeader('X-Roundcube-Request', rcmail.env.request_token);
+ });
}
// minimal editor
@@ -81,7 +93,7 @@
toolbar: 'bold italic underline | alignleft aligncenter alignright alignjustify'
+ ' | bullist numlist outdent indent ltr rtl blockquote | forecolor backcolor | fontselect fontsizeselect'
+ ' | link unlink table | emoticons charmap image media | code searchreplace undo redo',
- spellchecker_rpc_url: '../../../../../?_task=utils&_action=spell_html&_remote=1',
+ spellchecker_rpc_url: abs_url + '/?_task=utils&_action=spell_html&_remote=1',
spellchecker_language: rcmail.env.spell_lang,
accessibility_focus: false,
file_browser_callback: function(name, url, type, win) { ref.file_browser_callback(name, url, type); },
@@ -122,6 +134,15 @@
return;
}
+ var area = $('#' + this.id),
+ height = $('div.mce-toolbar-grp:first', area.parent()).height();
+
+ // the editor might be still not fully loaded, making the editing area
+ // inaccessible, wait and try again (#1490310)
+ if (height > 200 || height > area.height()) {
+ return setTimeout(function () { ref.init_callback(event); }, 300);
+ }
+
var css = {},
elem = rcube_find_object('_from'),
fe = rcmail.env.compose_focus_elem;
@@ -142,18 +163,16 @@
// Focus previously focused element
if (fe && fe.id != this.id) {
- // use setTimeout() for IE9 (#1488541)
- window.setTimeout(function() {
- window.focus(); // for WebKit (#1486674)
- fe.focus();
- }, 10);
+ window.focus(); // for WebKit (#1486674)
+ fe.focus();
+ rcmail.env.compose_focus_elem = null;
}
}
// set tabIndex and set focus to element that was focused before
- this.tabindex(fe && fe.id == this.id);
+ ref.tabindex(fe && fe.id == ref.id);
// Trigger resize (needed for proper editor resizing in some browsers)
- window.setTimeout(function() { $(window).resize(); }, 100);
+ $(window).resize();
};
// set tabIndex on tinymce editor
@@ -161,20 +180,19 @@
{
if (rcmail.env.task == 'mail' && this.editor) {
var textarea = this.editor.getElement(),
+ body = this.editor.getBody(),
node = this.editor.getContentAreaContainer().childNodes[0];
if (textarea && node)
node.tabIndex = textarea.tabIndex;
- if (focus)
- this.editor.getBody().focus();
// find :prev and :next elements to get focus when tabbing away
if (textarea.tabIndex > 0) {
var x = null,
- editor = this.editor,
tabfocus_elements = [':prev',':next'],
el = tinymce.DOM.select('*[tabindex='+textarea.tabIndex+']:not(iframe)');
- tinymce.each(el, function(e, i) { if (e.id == editor.id) { x = i; return false; } });
+
+ tinymce.each(el, function(e, i) { if (e.id == ref.id) { x = i; return false; } });
if (x !== null) {
if (el[x-1] && el[x-1].id) {
tabfocus_elements[0] = el[x-1].id;
@@ -182,14 +200,21 @@
if (el[x+1] && el[x+1].id) {
tabfocus_elements[1] = el[x+1].id;
}
- editor.settings.tabfocus_elements = tabfocus_elements.join(',');
+ this.editor.settings.tabfocus_elements = tabfocus_elements.join(',');
}
}
+
+ // ContentEditable reset fixes invisible cursor issue in Firefox < 25
+ if (bw.mz && bw.vendver < 25)
+ $(body).prop('contenteditable', false).prop('contenteditable', true);
+
+ if (focus)
+ body.focus();
}
};
// switch html/plain mode
- this.toggle = function(ishtml)
+ this.toggle = function(ishtml, noconvert)
{
var curr, content, result,
// these non-printable chars are not removed on text2html and html2text
@@ -206,11 +231,12 @@
content = input.val();
// replace current text signature with temp mark
- if (is_sig)
- content = content.replace(signature.text, sig_mark);
+ if (is_sig) {
+ content = content.replace(/\r\n/, "\n");
+ content = content.replace(signature.text.replace(/\r\n/, "\n"), sig_mark);
+ }
- // convert to html
- result = rcmail.plain2html(content, function(data) {
+ var init_editor = function(data) {
// replace signature mark with html version of the signature
if (is_sig)
data = data.replace(sig_mark, '<div id="_rc_sig">' + signature.html + '</div>');
@@ -218,15 +244,23 @@
input.val(data);
tinymce.execCommand('mceAddEditor', false, ref.id);
- setTimeout(function() {
- if (ref.editor) {
- if (rcmail.env.default_font)
- $(ref.editor.getBody()).css('font-family', rcmail.env.default_font);
- // #1486593
- ref.tabindex(true);
- }
- }, 500);
- });
+ if (ref.editor) {
+ var body = $(ref.editor.getBody());
+ // #1486593
+ ref.tabindex(true);
+ // put cursor on start of the compose body
+ ref.editor.selection.setCursorLocation(body.children().first().get(0));
+ }
+ };
+
+ // convert to html
+ if (!noconvert) {
+ result = rcmail.plain2html(content, init_editor);
+ }
+ else {
+ init_editor(content);
+ result = true;
+ }
}
else if (this.editor) {
if (is_sig) {
@@ -245,8 +279,7 @@
// get html content
content = this.editor.getContent();
- // convert html to text
- result = rcmail.html2plain(content, function(data) {
+ var init_plaintext = function(data) {
tinymce.execCommand('mceRemoveEditor', false, ref.id);
ref.editor = null;
@@ -255,7 +288,17 @@
data = data.replace(sig_mark, "\n" + signature.text);
input.val(data).focus();
- });
+ rcmail.set_caret_pos(input.get(0), 0);
+ };
+
+ // convert html to text
+ if (!noconvert) {
+ result = rcmail.html2plain(content, init_plaintext);
+ }
+ else {
+ init_plaintext(input.val());
+ result = true;
+ }
// bring back current signature
if (!result && curr)
@@ -283,9 +326,10 @@
var ed = this.editor;
if (ed) {
- if (ed.plugins && ed.plugins.spellchecker && this.spellcheck_active)
- ed.execCommand('mceSpellCheck');
+ if (ed.plugins && ed.plugins.spellchecker && this.spellcheck_active) {
+ ed.execCommand('mceSpellCheck', false);
this.spellcheck_observer();
+ }
}
else if (ed = this.spellchecker) {
if (ed.state && ed.state != 'ready' && ed.state != 'no_error_found')
@@ -304,17 +348,13 @@
return ed.state != 'ready' && ed.state != 'no_error_found';
};
- // resume spellchecking, highlight provided mispellings without new ajax request
+ // resume spellchecking, highlight provided mispellings without a new ajax request
this.spellcheck_resume = function(data)
{
var ed = this.editor;
if (ed) {
- ed.settings.spellchecker_callback = function(name, text, done, error) { done(data); };
- ed.execCommand('mceSpellCheck');
- ed.settings.spellchecker_callback = null;
-
- this.spellcheck_observer();
+ ed.plugins.spellchecker.markErrors(data);
}
else if (ed = this.spellchecker) {
ed.prepare(false, true);
@@ -373,29 +413,33 @@
};
// get selected text (if no selection returns all text) from the editor
- this.get_content = function(selected, plain)
+ this.get_content = function(args)
{
- // apply spellcheck changes if spell checker is active
- this.spellcheck_stop();
+ var sigstart, ed = this.editor, text = '', strip = false,
+ defaults = {refresh: true, selection: false, nosig: false, format: 'html'};
- var sigstart, ed = this.editor,
- format = plain ? 'text' : 'html',
- text = '', strip = false;
+ args = $.extend(defaults, args);
+
+ // apply spellcheck changes if spell checker is active
+ if (args.refresh) {
+ this.spellcheck_stop();
+ }
// get selected text from tinymce editor
if (ed) {
ed.getWin().focus(); // correct focus in IE & Chrome
- if (selected)
- text = ed.selection.getContent({format: format});
+ if (args.selection)
+ text = ed.selection.getContent({format: args.format});
if (!text) {
- text = ed.getContent({format: format});
- strip = true;
+ text = ed.getContent({format: args.format});
+ // @todo: strip signature in html mode
+ strip = args.format == 'text';
}
}
// get selected text from compose textarea
else if (ed = rcube_find_object(this.id)) {
- if (selected && $(ed).is(':focus')) {
+ if (args.selection && $(ed).is(':focus')) {
text = rcmail.get_input_selection(ed).text;
}
@@ -406,7 +450,8 @@
}
// strip off signature
- if (strip) {
+ // @todo: make this optional
+ if (strip && args.nosig) {
sigstart = text.indexOf('-- \n');
if (sigstart > 0) {
text = text.substring(0, sigstart);
@@ -419,7 +464,7 @@
// change user signature text
this.change_signature = function(id, show_sig)
{
- var cursor_pos, p = -1,
+ var position_element, cursor_pos, p = -1,
input_message = $('#' + this.id),
message = input_message.val(),
sig = rcmail.env.identity;
@@ -434,6 +479,7 @@
if (p >= 0)
message = message.substring(0, p) + message.substring(p+sig.length, message.length);
}
+
// add the new signature string
if (show_sig && rcmail.env.signatures && rcmail.env.signatures[id]) {
sig = rcmail.env.signatures[id].text;
@@ -499,12 +545,22 @@
}
else {
body.appendChild(sigElem);
+ position_element = $(sigElem).prev();
}
}
if (rcmail.env.signatures[id]) {
sigElem.innerHTML = rcmail.env.signatures[id].html;
}
+ }
+ else if (!rcmail.env.top_posting) {
+ position_element = $(this.editor.getBody()).children().last();
+ }
+
+ // put cursor before signature and scroll the window
+ if (this.editor && position_element && position_element.length) {
+ this.editor.selection.setCursorLocation(position_element.get(0));
+ this.editor.getWin().scroll(0, position_element.offset().top);
}
};
@@ -589,8 +645,14 @@
this.hack_file_input(elem, rcmail.gui_objects.uploadform);
// enable drag-n-drop area
- if (rcmail.gui_objects.filedrop && rcmail.env.filedrop && ((window.XMLHttpRequest && XMLHttpRequest.prototype && XMLHttpRequest.prototype.sendAsBinary) || window.FormData)) {
- rcmail.env.old_file_drop = rcmail.gui_objects.filedrop;
+ if ((window.XMLHttpRequest && XMLHttpRequest.prototype && XMLHttpRequest.prototype.sendAsBinary) || window.FormData) {
+ if (!rcmail.env.filedrop) {
+ rcmail.env.filedrop = {};
+ }
+ if (rcmail.gui_objects.filedrop) {
+ rcmail.env.old_file_drop = rcmail.gui_objects.filedrop;
+ }
+
rcmail.gui_objects.filedrop = $('#image-selector-form');
rcmail.gui_objects.filedrop.addClass('droptarget')
.bind('dragover dragleave', function(e) {
@@ -637,6 +699,10 @@
{
if (!file.complete || !file.mimetype) {
return;
+ }
+
+ if (rcmail.file_upload_id) {
+ rcmail.set_busy(false, null, rcmail.file_upload_id);
}
var rx, img_src;
@@ -692,7 +758,7 @@
this.hack_file_input = function(elem, clone_form)
{
var link = $(elem),
- file = $('<input>').attr('name', '_files[]'),
+ file = $('<input>').attr('name', '_file[]'),
form = $('<form>').attr({method: 'post', enctype: 'multipart/form-data'}),
offset = link.offset();
--
Gitblit v1.9.1