From 8abe5485fd797ee17a6da13ebec7b6d7a3411b92 Mon Sep 17 00:00:00 2001 From: alecpl <alec@alec.pl> Date: Wed, 09 Dec 2009 04:30:37 -0500 Subject: [PATCH] - move compose_message_body hook to better place (#1486353) --- program/steps/mail/compose.inc | 65 ++++++++++++++++++++++---------- 1 files changed, 44 insertions(+), 21 deletions(-) diff --git a/program/steps/mail/compose.inc b/program/steps/mail/compose.inc index c894da7..842f28c 100644 --- a/program/steps/mail/compose.inc +++ b/program/steps/mail/compose.inc @@ -55,8 +55,8 @@ // pipe compose parameters thru plugins $plugin = $RCMAIL->plugins->exec_hook('message_compose', $_SESSION['compose']); - $_SESSION['compose']['param'] = $plugin['param']; - + $_SESSION['compose']['param'] = array_merge($_SESSION['compose']['param'], $plugin['param']); + // add attachments listed by message_compose hook if (is_array($plugin['attachments'])) { foreach ($plugin['attachments'] as $attach) { @@ -103,6 +103,8 @@ } // set current mailbox in client environment $OUTPUT->set_env('mailbox', $IMAP->get_mailbox_name()); +$OUTPUT->set_env('sig_above', $CONFIG['sig_above']); +$OUTPUT->set_env('top_posting', $CONFIG['top_posting']); // get reference message and set compose mode if ($msg_uid = $_SESSION['compose']['param']['reply_uid']) @@ -115,6 +117,16 @@ $RCMAIL->imap->set_mailbox($CONFIG['drafts_mbox']); $compose_mode = RCUBE_COMPOSE_DRAFT; } + +$config_show_sig = $RCMAIL->config->get('show_sig', 1); +if ($config_show_sig == 1) + $OUTPUT->set_env('show_sig', true); +else if ($config_show_sig == 2 && (empty($compose_mode) || $compose_mode == RCUBE_COMPOSE_EDIT || $compose_mode == RCUBE_COMPOSE_DRAFT)) + $OUTPUT->set_env('show_sig', true); +else if ($config_show_sig == 3 && ($compose_mode == RCUBE_COMPOSE_REPLY || $compose_mode == RCUBE_COMPOSE_FORWARD)) + $OUTPUT->set_env('show_sig', true); +else + $OUTPUT->set_env('show_sig', false); if (!empty($msg_uid)) { @@ -433,10 +445,10 @@ else if ($compose_mode == RCUBE_COMPOSE_DRAFT || $compose_mode == RCUBE_COMPOSE_EDIT) $body = rcmail_create_draft_body($body, $isHtml); } - else if (!empty($_SESSION['compose']['param']['body'])) - { - $body = $_SESSION['compose']['param']['body']; - } + + $plugin = $RCMAIL->plugins->exec_hook('message_compose_body', + array('body' => $body, 'html' => $isHtml, 'mode' => $compose_mode)); + $body = $plugin['body']; $out = $form_start ? "$form_start\n" : ''; @@ -493,7 +505,7 @@ JQ(Q(rcube_label('close'))), JQ(Q(rcube_label('revertto'))), JQ(Q(rcube_label('nospellerrors'))), - json_serialize($spellcheck_langs), + json_encode($spellcheck_langs), $lang, $attrib['id'], JS_OBJECT_NAME), 'foot'); @@ -510,16 +522,14 @@ function rcmail_create_reply_body($body, $bodyIsHtml) { - global $IMAP, $MESSAGE, $OUTPUT; + global $RCMAIL, $MESSAGE; - if (! $bodyIsHtml) - { + if (!$bodyIsHtml) { // try to remove the signature - if (($sp = strrpos($body, '-- ')) !== false && ($sp == 0 || $body{$sp-1} == "\n")) - { + if ($RCMAIL->config->get('strip_existing_sig', true) && ($sp = strrpos($body, '-- ')) !== false && ($sp == 0 || $body{$sp-1} == "\n")) { if ($body{$sp+3}==' ' || $body{$sp+3}=="\n" || $body{$sp+3}=="\r") $body = substr($body, 0, max(0, $sp-1)); - } + } // soft-wrap message first $body = rcmail_wrap_quoted($body, 75); @@ -531,15 +541,15 @@ $a_lines = preg_split('/\r?\n/', $body); // add > to each line - for($n=0; $n<sizeof($a_lines); $n++) { + for ($n=0; $n<sizeof($a_lines); $n++) { if (strpos($a_lines[$n], '>')===0) $a_lines[$n] = '>'.$a_lines[$n]; else $a_lines[$n] = '> '.$a_lines[$n]; - } + } $body = join("\n", $a_lines); - } + } // add title line(s) $prefix = rc_wordwrap(sprintf("On %s, %s wrote:\n", @@ -547,9 +557,11 @@ $MESSAGE->get_header('from')), 76); $suffix = ''; + + if ($RCMAIL->config->get('top_posting')) + $prefix = "\n\n\n" . $prefix; } - else - { + else { // save inline images to files $cid_map = rcmail_write_inline_attachments($MESSAGE); // set is_safe flag (we need this for html body washing) @@ -560,9 +572,16 @@ // build reply (quote content) $prefix = sprintf("On %s, %s wrote:<br />\n", $MESSAGE->headers->date, - htmlspecialchars(Q($MESSAGE->get_header('from'), 'replace'), ENT_COMPAT, $OUTPUT->get_charset())); + htmlspecialchars(Q($MESSAGE->get_header('from'), 'replace'), ENT_COMPAT, $RCMAIL->output->get_charset())); $prefix .= '<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px; width:100%">'; - $suffix = "</blockquote><p></p>"; + + if ($RCMAIL->config->get('top_posting')) { + $prefix = "<p></p>" . $prefix; + $suffix = "</blockquote>"; + } + else { + $suffix = "</blockquote><p></p>"; + } } return $prefix.$body.$suffix; @@ -781,6 +800,7 @@ $attrib['id'] = 'rcmAttachmentList'; $out = "\n"; + $jslist = array(); if (is_array($_SESSION['compose']['attachments'])) { @@ -798,12 +818,14 @@ if (empty($a_prop)) continue; - $out .= html::tag('li', array('id' => "rcmfile".$id), + $out .= html::tag('li', array('id' => 'rcmfile'.$id), html::a(array( 'href' => "#delete", 'title' => rcube_label('delete'), 'onclick' => sprintf("return %s.command('remove-attachment','rcmfile%s', this)", JS_OBJECT_NAME, $id)), $button) . Q($a_prop['name'])); + + $jslist['rcmfile'.$id] = array('name' => $a_prop['name'], 'complete' => true, 'mimetype' => $a_prop['mimetype']); } } @@ -814,6 +836,7 @@ if ($attrib['loadingicon']) $OUTPUT->set_env('loadingicon', $CONFIG['skin_path'] . $attrib['loadingicon']); + $OUTPUT->set_env('attachments', $jslist); $OUTPUT->add_gui_object('attachmentlist', $attrib['id']); return html::tag('ul', $attrib, $out, html::$common_attrib); -- Gitblit v1.9.1