From 8447bae77c19a2350bd48b0f0c5b3a56a35c7af9 Mon Sep 17 00:00:00 2001 From: Aleksander Machniak <alec@alec.pl> Date: Sun, 28 Jun 2015 06:27:48 -0400 Subject: [PATCH] Require Mbstring and OpenSSL extensions (#1490415) - remove redundant code --- program/lib/Roundcube/rcube_mime.php | 65 +++++++------------------------- 1 files changed, 14 insertions(+), 51 deletions(-) diff --git a/program/lib/Roundcube/rcube_mime.php b/program/lib/Roundcube/rcube_mime.php index e9cab61..3e26e86 100644 --- a/program/lib/Roundcube/rcube_mime.php +++ b/program/lib/Roundcube/rcube_mime.php @@ -1,6 +1,6 @@ <?php -/* +/** +-----------------------------------------------------------------------+ | This file is part of the Roundcube Webmail client | | Copyright (C) 2005-2014, The Roundcube Dev Team | @@ -61,61 +61,24 @@ * Parse the given raw message source and return a structure * of rcube_message_part objects. * - * It makes use of the PEAR:Mail_mimeDecode library + * It makes use of the rcube_mime_decode library * - * @param string The message source + * @param string $raw_body The message source + * * @return object rcube_message_part The message structure */ public static function parse_message($raw_body) { - $mime = new Mail_mimeDecode($raw_body); - $struct = $mime->decode(array('include_bodies' => true, 'decode_bodies' => true)); - return self::structure_part($struct); - } + $conf = array( + 'include_bodies' => true, + 'decode_bodies' => true, + 'decode_headers' => false, + 'default_charset' => self::get_charset(), + ); - /** - * Recursive method to convert a Mail_mimeDecode part into a rcube_message_part object - * - * @param object A message part struct - * @param int Part count - * @param string Parent MIME ID - * - * @return object rcube_message_part - */ - private static function structure_part($part, $count=0, $parent='') - { - $struct = new rcube_message_part; - $struct->mime_id = $part->mime_id ?: (empty($parent) ? (string)$count : "$parent.$count"); - $struct->headers = $part->headers; - $struct->mimetype = $part->ctype_primary . '/' . $part->ctype_secondary; - $struct->ctype_primary = $part->ctype_primary; - $struct->ctype_secondary = $part->ctype_secondary; - $struct->ctype_parameters = $part->ctype_parameters; + $mime = new rcube_mime_decode($conf); - if ($part->headers['content-transfer-encoding']) { - $struct->encoding = $part->headers['content-transfer-encoding']; - } - - if ($part->ctype_parameters['charset']) { - $struct->charset = $part->ctype_parameters['charset']; - } - - $part_charset = $struct->charset ?: self::get_charset(); - - // determine filename - if (($filename = $part->d_parameters['filename']) || ($filename = $part->ctype_parameters['name'])) { - $struct->filename = rcube_mime::decode_mime_string($filename, $part_charset); - } - - $struct->body = $part->body; - $struct->size = strlen($part->body); - $struct->disposition = $part->disposition; - - foreach ((array)$part->parts as $child_part) { - $struct->parts[] = self::structure_part($child_part, ++$count, $struct->mime_id); - } - - return $struct; + return $mime->decode($raw_body); } /** @@ -604,7 +567,7 @@ // Note: Never try to use iconv instead of mbstring functions here // Iconv's substr/strlen are 100x slower (#1489113) - if ($charset && $charset != RCUBE_CHARSET && function_exists('mb_internal_encoding')) { + if ($charset && $charset != RCUBE_CHARSET) { mb_internal_encoding($charset); } @@ -698,7 +661,7 @@ } } - if ($charset && $charset != RCUBE_CHARSET && function_exists('mb_internal_encoding')) { + if ($charset && $charset != RCUBE_CHARSET) { mb_internal_encoding(RCUBE_CHARSET); } -- Gitblit v1.9.1