From 78925f8f1a9afb9475a9cf9ad1b35daade23da85 Mon Sep 17 00:00:00 2001 From: alecpl <alec@alec.pl> Date: Thu, 17 Sep 2009 08:07:58 -0400 Subject: [PATCH] - Fix incorrect count of new messages in folder list when using multiple IMAP clients (#1485995) - Fix all folders checking for new messages with disabled caching (#1486128) --- program/steps/mail/list.inc | 87 ++++++++++++++++++++++++++++--------------- 1 files changed, 56 insertions(+), 31 deletions(-) diff --git a/program/steps/mail/list.inc b/program/steps/mail/list.inc index cb1d7a6..a40fce6 100644 --- a/program/steps/mail/list.inc +++ b/program/steps/mail/list.inc @@ -5,7 +5,7 @@ | program/steps/mail/list.inc | | | | This file is part of the RoundCube Webmail client | - | Copyright (C) 2005, RoundCube Dev. - Switzerland | + | Copyright (C) 2005-2007, RoundCube Dev. - Switzerland | | Licensed under the GNU GPL | | | | PURPOSE: | @@ -19,51 +19,76 @@ */ -$REMOTE_REQUEST = TRUE; -$OUTPUT_TYPE = 'js'; - -$unseen = $IMAP->messagecount($mbox, 'UNSEEN', !empty($_GET['_refresh']) ? TRUE : FALSE); -$count = $IMAP->messagecount(); +if (!$OUTPUT->ajax_call) { + return; +} // is there a sort type for this request? -if ($sort = isset($_GET['_sort']) ? $_GET['_sort'] : false) - { +if ($sort = get_input_value('_sort', RCUBE_INPUT_GET)) +{ // yes, so set the sort vars list($sort_col, $sort_order) = explode('_', $sort); // set session vars for sort (so next page and task switch know how to sort) - $_SESSION['sort_col'] = $sort_col; - $_SESSION['sort_order'] = $sort_order; - } + $save_arr = array(); + $_SESSION['sort_col'] = $save_arr['message_sort_col'] = $sort_col; + $_SESSION['sort_order'] = $save_arr['message_sort_order'] = $sort_order; + + $RCMAIL->user->save_prefs($save_arr); +} else - { +{ // use session settings if set, defaults if not $sort_col = isset($_SESSION['sort_col']) ? $_SESSION['sort_col'] : $CONFIG['message_sort_col']; $sort_order = isset($_SESSION['sort_order']) ? $_SESSION['sort_order'] : $CONFIG['message_sort_order']; - } - +} + +$mbox_name = $IMAP->get_mailbox_name(); + +// initialize searching result if search_filter is used +if ($_SESSION['search_filter'] && $_SESSION['search_filter'] != 'ALL') +{ + $search_request = md5($mbox_name.$_SESSION['search_filter']); + + $IMAP->search($mbox_name, $_SESSION['search_filter'], RCMAIL_CHARSET, $sort_col); + $_SESSION['search'][$search_request] = $IMAP->get_search_set(); + $OUTPUT->set_env('search_request', $search_request); +} + + +// fetch message headers +if ($count = $IMAP->messagecount($mbox_name, 'ALL', !empty($_REQUEST['_refresh']))) + $a_headers = $IMAP->list_headers($mbox_name, NULL, $sort_col, $sort_order); + +// count UNSEEN messages... +$old_unseen = $_SESSION['unseen_count'][$mbox_name]; +$unseen = $count ? $IMAP->messagecount($mbox_name, 'UNSEEN', !empty($_REQUEST['_refresh'])) : 0; +$_SESSION['unseen_count'][$mbox_name] = $unseen; + +// ...and update mailboxlist +if ($unseen != $old_unseen) + $OUTPUT->command('set_unread_count', $mbox_name, $unseen, ($mbox_name == 'INBOX')); // update message count display $pages = ceil($count/$IMAP->page_size); -$commands = sprintf("this.set_env('messagecount', %d);\n", $count); -$commands .= sprintf("this.set_env('pagecount', %d);\n", $pages); -$commands .= sprintf("this.set_rowcount('%s');\n", rcmail_get_messagecount_text()); - -// update mailboxlist -$mbox = $IMAP->get_mailbox_name(); -$commands .= sprintf("this.set_unread_count('%s', %d);\n", addslashes($mbox), $unseen); - +$OUTPUT->set_env('messagecount', $count); +$OUTPUT->set_env('pagecount', $pages); +$OUTPUT->command('set_rowcount', rcmail_get_messagecount_text($count)); +$OUTPUT->command('set_mailboxname', rcmail_get_mailbox_name_text()); // add message rows -if ($count) - { - $a_headers = $IMAP->list_headers($mbox, null, $sort_col, $sort_order); - $commands .= rcmail_js_message_list($a_headers); - } +if (isset($a_headers) && count($a_headers)) +{ + rcmail_js_message_list($a_headers); + if ($search_request) + $OUTPUT->show_message('searchsuccessful', 'confirmation', array('nr' => $count)); +} +else if ($search_request) + $OUTPUT->show_message('searchnomatch', 'notice'); +else + $OUTPUT->show_message('nomessagesfound', 'notice'); - // send response -rcube_remote_response($commands); +$OUTPUT->send(); -exit; -?> \ No newline at end of file +?> -- Gitblit v1.9.1