From 78925f8f1a9afb9475a9cf9ad1b35daade23da85 Mon Sep 17 00:00:00 2001 From: alecpl <alec@alec.pl> Date: Thu, 17 Sep 2009 08:07:58 -0400 Subject: [PATCH] - Fix incorrect count of new messages in folder list when using multiple IMAP clients (#1485995) - Fix all folders checking for new messages with disabled caching (#1486128) --- program/steps/mail/list.inc | 46 +++++++++++++++++++++++++++++++++++----------- 1 files changed, 35 insertions(+), 11 deletions(-) diff --git a/program/steps/mail/list.inc b/program/steps/mail/list.inc index e09919c..a40fce6 100644 --- a/program/steps/mail/list.inc +++ b/program/steps/mail/list.inc @@ -19,7 +19,10 @@ */ -$OUTPUT_TYPE = 'js'; +if (!$OUTPUT->ajax_call) { + return; +} + // is there a sort type for this request? if ($sort = get_input_value('_sort', RCUBE_INPUT_GET)) { @@ -27,8 +30,11 @@ list($sort_col, $sort_order) = explode('_', $sort); // set session vars for sort (so next page and task switch know how to sort) - $_SESSION['sort_col'] = $sort_col; - $_SESSION['sort_order'] = $sort_order; + $save_arr = array(); + $_SESSION['sort_col'] = $save_arr['message_sort_col'] = $sort_col; + $_SESSION['sort_order'] = $save_arr['message_sort_order'] = $sort_order; + + $RCMAIL->user->save_prefs($save_arr); } else { @@ -39,12 +45,29 @@ $mbox_name = $IMAP->get_mailbox_name(); +// initialize searching result if search_filter is used +if ($_SESSION['search_filter'] && $_SESSION['search_filter'] != 'ALL') +{ + $search_request = md5($mbox_name.$_SESSION['search_filter']); + + $IMAP->search($mbox_name, $_SESSION['search_filter'], RCMAIL_CHARSET, $sort_col); + $_SESSION['search'][$search_request] = $IMAP->get_search_set(); + $OUTPUT->set_env('search_request', $search_request); +} + + // fetch message headers -if ($IMAP->messagecount($mbox_name, 'ALL', !empty($_REQUEST['_refresh']))) +if ($count = $IMAP->messagecount($mbox_name, 'ALL', !empty($_REQUEST['_refresh']))) $a_headers = $IMAP->list_headers($mbox_name, NULL, $sort_col, $sort_order); -$count = $IMAP->messagecount($mbox_name); -$unseen = $IMAP->messagecount($mbox_name, 'UNSEEN', !empty($_REQUEST['_refresh'])); +// count UNSEEN messages... +$old_unseen = $_SESSION['unseen_count'][$mbox_name]; +$unseen = $count ? $IMAP->messagecount($mbox_name, 'UNSEEN', !empty($_REQUEST['_refresh'])) : 0; +$_SESSION['unseen_count'][$mbox_name] = $unseen; + +// ...and update mailboxlist +if ($unseen != $old_unseen) + $OUTPUT->command('set_unread_count', $mbox_name, $unseen, ($mbox_name == 'INBOX')); // update message count display $pages = ceil($count/$IMAP->page_size); @@ -53,16 +76,17 @@ $OUTPUT->command('set_rowcount', rcmail_get_messagecount_text($count)); $OUTPUT->command('set_mailboxname', rcmail_get_mailbox_name_text()); - - // add message rows if (isset($a_headers) && count($a_headers)) +{ rcmail_js_message_list($a_headers); + if ($search_request) + $OUTPUT->show_message('searchsuccessful', 'confirmation', array('nr' => $count)); +} +else if ($search_request) + $OUTPUT->show_message('searchnomatch', 'notice'); else $OUTPUT->show_message('nomessagesfound', 'notice'); - -// update mailboxlist -$OUTPUT->command('set_unread_count', $mbox_name, $unseen, ($mbox_name == 'INBOX')); // send response $OUTPUT->send(); -- Gitblit v1.9.1