From 73967c716980699b31b07032e553132986df0134 Mon Sep 17 00:00:00 2001
From: thomascube <thomas@roundcube.net>
Date: Wed, 01 Jul 2009 12:07:26 -0400
Subject: [PATCH] Also save signature field when creating a new identity at login
---
program/include/rcube_user.php | 96 ++++++++++++++++++++++++++++++------------------
1 files changed, 60 insertions(+), 36 deletions(-)
diff --git a/program/include/rcube_user.php b/program/include/rcube_user.php
index da819c7..8c77a03 100644
--- a/program/include/rcube_user.php
+++ b/program/include/rcube_user.php
@@ -135,12 +135,12 @@
* Get default identity of this user
*
* @param int Identity ID. If empty, the default identity is returned
- * @return array Hash array with all cols of the
+ * @return array Hash array with all cols of the identity record
*/
function get_identity($id = null)
{
- $sql_result = $this->list_identities($id ? sprintf('AND identity_id=%d', $id) : '');
- return $this->db->fetch_assoc($sql_result);
+ $result = $this->list_identities($id ? sprintf('AND identity_id=%d', $id) : '');
+ return $result[0];
}
@@ -160,7 +160,12 @@
ORDER BY ".$this->db->quoteIdentifier('standard')." DESC, name ASC, identity_id ASC",
$this->ID);
- return $sql_result;
+ $result = array();
+ while ($sql_arr = $this->db->fetch_assoc($sql_result)) {
+ $result[] = $sql_arr;
+ }
+
+ return $result;
}
@@ -176,23 +181,24 @@
if (!$this->ID)
return false;
- $write_sql = array();
+ $query_cols = $query_params = array();
foreach ((array)$data as $col => $value)
{
- $write_sql[] = sprintf("%s=%s",
- $this->db->quoteIdentifier($col),
- $this->db->quote($value));
+ $query_cols[] = $this->db->quoteIdentifier($col) . '=?';
+ $query_params[] = $value;
}
-
- $this->db->query(
- "UPDATE ".get_table_name('identities')."
- SET ".join(', ', $write_sql)."
+ $query_params[] = $iid;
+ $query_params[] = $this->ID;
+
+ $sql = "UPDATE ".get_table_name('identities')."
+ SET ".join(', ', $query_cols)."
WHERE identity_id=?
AND user_id=?
- AND del<>1",
- $iid,
- $this->ID);
+ AND del<>1";
+
+ call_user_func_array(array($this->db, 'query'),
+ array_merge(array($sql), $query_params));
return $this->db->affected_rows();
}
@@ -213,14 +219,17 @@
foreach ((array)$data as $col => $value)
{
$insert_cols[] = $this->db->quoteIdentifier($col);
- $insert_values[] = $this->db->quote($value);
+ $insert_values[] = $value;
}
+ $insert_cols[] = 'user_id';
+ $insert_values[] = $this->ID;
- $this->db->query(
- "INSERT INTO ".get_table_name('identities')."
- (user_id, ".join(', ', $insert_cols).")
- VALUES (?, ".join(', ', $insert_values).")",
- $this->ID);
+ $sql = "INSERT INTO ".get_table_name('identities')."
+ (".join(', ', $insert_cols).")
+ VALUES (".join(', ', array_pad(array(), sizeof($insert_values), '?')).")";
+
+ call_user_func_array(array($this->db, 'query'),
+ array_merge(array($sql), $insert_values));
return $this->db->insert_id(get_sequence_name('identities'));
}
@@ -362,8 +371,8 @@
// try to resolve user in virtuser table and file
if ($user_email != '' && !strpos($user, '@')) {
- if ($email_list = self::user2email($user, false))
- $user_email = $email_list[0];
+ if ($email_list = self::user2email($user, false, true))
+ $user_email = is_array($email_list[0]) ? $email_list[0][0] : $email_list[0];
}
$dbh->query(
@@ -395,23 +404,37 @@
// create new identities records
$standard = 1;
- foreach ($email_list as $email) {
- $plugin = $RCMAIL->plugins->exec_hook('create_identity', array('record' => array(
+ foreach ($email_list as $row) {
+ if (is_array($row)) {
+ $email = $row[0];
+ $name = $row[1] ? $row[1] : $user_name;
+ }
+ else {
+ $email = $row;
+ $name = $user_name;
+ }
+
+ $plugin = $rcmail->plugins->exec_hook('create_identity', array(
'login' => true,
- 'user_id' => $user_id,
- 'name' => strip_newlines($user_name),
- 'email' => $email,
- 'standard' => $standard)));
+ 'record' => array(
+ 'user_id' => $user_id,
+ 'name' => strip_newlines($name),
+ 'email' => $email,
+ 'standard' => $standard,
+ 'signature' => '',
+ ),
+ ));
- if (!$plugin['abort'] && $plugin['record']['name'] && $plugin['record']['email']) {
+ if (!$plugin['abort'] && $plugin['record']['email']) {
$dbh->query(
"INSERT INTO ".get_table_name('identities')."
- (user_id, del, standard, name, email)
- VALUES (?, 0, ?, ?, ?)",
+ (user_id, del, standard, name, email, signature)
+ VALUES (?, 0, ?, ?, ?, ?)",
$user_id,
$plugin['record']['standard'],
- $plugin['record']['name'],
- $plugin['record']['email']);
+ $plugin['record']['name'] != NULL ? $plugin['record']['name'] : '',
+ $plugin['record']['email'],
+ $plugin['record']['signature']);
}
$standard = 0;
}
@@ -457,9 +480,10 @@
*
* @param string User name
* @param boolean If true returns first found entry
+ * @param boolean If true returns email as array (email and name for identity)
* @return mixed Resolved e-mail address string or array of strings
*/
- static function user2email($user, $first=true)
+ static function user2email($user, $first=true, $extended=false)
{
$result = array();
$rcmail = rcmail::get_instance();
@@ -470,7 +494,7 @@
$sql_result = $dbh->query(preg_replace('/%u/', $dbh->escapeSimple($user), $virtuser_query));
while ($sql_arr = $dbh->fetch_array($sql_result))
if (strpos($sql_arr[0], '@')) {
- $result[] = $sql_arr[0];
+ $result[] = ($extended && count($sql_arr) > 1) ? $sql_arr : $sql_arr[0];
if ($first)
return $result[0];
}
--
Gitblit v1.9.1