From 677e1f26fe47cc0c3e0819cb99a9024af49a619c Mon Sep 17 00:00:00 2001
From: alecpl <alec@alec.pl>
Date: Tue, 18 May 2010 06:25:29 -0400
Subject: [PATCH] - Some files from /bin + spellchecking actions moved to the new 'utils' task

---
 program/js/app.js |  419 +++++++++++++++++++++++++++++++++++++++--------------------
 1 files changed, 279 insertions(+), 140 deletions(-)

diff --git a/program/js/app.js b/program/js/app.js
index 4e7db32..dfd7c9f 100644
--- a/program/js/app.js
+++ b/program/js/app.js
@@ -50,7 +50,6 @@
   this.env.request_timeout = 180;  // seconds
   this.env.draft_autosave = 0;     // seconds
   this.env.comm_path = './';
-  this.env.bin_path = './bin/';
   this.env.blankpage = 'program/blank.gif';
 
   // set jQuery ajax options
@@ -87,7 +86,7 @@
     if (sel) button_prop.sel = sel;
     if (over) button_prop.over = over;
 
-    this.buttons[command][this.buttons[command].length] = button_prop;
+    this.buttons[command].push(button_prop);
   };
 
   // register a specific gui object
@@ -121,7 +120,7 @@
   // execute the given script on load
   this.add_onload = function(f)
   {
-    this.onloads[this.onloads.length] = f;
+    this.onloads.push(f);
   };
 
   // initialize webmail client
@@ -389,7 +388,7 @@
 
     // execute all foreign onload scripts
     // @deprecated
-    for (var i=0; i<this.onloads.length; i++) {
+    for (var i in this.onloads) {
       if (typeof(this.onloads[i]) == 'string')
         eval(this.onloads[i]);
       else if (typeof(this.onloads[i]) == 'function')
@@ -508,7 +507,7 @@
 
 
       case 'listgroup':
-        this.list_contacts(null, props);
+        this.list_contacts(props.source, props.id);
         break;
 
 
@@ -734,6 +733,7 @@
         break;
 
       case 'select-none':
+        this.select_all_mode = false;
         this.message_list.clear_selection();
         break;
 
@@ -803,12 +803,12 @@
           // use contact_id passed as command parameter
           var a_cids = [];
           if (props)
-            a_cids[a_cids.length] = props;
+            a_cids.push(props);
           // get selected contacts
           else if (this.contact_list) {
             var selection = this.contact_list.get_selection();
             for (var n=0; n<selection.length; n++)
-              a_cids[a_cids.length] = selection[n];
+              a_cids.push(selection[n]);
           }
 
           if (a_cids.length)
@@ -1052,13 +1052,13 @@
   // set command enabled or disabled
   this.enable_command = function()
   {
-    var args = arguments;
-    if (!args.length)
+    var args = arguments, len = args.length;
+    if (!len)
       return -1;
 
-    var command, enable = args[args.length-1];
+    var command, enable = args[len-1];
 
-    for (var n=0; n<args.length-1; n++) {
+    for (var n=0, len=len-1; n<len; n++) {
       command = args[n];
       this.commands[command] = enable;
       this.set_button(command, (enable ? 'act' : 'pas'));
@@ -1071,7 +1071,7 @@
   {
     if (a && message) {
       var msg = this.get_label(message);
-      if (msg==message)        
+      if (msg == message)        
         msg = 'Loading...';
 
       this.display_message(msg, 'loading', true);
@@ -1258,31 +1258,33 @@
       // over the folders
       for (var k in this.env.folder_coords) {
         pos = this.env.folder_coords[k];
-        if (mouse.x >= pos.x1 && mouse.x < pos.x2 && mouse.y >= pos.y1 && mouse.y < pos.y2
-            && this.check_droptarget(k)) {
+        if (mouse.x >= pos.x1 && mouse.x < pos.x2 && mouse.y >= pos.y1 && mouse.y < pos.y2){
+         if (this.check_droptarget(k)) {
+            li = this.get_folder_li(k);
+            div = $(li.getElementsByTagName('div')[0]);
 
-          li = this.get_folder_li(k);
-          div = $(li.getElementsByTagName('div')[0]);
+            // if the folder is collapsed, expand it after 1sec and restart the drag & drop process.
+            if (div.hasClass('collapsed')) {
+              if (this.folder_auto_timer)
+                window.clearTimeout(this.folder_auto_timer);
 
-          // if the folder is collapsed, expand it after 1sec and restart the drag & drop process.
-          if (div.hasClass('collapsed')) {
-            if (this.folder_auto_timer)
+              this.folder_auto_expand = k;
+              this.folder_auto_timer = window.setTimeout(function() {
+                  rcmail.command('collapse-folder', rcmail.folder_auto_expand);
+                  rcmail.drag_start(null);
+                }, 1000);
+            } else if (this.folder_auto_timer) {
               window.clearTimeout(this.folder_auto_timer);
+              this.folder_auto_timer = null;
+              this.folder_auto_expand = null;
+            }
 
-            this.folder_auto_expand = k;
-            this.folder_auto_timer = window.setTimeout(function() {
-                rcmail.command('collapse-folder', rcmail.folder_auto_expand);
-                rcmail.drag_start(null);
-              }, 1000);
-          } else if (this.folder_auto_timer) {
-            window.clearTimeout(this.folder_auto_timer);
-            this.folder_auto_timer = null;
-            this.folder_auto_expand = null;
+            $(li).addClass('droptarget');
+            this.env.folder_coords[k].on = 1;
+            this.env.last_folder_target = k;
+          } else { // Clear target, otherwise drag end will trigger move into last valid droptarget
+            this.env.last_folder_target = null;
           }
-
-          $(li).addClass('droptarget');
-          this.env.last_folder_target = k;
-          this.env.folder_coords[k].on = 1;
         }
         else if (pos.on) {
           $(this.get_folder_li(k)).removeClass('droptarget');
@@ -1404,7 +1406,7 @@
     this.enable_command('delete', 'moveto', 'copy', 'mark', (list.selection.length > 0 ? true : false));
 
     // reset all-pages-selection
-    if (selected || list.selection.length != list.rowcount)
+    if (selected || (list.selection.length && list.selection.length != list.rowcount))
       this.select_all_mode = false;
 
     // start timer for message preview (wait for double click)
@@ -1486,7 +1488,7 @@
     for (i=0; i<cols.length; i++)
       if (cols[i].id && cols[i].id.match(/^rcm/)) {
         name = cols[i].id.replace(/^rcm/, '');
-        this.env.coltypes[this.env.coltypes.length] = name == 'to' ? 'from' : name;
+        this.env.coltypes.push(name == 'to' ? 'from' : name);
       }
 
     if ((found = $.inArray('flag', this.env.coltypes)) >= 0)
@@ -1502,6 +1504,8 @@
     else if (this.task == 'addressbook')
       return (id != this.env.source && this.env.contactfolders[id] && !this.env.contactfolders[id].readonly &&
         !(!this.env.source && this.env.contactfolders[id].group) &&
+        !(this.env.contactfolders[id].type == 'group' && this.env.contactfolders[this.env.source].readonly) &&
+        !(this.env.contactfolders[id].type == 'group' && this.env.contactfolders[id].source != this.env.source) &&
         !(this.env.contactfolders[id].type == 'group' && this.env.contactfolders[id].id == this.env.group));
     else if (this.task == 'settings')
       return (id != this.env.folder);
@@ -1532,6 +1536,7 @@
     }
 
     if (!row.depth && row.has_children && (expando = document.getElementById('rcmexpando'+row.uid))) {
+      row.expando = expando;
       expando.onmousedown = function(e) { return self.expand_message_row(e, uid); };
     }
 
@@ -1543,11 +1548,6 @@
   {
     if (!this.gui_objects.messagelist || !this.message_list)
       return false;
-
-    if (this.message_list.background)
-      var tbody = this.message_list.background;
-    else
-      var tbody = this.gui_objects.messagelist.tBodies[0];
 
     if (!this.env.messages[uid])
       this.env.messages[uid] = {};
@@ -1561,12 +1561,15 @@
       flagged: flags.flagged?1:0,
       has_children: flags.has_children?1:0,
       depth: flags.depth?flags.depth:0,
-      unread_children: flags.unread_children,
-      parent_uid: flags.parent_uid
+      unread_children: flags.unread_children?flags.unread_children:0,
+      parent_uid: flags.parent_uid?flags.parent_uid:0,
+      selected: this.select_all_mode || this.message_list.in_selection(uid)
     });
 
     var c, tree = expando = '',
-      rows = this.message_list.rows,
+      list = this.message_list,
+      rows = list.rows,
+      tbody = this.gui_objects.messagelist.tBodies[0],
       rowcount = tbody.rows.length,
       even = rowcount%2,
       message = this.env.messages[uid],
@@ -1576,7 +1579,7 @@
         + (flags.deleted ? ' deleted' : '')
         + (flags.flagged ? ' flagged' : '')
         + (flags.unread_children && !flags.unread && !this.env.autoexpand_threads ? ' unroot' : '')
-        + (this.message_list.in_selection(uid) ? ' selected' : ''),
+        + (message.selected ? ' selected' : ''),
       // for performance use DOM instead of jQuery here
       row = document.createElement('tr'),
       col = document.createElement('td');
@@ -1601,19 +1604,25 @@
     else if(flags.unread && this.env.unreadicon)
       icon = this.env.unreadicon;
 
+    // update selection
+    if (message.selected && !list.in_selection(uid))
+      list.selection.push(uid);
+
     // threads
     if (this.env.threading) {
       // This assumes that div width is hardcoded to 15px,
       var width = message.depth * 15;
       if (message.depth) {
-        if ((this.env.autoexpand_threads == 0 || this.env.autoexpand_threads == 2) &&
-            (!rows[message.parent_uid] || !rows[message.parent_uid].expanded)) {
+        if ((rows[message.parent_uid] && rows[message.parent_uid].expanded === false)
+          || ((this.env.autoexpand_threads == 0 || this.env.autoexpand_threads == 2) &&
+            (!rows[message.parent_uid] || !rows[message.parent_uid].expanded))
+        ) {
           row.style.display = 'none';
           message.expanded = false;
         }
         else
           message.expanded = true;
-        }
+      }
       else if (message.has_children) {
         if (typeof(message.expanded) == 'undefined' && (this.env.autoexpand_threads == 1 || (this.env.autoexpand_threads == 2 && message.unread_children))) {
           message.expanded = true;
@@ -1643,7 +1652,7 @@
     }
 
     // add each submitted col
-    for (var n = 0; n < this.env.coltypes.length; n++) {
+    for (var n in this.env.coltypes) {
       c = this.env.coltypes[n];
       col = document.createElement('td');
       col.className = String(c).toLowerCase();
@@ -1667,21 +1676,14 @@
       row.appendChild(col);
     }
 
-    this.message_list.insert_row(row, attop);
+    list.insert_row(row, attop);
 
     // remove 'old' row
-    if (attop && this.env.pagesize && this.message_list.rowcount > this.env.pagesize) {
-      var uid = this.message_list.get_last_row();
-      this.message_list.remove_row(uid);
-      this.message_list.clear_selection(uid);
+    if (attop && this.env.pagesize && list.rowcount > this.env.pagesize) {
+      var uid = list.get_last_row();
+      list.remove_row(uid);
+      list.clear_selection(uid);
     }
-  };
-
-  // messages list handling in background (for performance)
-  this.offline_message_list = function(flag)
-  {
-    if (this.message_list)
-   	  this.message_list.set_background_mode(flag);
   };
 
   this.set_list_sorting = function(sort_col, sort_order)
@@ -1859,9 +1861,10 @@
       url += '&_search='+this.env.search_request;
 
     // set page=1 if changeing to another mailbox
-    if (!page && this.env.mailbox != mbox) {
+    if (this.env.mailbox != mbox) {
       page = 1;
       this.env.current_page = page;
+      this.select_all_mode = false;
       this.show_contentframe(false);
     }
 
@@ -1872,7 +1875,6 @@
     this.last_selected = 0;
     if (this.message_list) {
       this.message_list.clear_selection();
-      this.select_all_mode = false;
     }
     this.select_folder(mbox, this.env.mailbox);
     this.env.mailbox = mbox;
@@ -1907,20 +1909,30 @@
     this.http_request('list', url+add_url, true);
   };
 
+  // removes messages that doesn't exists from list selection array
+  this.update_selection = function()
+  {
+    var selected = this.message_list.selection,
+      rows = this.message_list.rows,
+      i, selection = [];
+
+    for (i in selected)
+      if (rows[selected[i]])
+        selection.push(selected[i]);
+
+    this.message_list.selection = selection;
+  }
+
   // expand all threads with unread children
   this.expand_unread = function()
   {
-    var r, expando,
-      tbody = this.gui_objects.messagelist.tBodies[0],
+    var r, tbody = this.gui_objects.messagelist.tBodies[0],
       new_row = tbody.firstChild;
 
     while (new_row) {
       if (new_row.nodeType == 1 && (r = this.message_list.rows[new_row.uid])
 	    && r.unread_children) {
 	    this.message_list.expand_all(r);
-	    expando = document.getElementById('rcmexpando' + r.uid);
-	    if (expando)
-	      expando.className = 'expanded';
 	    this.set_unread_children(r.uid);
       }
       new_row = new_row.nextSibling;
@@ -1951,6 +1963,99 @@
       case 2: this.expand_unread(); break;
       case 1: this.message_list.expand_all(); break;
     }
+  };
+
+  // Initializes threads indicators/expanders after list update
+  this.init_threads = function(roots)
+  {
+    for (var n=0, len=roots.length; n<len; n++)
+      setTimeout(function() { rcmail.add_tree_icons(roots[n]);}, 1);
+    setTimeout(function() { rcmail.expand_threads();}, 1);
+  };
+
+  // adds threads tree icons to the list (or specified thread)
+  this.add_tree_icons = function(root)
+  {
+    var i, l, r, n, len, pos, tmp = [], uid = [],
+      row, rows = this.message_list.rows;
+
+    if (root)
+      row = rows[root] ? rows[root].obj : null;
+    else
+      row = this.message_list.list.tBodies[0].firstChild;
+
+    while (row) {
+      if (row.nodeType == 1 && (r = rows[row.uid])) {
+        if (r.depth) {
+          for (i=tmp.length-1; i>=0; i--) {
+            len = tmp[i].length;
+            if (len > r.depth) {
+              pos = len - r.depth;
+              if (!(tmp[i][pos] & 2))
+                tmp[i][pos] = tmp[i][pos] ? tmp[i][pos]+2 : 2;
+            }
+            else if (len == r.depth) {
+              if (!(tmp[i][0] & 2))
+                tmp[i][0] += 2;
+            }
+            if (r.depth > len)
+              break;
+          }
+
+          tmp.push(new Array(r.depth));
+          tmp[tmp.length-1][0] = 1;
+          uid.push(r.uid);
+        }
+        else {
+          if (tmp.length) {
+            for (i in tmp) {
+              this.set_tree_icons(uid[i], tmp[i]);
+            }
+            tmp = [];
+            uid = [];
+          }
+          if (root && row != rows[root].obj)
+            break;
+        }
+      }
+      row = row.nextSibling;
+    }
+
+    if (tmp.length) {
+      for (i in tmp) {
+        this.set_tree_icons(uid[i], tmp[i]);
+      }
+    }
+  };                                              
+
+  // adds tree icons to specified message row
+  this.set_tree_icons = function(uid, tree)
+  {
+    var i, divs = [], html = '', len = tree.length;
+
+    for (i=0; i<len; i++) {
+      if (tree[i] > 2)
+        divs.push({'class': 'l3', width: 15});
+      else if (tree[i] > 1)
+        divs.push({'class': 'l2', width: 15});
+      else if (tree[i] > 0)
+        divs.push({'class': 'l1', width: 15});
+      // separator div
+      else if (divs.length && !divs[divs.length-1]['class'])
+        divs[divs.length-1].width += 15;
+      else
+        divs.push({'class': null, width: 15});
+    }
+    
+    for (i=divs.length-1; i>=0; i--) {
+      if (divs[i]['class'])
+        html += '<div class="tree '+divs[i]['class']+'" />';
+      else
+        html += '<div style="width:'+divs[i].width+'px" />';
+    }
+    
+    if (html)
+      $('#rcmtab'+uid).html(html);
   };
 
   // update parent in a thread
@@ -2013,7 +2118,8 @@
 	      break;
 
 	    r.depth--; // move left
-	    $('#rcmtab'+r.uid).width(r.depth * 15);
+        // reset width and clear the content of a tab, icons will be added later
+	    $('#rcmtab'+r.uid).width(r.depth * 15).html('');
         if (!r.depth) { // a new root
 	      count++; // increase roots count
 	      r.parent_uid = 0;
@@ -2026,7 +2132,7 @@
 	            function(e) { return e.data.p.expand_message_row(e, e.data.uid); });
 
 	        r.unread_children = 0;
-	        roots[roots.length] = r;
+	        roots.push(r);
 	      }
 	      // show if it was hidden
 	      if (r.obj.style.display == 'none')
@@ -2164,7 +2270,7 @@
   {
     var row = this.message_list.rows[uid];
 
-    if (row.parent_uid || !row.has_children)
+    if (row.parent_uid)
       return;
 
     if (!row.unread && row.unread_children && !row.expanded)
@@ -2176,21 +2282,22 @@
   // copy selected messages to the specified mailbox
   this.copy_messages = function(mbox)
   {
+    if (mbox && typeof mbox == 'object')
+      mbox = mbox.id;
+
     // exit if current or no mailbox specified or if selection is empty
     if (!mbox || mbox == this.env.mailbox || (!this.env.uid && (!this.message_list || !this.message_list.get_selection().length)))
       return;
 
-    var add_url = '&_target_mbox='+urlencode(mbox)+'&_from='+(this.env.action ? this.env.action : '');
-    var a_uids = [];
+    var a_uids = [],
+      add_url = '&_target_mbox='+urlencode(mbox)+'&_from='+(this.env.action ? this.env.action : '');
 
     if (this.env.uid)
       a_uids[0] = this.env.uid;
     else {
       var selection = this.message_list.get_selection();
-      var id;
-      for (var n=0; n<selection.length; n++) {
-        id = selection[n];
-        a_uids[a_uids.length] = id;
+      for (var n in selection) {
+        a_uids.push(selection[n]);
       }
     }
 
@@ -2235,7 +2342,7 @@
       return;
 
     // also select childs of collapsed rows
-    for (var uid, i=0; i < selection.length; i++) {
+    for (var uid, i=0, len=selection.length; i<len; i++) {
       uid = selection[i];
       if (this.message_list.rows[uid].has_children && !this.message_list.rows[uid].expanded)
         this.message_list.select_childs(uid);
@@ -2283,21 +2390,33 @@
     if (this.env.uid)
       a_uids[0] = this.env.uid;
     else {
-      var selection = this.message_list.get_selection();
-      var id;
-      for (var n=0; n<selection.length; n++) {
+      var n, id, root, roots = [],
+        selection = this.message_list.get_selection();
+
+      for (n=0, len=selection.length; n<len; n++) {
         id = selection[n];
-        a_uids[a_uids.length] = id;
-        count += this.update_thread(id);
+        a_uids.push(id);
+
+        if (this.env.threading) {
+          count += this.update_thread(id);
+          root = this.message_list.find_root(id);
+          if (root != id && $.inArray(root, roots) < 0) {
+            roots.push(root);
+          }
+        }
         this.message_list.remove_row(id, (this.env.display_next && n == selection.length-1));
       }
       // make sure there are no selected rows
       if (!this.env.display_next)
         this.message_list.clear_selection();
+      // update thread tree icons
+      for (n=0, len=roots.length; n<len; n++) {
+        this.add_tree_icons(roots[n]);
+      }
     }
 
     // also send search request to get the right messages 
-    if (this.env.search_request) 
+    if (this.env.search_request)
       add_url += '&_search='+this.env.search_request;
 
     if (this.env.display_next && this.env.next_uid)
@@ -2318,7 +2437,7 @@
   // set a specific flag to one or more messages
   this.mark_message = function(flag, uid)
   {
-    var a_uids = [], r_uids = [],
+    var a_uids = [], r_uids = [], len, n, id,
       selection = this.message_list ? this.message_list.get_selection() : [];
 
     if (uid)
@@ -2326,15 +2445,15 @@
     else if (this.env.uid)
       a_uids[0] = this.env.uid;
     else if (this.message_list) {
-      for (var n=0; n<selection.length; n++) {
-          a_uids[a_uids.length] = selection[n];
+      for (n=0, len=selection.length; n<len; n++) {
+          a_uids.push(selection[n]);
       }
     }
 
     if (!this.message_list)
       r_uids = a_uids;
     else
-      for (var id, n=0; n<a_uids.length; n++) {
+      for (n=0, len=a_uids.length; n<len; n++) {
         id = a_uids[n];
         if ((flag=='read' && this.message_list.rows[id].unread) 
             || (flag=='unread' && !this.message_list.rows[id].unread)
@@ -2343,7 +2462,7 @@
             || (flag=='flagged' && !this.message_list.rows[id].flagged)
             || (flag=='unflagged' && this.message_list.rows[id].flagged))
         {
-          r_uids[r_uids.length] = id;
+          r_uids.push(id);
         }
       }
 
@@ -2374,7 +2493,13 @@
     for (var i=0; i<a_uids.length; i++)
       this.set_message(a_uids[i], 'unread', (flag=='unread' ? true : false));
 
-    this.http_post('mark', '_uid='+this.uids_to_list(a_uids)+'&_flag='+flag);
+    var url = '_uid='+this.uids_to_list(a_uids)+'&_flag='+flag;
+
+    // also send search request to get the right messages
+    if (this.env.search_request)
+      url += '&_search='+this.env.search_request;
+
+    this.http_post('mark', url);
 
     for (var i=0; i<a_uids.length; i++)
       this.update_thread_root(a_uids[i], flag);
@@ -2387,7 +2512,13 @@
     for (var i=0; i<a_uids.length; i++)
       this.set_message(a_uids[i], 'flagged', (flag=='flagged' ? true : false));
 
-    this.http_post('mark', '_uid='+this.uids_to_list(a_uids)+'&_flag='+flag);
+    var url = '_uid='+this.uids_to_list(a_uids)+'&_flag='+flag;
+
+    // also send search request to get the right messages
+    if (this.env.search_request)
+      url += '&_search='+this.env.search_request;
+
+    this.http_post('mark', url);
   };
 
   // mark all message rows as deleted/undeleted
@@ -2404,8 +2535,8 @@
       return true;
     }
 
-    var all_deleted = true;
-    for (var uid, i=0; i<a_uids.length; i++) {
+    var uid, all_deleted = true;
+    for (var i=0, len=a_uids.length; i<len; i++) {
       uid = a_uids[i];
       if (rows[uid] && !rows[uid].deleted) {
         all_deleted = false;
@@ -2423,10 +2554,16 @@
 
   this.flag_as_undeleted = function(a_uids)
   {
-    for (var i=0; i<a_uids.length; i++)
+    for (var i=0, len=a_uids.length; i<len; i++)
       this.set_message(a_uids[i], 'deleted', false);
 
-    this.http_post('mark', '_uid='+this.uids_to_list(a_uids)+'&_flag=undelete');
+    var url = '_uid='+this.uids_to_list(a_uids)+'&_flag=undelete';
+
+    // also send search request to get the right messages
+    if (this.env.search_request)
+      url += '&_search='+this.env.search_request;
+
+    this.http_post('mark', url);
     return true;
   };
 
@@ -2437,7 +2574,7 @@
       rows = this.message_list ? this.message_list.rows : [],
       count = 0;
 
-    for (var i=0; i<a_uids.length; i++) {
+    for (var i=0, len=a_uids.length; i<len; i++) {
       uid = a_uids[i];
       if (rows[uid]) {
         if (rows[uid].unread)
@@ -2470,12 +2607,13 @@
       add_url += '&_ruid='+this.uids_to_list(r_uids);
 
     if (this.env.skip_deleted) {
-      // also send search request to get the right messages 
-      if (this.env.search_request) 
-        add_url += '&_search='+this.env.search_request;
       if (this.env.display_next && this.env.next_uid)
         add_url += '&_next_uid='+this.env.next_uid;
     }
+
+    // also send search request to get the right messages
+    if (this.env.search_request)
+      add_url += '&_search='+this.env.search_request;
 
     this.http_post('mark', '_uid='+this.uids_to_list(a_uids)+'&_flag=delete'+add_url);
     return true;  
@@ -3392,10 +3530,7 @@
     var add_url = '';
     var target = window;
 
-    // currently all groups belong to the local address book
-    if (group)
-      src = 0;
-    else if (!src)
+    if (!src)
       src = this.env.source;
 
     if (page && this.current_page == page && src == this.env.source && group == this.env.group)
@@ -3409,7 +3544,7 @@
     else if (group != this.env.group)
       page = this.env.current_page = 1;
 
-    this.select_folder((group ? 'G'+group : src), (this.env.group ? 'G'+this.env.group : this.env.source));
+    this.select_folder((group ? 'G'+src+group : src), (this.env.group ? 'G'+this.env.source+this.env.group : this.env.source));
 
     this.env.source = src;
     this.env.group = group;
@@ -3494,7 +3629,7 @@
     if (to.type == 'group')
       this.http_post('group-addmembers', '_cid='+urlencode(cid)+'&_source='+urlencode(this.env.source)+'&_gid='+urlencode(to.id));
     else if (to.id != this.env.source && cid && this.env.address_sources[to.id] && !this.env.address_sources[to.id].readonly)
-      this.http_post('copy', '_cid='+urlencode(cid)+'&_source='+urlencode(this.env.source)+'&_to='+urlencode(to.id));
+      this.http_post('copy', '_cid='+urlencode(cid)+'&_source='+urlencode(this.env.source)+'&_to='+urlencode(to.id)+(this.env.group ? '&_gid='+urlencode(this.env.group) : ''));
   };
 
 
@@ -3505,15 +3640,14 @@
     if (!(selection.length || this.env.cid) || (!this.env.group && !confirm(this.get_label('deletecontactconfirm'))))
       return;
 
-    var a_cids = [], qs = '';
+    var id, a_cids = [], qs = '';
 
     if (this.env.cid)
-      a_cids[a_cids.length] = this.env.cid;
+      a_cids.push(this.env.cid);
     else {
-      var id;
       for (var n=0; n<selection.length; n++) {
         id = selection[n];
-        a_cids[a_cids.length] = id;
+        a_cids.push(id);
         this.contact_list.remove_row(id, (n == selection.length-1));
       }
 
@@ -3600,7 +3734,8 @@
       this.name_input.type = 'text';
       this.name_input.onkeypress = function(e){ return rcmail.add_input_keypress(e); };
 
-      this.gui_objects.folderlist.parentNode.appendChild(this.name_input);
+      var li = this.get_folder_li(this.env.source)
+      $(this.name_input).insertAfter(li);
     }
 
     this.name_input.select();
@@ -3615,11 +3750,11 @@
       this.enable_command('list', 'listgroup', false);
       this.name_input = document.createElement('input');
       this.name_input.type = 'text';
-      this.name_input.value = this.env.contactgroups['G'+this.env.group].name;
+      this.name_input.value = this.env.contactgroups['G'+this.env.source+this.env.group].name;
       this.name_input.onkeypress = function(e){ return rcmail.add_input_keypress(e); };
       this.env.group_renaming = true;
 
-      var link, li = this.get_folder_li(this.env.group, 'rcmliG');
+      var li = this.get_folder_li(this.env.source+this.env.group, 'rcmliG');
       if (li && (link = li.firstChild)) {
         $(link).hide();
         li.insertBefore(this.name_input, link);
@@ -3636,18 +3771,18 @@
   };
 
   // callback from server upon group-delete command
-  this.remove_group_item = function(id)
+  this.remove_group_item = function(prop)
   {
-    var li, key = 'G'+id;
+    var li, key = 'G'+prop.source+prop.id;
     if ((li = this.get_folder_li(key))) {
-      this.triggerEvent('removegroup', { id:id, li:li });
+      this.triggerEvent('removegroup', { source:prop.source, id:prop.id, li:li });
 
       li.parentNode.removeChild(li);
       delete this.env.contactfolders[key];
       delete this.env.contactgroups[key];
     }
 
-    this.list_contacts(null, 0);
+    this.list_contacts(prop.source, 0);
   };
 
   // handler for keyboard events on the input field
@@ -3697,30 +3832,31 @@
     this.reset_add_input();
 
     prop.type = 'group';
-    var key = 'G'+prop.id;
+    var key = 'G'+prop.source+prop.id;
     this.env.contactfolders[key] = this.env.contactgroups[key] = prop;
 
     var link = $('<a>').attr('href', '#')
-      .bind('click', function() { return rcmail.command('listgroup', prop.id, this);})
+      .bind('click', function() { return rcmail.command('listgroup', prop, this);})
       .html(prop.name);
     var li = $('<li>').attr('id', 'rcmli'+key).addClass('contactgroup').append(link);
-    $(this.gui_objects.folderlist).append(li);
+    var pli = this.get_folder_li(prop.source)
+    $(li).insertAfter(pli);
 
-    this.triggerEvent('insertgroup', { id:prop.id, name:prop.name, li:li[0] });
+    this.triggerEvent('insertgroup', { id:prop.id, source:prop.source, name:prop.name, li:li[0] });
   };
 
   // callback for renaming a contact group
-  this.update_contact_group = function(id, name)
+  this.update_contact_group = function(prop)
   {
     this.reset_add_input();
 
-    var key = 'G'+id, link, li = this.get_folder_li(key);
+    var key = 'G'+prop.source+prop.id, link, li = this.get_folder_li(key);
 
     if (li && (link = li.firstChild) && link.tagName.toLowerCase() == 'a')
-      link.innerHTML = name;
+      link.innerHTML = prop.name;
 
     this.env.contactfolders[key].name = this.env.contactgroups[key].name = name;
-    this.triggerEvent('updategroup', { id:id, name:name, li:li[0] });
+    this.triggerEvent('updategroup', { id:prop.id, source:prop.source, name:prop.name, li:li[0] });
   };
 
 
@@ -4688,8 +4824,7 @@
     }
 
     // replace quota image
-    obj.innerHTML = '';
-    $(obj).append(bar1).append(bar2).append(main);
+    $(obj).html('').append(bar1).append(bar2).append(main);
   };
 
   /********************************************************/
@@ -4699,7 +4834,7 @@
   this.html2plain = function(htmlText, id)
   {
     var rcmail = this,
-      url = this.env.bin_path + 'html2text.php';
+      url = '?_task=utils&_action=html2text';
 
     this.set_busy(true, 'converting');
     console.log('HTTP POST: ' + url);
@@ -4811,8 +4946,6 @@
           // re-enable commands on move/delete error
           this.enable_command('reply', 'reply-all', 'forward', 'delete', 'mark', 'print', 'open', 'edit', 'viewsource', 'download', true);
         }
-        else if (this.message_list)
-          this.message_list.init();
         break;
 
       case 'purge':
@@ -4840,7 +4973,6 @@
 
           if (response.action == 'list' || response.action == 'search') {
             this.msglist_select(this.message_list);
-            this.expand_threads();
             this.triggerEvent('listupdate', { folder:this.env.mailbox, rowcount:this.message_list.rowcount });
           }
         }
@@ -4848,8 +4980,10 @@
           this.enable_command('export', (this.contact_list && this.contact_list.rowcount > 0));
 
           if (response.action == 'list' || response.action == 'search') {
-            this.enable_command('group-create', this.env.address_sources[this.env.source].groups);
-            this.enable_command('group-rename', 'group-delete', this.env.address_sources[this.env.source].groups && this.env.group);
+            this.enable_command('group-create',
+              (this.env.address_sources[this.env.source].groups && !this.env.address_sources[this.env.source].readonly));
+            this.enable_command('group-rename', 'group-delete',
+              (this.env.address_sources[this.env.source].groups && this.env.group && !this.env.address_sources[this.env.source].readonly));
             this.triggerEvent('listupdate', { folder:this.env.source, rowcount:this.contact_list.rowcount });
           }
         }
@@ -4869,23 +5003,26 @@
       this.display_message(this.get_label('servererror') + ' (' + errmsg + ')', 'error');
   };
 
-  // use an image to send a keep-alive siganl to the server
-  this.send_keep_alive = function()
-  {
-    var d = new Date();
-    this.http_request('keep-alive', '_t='+d.getTime());
-  };
-
-  // start interval for keep-alive/recent_check signal
+  // starts interval for keep-alive/check-recent signal
   this.start_keepalive = function()
   {
+    if (this._int)
+      clearInterval(this._int);
+
     if (this.env.keep_alive && !this.env.framed && this.task=='mail' && this.gui_objects.mailboxlist)
       this._int = setInterval(function(){ ref.check_for_recent(false); }, this.env.keep_alive * 1000);
     else if (this.env.keep_alive && !this.env.framed && this.task!='login')
       this._int = setInterval(function(){ ref.send_keep_alive(); }, this.env.keep_alive * 1000);
   };
 
-  // send periodic request to check for recent messages
+  // sends keep-alive signal to the server
+  this.send_keep_alive = function()
+  {
+    var d = new Date();
+    this.http_request('keep-alive', '_t='+d.getTime());
+  };
+
+  // sends request to check for recent messages
   this.check_for_recent = function(refresh)
   {
     if (this.busy)
@@ -4896,6 +5033,8 @@
     if (refresh) {
       this.set_busy(true, 'checkingmail');
       addurl += '&_refresh=1';
+      // reset check-recent interval
+      this.start_keepalive();
     }
 
     if (this.gui_objects.messagelist)
@@ -4972,7 +5111,7 @@
       return;
 
     var type;
-    for (var n=0; n<form.elements.length; n++) {
+    for (var n=0, len=form.elements.length; n<len; n++) {
       type = form.elements[n];
       if (type == 'hidden')
         continue;

--
Gitblit v1.9.1