From 38dc510b2dba02dba5a60fbc00947aac4fd24aab Mon Sep 17 00:00:00 2001 From: alecpl <alec@alec.pl> Date: Wed, 29 Feb 2012 06:53:52 -0500 Subject: [PATCH] - Fix warning when properties array is empty --- program/include/rcube_template.php | 70 ++++++++++++++++++++++++++++------ 1 files changed, 57 insertions(+), 13 deletions(-) diff --git a/program/include/rcube_template.php b/program/include/rcube_template.php old mode 100755 new mode 100644 index 1a82f7e..94fa676 --- a/program/include/rcube_template.php +++ b/program/include/rcube_template.php @@ -6,7 +6,10 @@ | | | This file is part of the Roundcube Webmail client | | Copyright (C) 2006-2011, The Roundcube Dev Team | - | Licensed under the GNU GPL | + | | + | Licensed under the GNU General Public License version 3 or | + | any later version with exceptions for skins & plugins. | + | See the README file for a full license statement. | | | | PURPOSE: | | Class to handle HTML page output using a skin template. | @@ -71,6 +74,7 @@ //$this->framed = $framed; $this->set_env('task', $task); + $this->set_env('x_frame_options', $this->app->config->get('x_frame_options', 'sameorigin')); // load the correct skin (in case user-defined) $this->set_skin($this->config['skin']); @@ -93,6 +97,7 @@ 'username' => array($this, 'current_username'), 'message' => array($this, 'message_container'), 'charsetselector' => array($this, 'charset_selector'), + 'aboutcontent' => array($this, 'about_content'), )); } @@ -159,6 +164,14 @@ $this->config['skin_path'] = $skin_path; return $valid; + } + + /** + * Getter for the current skin path property + */ + public function get_skin_path() + { + return $this->config['skin_path']; } /** @@ -433,7 +446,11 @@ // trigger generic hook where plugins can put additional content to the page $hook = $this->app->plugins->exec_hook("render_page", array('template' => $realname, 'content' => $output)); - $output = $this->parse_with_globals($hook['content']); + // save some memory + $output = $hook['content']; + unset($hook['content']); + + $output = $this->parse_with_globals($output); // make sure all <form> tags have a valid request token $output = preg_replace_callback('/<form\s+([^>]+)>/Ui', array($this, 'alter_form_tag'), $output); @@ -444,7 +461,7 @@ if ($realname != 'error' && ($this->config['debug_level'] & 8)) { $this->add_footer('<div id="console" style="position:absolute;top:5px;left:5px;width:405px;padding:2px;background:white;z-index:9000;display:none"> <a href="#toggle" onclick="con=$(\'#dbgconsole\');con[con.is(\':visible\')?\'hide\':\'show\']();return false">console</a> - <textarea name="console" id="dbgconsole" rows="20" cols="40" wrap="off" style="display:none;width:400px;border:none;font-size:10px" spellcheck="false"></textarea></div>' + <textarea name="console" id="dbgconsole" rows="20" cols="40" style="display:none;width:400px;border:none;font-size:10px" spellcheck="false"></textarea></div>' ); $this->add_script( "if (!window.console || !window.console.log) {\n". @@ -519,6 +536,7 @@ { $GLOBALS['__version'] = Q(RCMAIL_VERSION); $GLOBALS['__comm_path'] = Q($this->app->comm_path); + $GLOBALS['__skin_path'] = Q($this->config['skin_path']); return preg_replace_callback('/\$(__[a-z0-9_\-]+)/', array($this, 'globals_callback'), $input); } @@ -655,7 +673,7 @@ */ private function parse_xml($input) { - return preg_replace_callback('/<roundcube:([-_a-z]+)\s+([^>]+)>/Ui', array($this, 'xml_command'), $input); + return preg_replace_callback('/<roundcube:([-_a-z]+)\s+((?:[^>]|\\\\>)+)(?<!\\\\)>/Ui', array($this, 'xml_command'), $input); } @@ -742,6 +760,9 @@ else if (function_exists($handler)) { $content = call_user_func($handler, $attrib); } + else if ($object == 'doctype') { + $content = html::doctype($attrib['value']); + } else if ($object == 'logo') { $attrib += array('alt' => $this->xml_command(array('', 'object', 'name="productname"'))); if ($this->config['skin_logo']) @@ -795,8 +816,8 @@ break; case 'config': $value = $this->config[$name]; - if (is_array($value) && $value[$_SESSION['imap_host']]) { - $value = $value[$_SESSION['imap_host']]; + if (is_array($value) && $value[$_SESSION['storage_host']]) { + $value = $value[$_SESSION['storage_host']]; } break; case 'request': @@ -965,6 +986,8 @@ else if ($attrib['type']=='link') { $btn_content = isset($attrib['content']) ? $attrib['content'] : ($attrib['label'] ? $attrib['label'] : $attrib['command']); $link_attrib = array('href', 'onclick', 'title', 'id', 'class', 'style', 'tabindex', 'target'); + if ($attrib['innerclass']) + $btn_content = html::span($attrib['innerclass'], $btn_content); } else if ($attrib['type']=='input') { $attrib['type'] = 'button'; @@ -972,14 +995,11 @@ if ($attrib['label']) { $attrib['value'] = $attrib['label']; } + if ($attrib['command']) { + $attrib['disabled'] = 'disabled'; + } - $attrib_str = html::attrib_string( - $attrib, - array( - 'type', 'value', 'onclick', 'id', 'class', 'style', 'tabindex' - ) - ); - $out = sprintf('<input%s disabled="disabled" />', $attrib_str); + $out = html::tag('input', $attrib, '', array('type', 'value', 'onclick', 'id', 'class', 'style', 'tabindex', 'disabled')); } // generate html code for button @@ -1325,6 +1345,30 @@ return $select->show($set); } + /** + * Include content from config/about.<LANG>.html if available + */ + private function about_content($attrib) + { + $content = ''; + $filenames = array( + 'about.' . $_SESSION['language'] . '.html', + 'about.' . substr($_SESSION['language'], 0, 2) . '.html', + 'about.html', + ); + foreach ($filenames as $file) { + $fn = RCMAIL_CONFIG_DIR . '/' . $file; + if (is_readable($fn)) { + $content = file_get_contents($fn); + $content = $this->parse_conditions($content); + $content = $this->parse_xml($content); + break; + } + } + + return $content; + } + } // end class rcube_template -- Gitblit v1.9.1