From 2c200021fdf9b5d1c73e39e7c46e7db1e4152e91 Mon Sep 17 00:00:00 2001 From: alecpl <alec@alec.pl> Date: Mon, 15 Nov 2010 04:26:24 -0500 Subject: [PATCH] - Fix focused elements aren't unfocused when clicking on the list (#1487123) --- program/js/app.js | 706 +++++++++++++++++++++++++++++++++++----------------------- 1 files changed, 426 insertions(+), 280 deletions(-) diff --git a/program/js/app.js b/program/js/app.js index c42b62c..7c38b14 100644 --- a/program/js/app.js +++ b/program/js/app.js @@ -29,6 +29,7 @@ this.commands = {}; this.command_handlers = {}; this.onloads = []; + this.messages = {}; // create protected reference to myself this.ref = 'rcmail'; @@ -36,7 +37,7 @@ // webmail client settings this.dblclick_time = 500; - this.message_time = 3000; + this.message_time = 1500; this.identifier_expr = new RegExp('[^0-9a-z\-_]', 'gi'); @@ -147,8 +148,10 @@ this.init_buttons(); // tell parent window that this frame is loaded - if (this.env.framed && parent.rcmail && parent.rcmail.set_busy) - parent.rcmail.set_busy(false); + if (this.env.framed && parent.rcmail && parent.rcmail.set_busy) { + parent.rcmail.set_busy(false, null, parent.rcmail.env.frame_lock); + parent.rcmail.env.frame_lock = null; + } // enable general commands this.enable_command('logout', 'mail', 'addressbook', 'settings', true); @@ -199,17 +202,17 @@ if (this.env.trash_mailbox && this.env.mailbox != this.env.trash_mailbox) this.set_alttext('delete', 'movemessagetotrash'); - this.env.message_commands = ['show', 'reply', 'reply-all', 'forward', 'moveto', 'copy', 'delete', - 'open', 'mark', 'edit', 'viewsource', 'download', 'print', 'load-attachment', 'load-headers']; + this.env.message_commands = ['show', 'reply', 'reply-all', 'reply-list', 'forward', + 'moveto', 'copy', 'delete', 'open', 'mark', 'edit', 'viewsource', 'download', + 'print', 'load-attachment', 'load-headers']; if (this.env.action=='show' || this.env.action=='preview') { this.enable_command(this.env.message_commands, this.env.uid); + this.enable_command('reply-list', this.env.list_post); - if (this.env.next_uid) { - this.enable_command('nextmessage', 'lastmessage', true); - } - if (this.env.prev_uid) { - this.enable_command('previousmessage', 'firstmessage', true); + if (this.env.action == 'show') { + this.http_request('pagenav', '_uid='+this.env.uid+'&_mbox='+urlencode(this.env.mailbox), + this.display_message('', 'loading')); } if (this.env.blockedobjects) { @@ -225,17 +228,20 @@ } } else if (this.env.action == 'compose') { - this.enable_command('send-attachment', 'remove-attachment', 'send', 'toggle-editor', true); + this.env.compose_commands = ['send-attachment', 'remove-attachment', 'send', 'toggle-editor']; + + if (this.env.drafts_mailbox) + this.env.compose_commands.push('savedraft') + + this.enable_command(this.env.compose_commands, 'identities', true); if (this.env.spellcheck) { this.env.spellcheck.spelling_state_observer = function(s){ ref.set_spellcheck_state(s); }; + this.env.compose_commands.push('spellcheck') this.set_spellcheck_state('ready'); if ($("input[name='_is_html']").val() == '1') this.display_spellcheck_controls(false); } - - if (this.env.drafts_mailbox) - this.enable_command('savedraft', true); document.onmouseup = function(e){ return p.doc_mouse_up(e); }; @@ -298,13 +304,27 @@ this.enable_command('group-create', this.env.address_sources[this.env.source].groups); } - if (this.env.cid) + if (this.env.cid) { this.enable_command('show', 'edit', true); + // register handlers for group assignment via checkboxes + if (this.gui_objects.editform) { + $('input.groupmember').change(function(){ + var cmd = this.checked ? 'group-addmembers' : 'group-delmembers'; + ref.http_post(cmd, '_cid='+urlencode(ref.env.cid) + + '&_source='+urlencode(ref.env.source) + + '&_gid='+urlencode(this.value)); + }); + } + } - if ((this.env.action=='add' || this.env.action=='edit') && this.gui_objects.editform) + if ((this.env.action=='add' || this.env.action=='edit') && this.gui_objects.editform) { this.enable_command('save', true); - else + $("input[type='text']").first().select(); + } + else if (this.gui_objects.qsearchbox) { this.enable_command('search', 'reset-search', 'moveto', true); + $(this.gui_objects.qsearchbox).select(); + } if (this.contact_list && this.contact_list.rowcount > 0) this.enable_command('export', true); @@ -359,8 +379,8 @@ $('#rcmlogintz').val(new Date().getTimezoneOffset() / -60); // display 'loading' message on form submit - $('form').submit(function () { - rcmail.display_message(rcmail.get_label('loading'), 'loading', true); + $('form').submit(function () { + rcmail.display_message(rcmail.get_label('loading'), 'loading'); }); this.enable_command('login', true); @@ -421,8 +441,7 @@ } // check input before leaving compose step - if (this.task=='mail' && this.env.action=='compose' - && (command == 'list' || command == 'mail' || command == 'addressbook' || command == 'settings')) { + if (this.task=='mail' && this.env.action=='compose' && $.inArray(command, this.env.compose_commands)<0) { if (this.cmp_hash != this.compose_field_hash() && !confirm(this.get_label('notsentwarning'))) return false; } @@ -836,10 +855,12 @@ if (!this.env.drafts_mailbox || this.cmp_hash == this.compose_field_hash()) break; - this.set_busy(true, 'savingmessage'); - var form = this.gui_objects.messageform; + var form = this.gui_objects.messageform, + msgid = this.set_busy(true, 'savingmessage'); + form.target = "savetarget"; form._draft.value = '1'; + form.action = this.add_url(form.action, '_unlock', msgid); form.submit(); break; @@ -854,10 +875,12 @@ self.clearTimeout(this.save_timer); // all checks passed, send message - this.set_busy(true, 'sendingmessage'); - var form = this.gui_objects.messageform; + var form = this.gui_objects.messageform, + msgid = this.set_busy(true, 'sendingmessage'); + form.target = 'savetarget'; form._draft.value = ''; + form.action = this.add_url(form.action, '_unlock', msgid); form.submit(); // clear timeout (sending could take longer) @@ -876,10 +899,19 @@ break; case 'reply-all': + case 'reply-list': case 'reply': var uid; - if (uid = this.get_single_uid()) - this.goto_url('compose', '_reply_uid='+uid+'&_mbox='+urlencode(this.env.mailbox)+(command=='reply-all' ? '&_all=1' : ''), true); + if (uid = this.get_single_uid()) { + var url = '_reply_uid='+uid+'&_mbox='+urlencode(this.env.mailbox); + if (command == 'reply-all') + // do reply-list, when list is detected and popup menu wasn't used + url += '&_all=' + (!props && this.commands['reply-list'] ? 'list' : 'all'); + else if (command == 'reply-list') + url += '&_all=list'; + + this.goto_url('compose', url, true); + } break; case 'forward': @@ -970,11 +1002,11 @@ break; case 'identities': - this.goto_url('identities'); + this.goto_url('settings/identities'); break; case 'folders': - this.goto_url('folders'); + this.goto_url('settings/folders'); break; // unified command call (command name == function name) @@ -1013,19 +1045,17 @@ }; // lock/unlock interface - this.set_busy = function(a, message) + this.set_busy = function(a, message, id) { if (a && message) { var msg = this.get_label(message); if (msg == message) msg = 'Loading...'; - // @TODO: show many messages at a time (one below the other ?) - if (this.message_type() != 'error') - this.display_message(msg, 'loading', true); + id = this.display_message(msg, 'loading'); } - else if (!a && this.message_type() != 'error') { - this.hide_message(); + else if (!a && id) { + this.hide_message(id); } this.busy = a; @@ -1041,6 +1071,8 @@ // set timer for requests if (a && this.env.request_timeout) this.request_timer = window.setTimeout(function(){ ref.request_timed_out(); }, this.env.request_timeout * 1000); + + return id; }; // return a localized string @@ -1095,6 +1127,26 @@ location.href = this.env.comm_path; }; + // Add variable to GET string, replace old value if exists + this.add_url = function(url, name, value) + { + value = urlencode(value); + + if (/(\?.*)$/.test(url)) { + var urldata = RegExp.$1, + datax = RegExp('((\\?|&)'+RegExp.escape(name)+'=[^&]*)'); + + if (datax.test(urldata)) { + urldata = urldata.replace(datax, RegExp.$2 + name + '=' + value); + } + else + urldata += '&' + name + '=' + value + + return url.replace(/(\?.*)$/, urldata); + } + else + return url + '?' + name + '=' + value; + }; /*********************************************************/ /********* event handling methods *********/ @@ -1137,8 +1189,7 @@ clearTimeout(this.preview_read_timer); // save folderlist and folders location/sizes for droptarget calculation in drag_move() - if (this.gui_objects.folderlist && model) - { + if (this.gui_objects.folderlist && model) { this.initialBodyScrollTop = bw.ie ? 0 : window.pageYOffset; this.initialListScrollTop = this.gui_objects.folderlist.parentNode.scrollTop; @@ -1288,7 +1339,7 @@ } } - this.http_post('utils/save-pref', '_name=collapsed_folders&_value='+urlencode(this.env.collapsed_folders)); + this.http_post('save-pref', '_name=collapsed_folders&_value='+urlencode(this.env.collapsed_folders)); this.set_unread_count_display(id, false); }; @@ -1360,9 +1411,16 @@ var selected = list.get_single_selection() != null; this.enable_command(this.env.message_commands, selected); - // Hide certain command buttons when Drafts folder is selected - if (selected && this.env.mailbox == this.env.drafts_mailbox) { - this.enable_command('reply', 'reply-all', 'forward', false); + if (selected) { + // Hide certain command buttons when Drafts folder is selected + if (this.env.mailbox == this.env.drafts_mailbox) + this.enable_command('reply', 'reply-all', 'reply-list', 'forward', false); + // Disable reply-list when List-Post header is not set + else { + var msg = this.env.messages[list.get_single_selection()]; + if (!msg.ml) + this.enable_command('reply-list', false); + } } // Multi-message commands this.enable_command('delete', 'moveto', 'copy', 'mark', (list.selection.length > 0 ? true : false)); @@ -1459,7 +1517,7 @@ if ((found = $.inArray('subject', this.env.coltypes)) >= 0) this.set_env('subject_col', found); - this.http_post('utils/save-pref', { '_name':'list_cols', '_value':this.env.coltypes, '_session':'list_attrib/columns' }); + this.http_post('save-pref', { '_name':'list_cols', '_value':this.env.coltypes, '_session':'list_attrib/columns' }); }; this.check_droptarget = function(id) @@ -1494,21 +1552,28 @@ this.init_message_row = function(row) { - var expando, self = this, uid = row.uid; + var expando, self = this, uid = row.uid, + status_icon = (this.env.status_col != null ? 'status' : 'msg') + 'icn' + row.uid; if (uid && this.env.messages[uid]) $.extend(row, this.env.messages[uid]); - // set eventhandler to message icon - if (this.env.subject_col != null && (row.icon = document.getElementById('msgicn'+row.uid))) { + // set eventhandler to status icon + if (row.icon = document.getElementById(status_icon)) { row.icon._row = row.obj; - row.icon.onmousedown = function(e) { self.command('toggle_status', this); }; + row.icon.onmousedown = function(e) { self.command('toggle_status', this); rcube_event.cancel(e); }; } + // save message icon position too + if (this.env.status_col != null) + row.msgicon = document.getElementById('msgicn'+row.uid); + else + row.msgicon = row.icon; + // set eventhandler to flag icon, if icon found - if (this.env.flagged_col != null && (row.flagged_icon = document.getElementById('flaggedicn'+row.uid))) { - row.flagged_icon._row = row.obj; - row.flagged_icon.onmousedown = function(e) { self.command('toggle_flag', this); }; + if (this.env.flagged_col != null && (row.flagicon = document.getElementById('flagicn'+row.uid))) { + row.flagicon._row = row.obj; + row.flagicon.onmousedown = function(e) { self.command('toggle_flag', this); rcube_event.cancel(e); }; } if (!row.depth && row.has_children && (expando = document.getElementById('rcmexpando'+row.uid))) { @@ -1540,11 +1605,13 @@ unread_children: flags.unread_children?flags.unread_children:0, parent_uid: flags.parent_uid?flags.parent_uid:0, selected: this.select_all_mode || this.message_list.in_selection(uid), + ml: flags.ml?1:0, + ctype: flags.ctype, // flags from plugins flags: flags.extra_flags }); - var c, tree = expando = '', + var c, html, tree = expando = '', list = this.message_list, rows = list.rows, tbody = this.gui_objects.messagelist.tBodies[0], @@ -1565,22 +1632,21 @@ row.id = 'rcmrow'+uid; row.className = css_class; - // message status icon - var icon = this.env.messageicon; - if (!flags.unread && flags.unread_children > 0 && this.env.unreadchildrenicon) - icon = this.env.unreadchildrenicon; - else if (flags.deleted && this.env.deletedicon) - icon = this.env.deletedicon; - else if (flags.replied && this.env.repliedicon) { - if (flags.forwarded && this.env.forwardedrepliedicon) - icon = this.env.forwardedrepliedicon; - else - icon = this.env.repliedicon; + // message status icons + css_class = 'msgicon'; + if (this.env.status_col === null) { + css_class += ' status'; + if (flags.deleted) + css_class += ' deleted'; + else if (flags.unread) + css_class += ' unread'; + else if (flags.unread_children > 0) + css_class += ' unreadchildren'; } - else if (flags.forwarded && this.env.forwardedicon) - icon = this.env.forwardedicon; - else if(flags.unread && this.env.unreadicon) - icon = this.env.unreadicon; + if (flags.replied) + css_class += ' replied'; + if (flags.forwarded) + css_class += ' forwarded'; // update selection if (message.selected && !list.in_selection(uid)) @@ -1614,7 +1680,7 @@ expando = '<div id="rcmexpando' + uid + '" class="' + (message.expanded ? 'expanded' : 'collapsed') + '"> </div>'; } - tree += icon ? '<img id="msgicn'+uid+'" src="'+icon+'" alt="" class="msgicon" />' : ''; + tree += '<span id="msgicn'+uid+'" class="'+css_class+'"> </span>'; // build subject link if (!bw.ie && cols.subject) { @@ -1630,17 +1696,31 @@ col = document.createElement('td'); col.className = String(c).toLowerCase(); - var html; if (c == 'flag') { - if (flags.flagged && this.env.flaggedicon) - html = '<img id="flaggedicn'+uid+'" src="'+this.env.flaggedicon+'" class="flagicon" alt="" />'; - else if(!flags.flagged && this.env.unflaggedicon) - html = '<img id="flaggedicn'+uid+'" src="'+this.env.unflaggedicon+'" class="flagicon" alt="" />'; + css_class = (flags.flagged ? 'flagged' : 'unflagged'); + html = '<span id="flagicn'+uid+'" class="'+css_class+'"> </span>'; + } + else if (c == 'attachment') { + if (/application\/|multipart\/m/.test(flags.ctype)) + html = '<span class="attachment"> </span>'; + else if (/multipart\/report/.test(flags.ctype)) + html = '<span class="report"> </span>'; + else + html = ' '; + } + else if (c == 'status') { + if (flags.deleted) + css_class = 'deleted'; + else if (flags.unread) + css_class = 'unread'; + else if (flags.unread_children > 0) + css_class = 'unreadchildren'; + else + css_class = 'msgicon'; + html = '<span id="statusicn'+uid+'" class="'+css_class+'"> </span>'; } else if (c == 'threads') html = expando; - else if (c == 'attachment') - html = flags.attachment && this.env.attachmenticon ? '<img src="'+this.env.attachmenticon+'" alt="" />' : ' '; else if (c == 'subject') html = tree + cols[c]; else @@ -1722,27 +1802,28 @@ if (!id) return; - var add_url = '', - target = window, - action = preview ? 'preview': 'show'; + var target = window, + action = preview ? 'preview': 'show', + url = '&_action='+action+'&_uid='+id+'&_mbox='+urlencode(this.env.mailbox); if (preview && this.env.contentframe && window.frames && window.frames[this.env.contentframe]) { target = window.frames[this.env.contentframe]; - add_url = '&_framed=1'; + url += '&_framed=1'; } if (safe) - add_url = '&_safe=1'; + url += '&_safe=1'; // also send search request to get the right messages if (this.env.search_request) - add_url += '&_search='+this.env.search_request; + url += '&_search='+this.env.search_request; - var url = '&_action='+action+'&_uid='+id+'&_mbox='+urlencode(this.env.mailbox)+add_url; if (action == 'preview' && String(target.location.href).indexOf(url) >= 0) this.show_contentframe(true); else { - this.set_busy(true, 'loading'); + if (!this.env.frame_lock) { + (parent.rcmail ? parent.rcmail : this).env.frame_lock = this.set_busy(true, 'loading'); + } target.location.href = this.env.comm_path+url; // mark as read and change mbox unread counter @@ -1755,7 +1836,7 @@ ref.set_unread_count(ref.env.mailbox, ref.env.unread_counts[ref.env.mailbox], ref.env.mailbox == 'INBOX'); } if (ref.env.preview_pane_mark_read > 0) - ref.http_post('mark', '_uid='+id+'&_flag=read'); + ref.http_post('mark', '_uid='+id+'&_flag=read&_quiet=1'); }, this.env.preview_pane_mark_read * 1000); } } @@ -1774,7 +1855,7 @@ } if (!show && this.busy) - this.set_busy(false); + this.set_busy(false, null, this.env.frame_lock); }; // list a specific page @@ -1802,18 +1883,18 @@ // list messages of a specific mailbox using filter this.filter_mailbox = function(filter) { - var search; + var search, lock = this.set_busy(true, 'searching'); + if (this.gui_objects.qsearchbox) search = this.gui_objects.qsearchbox.value; - this.message_list.clear(); + this.clear_message_list(); // reset vars this.env.current_page = 1; - this.set_busy(true, 'searching'); this.http_request('search', '_filter='+filter + (search ? '&_q='+urlencode(search) : '') - + (this.env.mailbox ? '&_mbox='+urlencode(this.env.mailbox) : ''), true); + + (this.env.mailbox ? '&_mbox='+urlencode(this.env.mailbox) : ''), lock); }; // list messages of a specific mailbox @@ -1886,9 +1967,9 @@ this.message_list.clear(); // send request to server - var url = '_mbox='+urlencode(mbox)+(page ? '&_page='+page : ''); - this.set_busy(true, 'loading'); - this.http_request('list', url+add_url, true); + var url = '_mbox='+urlencode(mbox)+(page ? '&_page='+page : ''), + lock = this.set_busy(true, 'loading'); + this.http_request('list', url+add_url, lock); }; // removes messages that doesn't exists from list selection array @@ -2159,86 +2240,95 @@ // set message icon this.set_message_icon = function(uid) { - var icn_src, - rows = this.message_list.rows; + var css_class, + row = this.message_list.rows[uid]; - if (!rows[uid]) + if (!row) return false; - if (!rows[uid].unread && rows[uid].unread_children && this.env.unreadchildrenicon) { - icn_src = this.env.unreadchildrenicon; + + if (row.icon) { + css_class = 'msgicon'; + if (row.deleted) + css_class += ' deleted'; + else if (row.unread) + css_class += ' unread'; + else if (row.unread_children) + css_class += ' unreadchildren'; + if (row.msgicon == row.icon) { + if (row.replied) + css_class += ' replied'; + if (row.forwarded) + css_class += ' forwarded'; + css_class += ' status'; + } + + row.icon.className = css_class; } - else if (rows[uid].deleted && this.env.deletedicon) - icn_src = this.env.deletedicon; - else if (rows[uid].replied && this.env.repliedicon) { - if (rows[uid].forwarded && this.env.forwardedrepliedicon) - icn_src = this.env.forwardedrepliedicon; - else - icn_src = this.env.repliedicon; + + if (row.msgicon && row.msgicon != row.icon) { + css_class = 'msgicon'; + if (!row.unread && row.unread_children) + css_class += ' unreadchildren'; + if (row.replied) + css_class += ' replied'; + if (row.forwarded) + css_class += ' forwarded'; + + row.msgicon.className = css_class; } - else if (rows[uid].forwarded && this.env.forwardedicon) - icn_src = this.env.forwardedicon; - else if (rows[uid].unread && this.env.unreadicon) - icn_src = this.env.unreadicon; - else if (this.env.messageicon) - icn_src = this.env.messageicon; - if (icn_src && rows[uid].icon) - rows[uid].icon.src = icn_src; - - icn_src = ''; - - if (rows[uid].flagged && this.env.flaggedicon) - icn_src = this.env.flaggedicon; - else if (!rows[uid].flagged && this.env.unflaggedicon) - icn_src = this.env.unflaggedicon; - if (rows[uid].flagged_icon && icn_src) - rows[uid].flagged_icon.src = icn_src; + if (row.flagicon) { + css_class = (row.flagged ? 'flagged' : 'unflagged'); + row.flagicon.className = css_class; + } }; // set message status this.set_message_status = function(uid, flag, status) { - var rows = this.message_list.rows; + var row = this.message_list.rows[uid]; - if (!rows[uid]) return false; + if (!row) + return false; if (flag == 'unread') - rows[uid].unread = status; + row.unread = status; else if(flag == 'deleted') - rows[uid].deleted = status; + row.deleted = status; else if (flag == 'replied') - rows[uid].replied = status; + row.replied = status; else if (flag == 'forwarded') - rows[uid].forwarded = status; + row.forwarded = status; else if (flag == 'flagged') - rows[uid].flagged = status; + row.flagged = status; }; // set message row status, class and icon this.set_message = function(uid, flag, status) { - var rows = this.message_list.rows; + var row = this.message_list.rows[uid]; - if (!rows[uid]) return false; + if (!row) + return false; if (flag) this.set_message_status(uid, flag, status); - var rowobj = $(rows[uid].obj); + var rowobj = $(row.obj); - if (rows[uid].unread && !rowobj.hasClass('unread')) + if (row.unread && !rowobj.hasClass('unread')) rowobj.addClass('unread'); - else if (!rows[uid].unread && rowobj.hasClass('unread')) + else if (!row.unread && rowobj.hasClass('unread')) rowobj.removeClass('unread'); - if (rows[uid].deleted && !rowobj.hasClass('deleted')) + if (row.deleted && !rowobj.hasClass('deleted')) rowobj.addClass('deleted'); - else if (!rows[uid].deleted && rowobj.hasClass('deleted')) + else if (!row.deleted && rowobj.hasClass('deleted')) rowobj.removeClass('deleted'); - if (rows[uid].flagged && !rowobj.hasClass('flagged')) + if (row.flagged && !rowobj.hasClass('flagged')) rowobj.addClass('flagged'); - else if (!rows[uid].flagged && rowobj.hasClass('flagged')) + else if (!row.flagged && rowobj.hasClass('flagged')) rowobj.removeClass('flagged'); this.set_unread_children(uid); @@ -2270,6 +2360,7 @@ return; var a_uids = [], + lock = this.display_message(this.get_label('copyingmessage'), 'loading'), add_url = '&_target_mbox='+urlencode(mbox)+'&_from='+(this.env.action ? this.env.action : ''); if (this.env.uid) @@ -2282,7 +2373,7 @@ } // send request to server - this.http_post('copy', '_uid='+a_uids.join(',')+'&_mbox='+urlencode(this.env.mailbox)+add_url, false); + this.http_post('copy', '_uid='+a_uids.join(',')+'&_mbox='+urlencode(this.env.mailbox)+add_url, lock); }; // move selected messages to the specified mailbox @@ -2299,9 +2390,8 @@ var add_url = '&_target_mbox='+urlencode(mbox)+'&_from='+(this.env.action ? this.env.action : ''); // show wait message - if (this.env.action=='show') { - lock = true; - this.set_busy(true, 'movingmessage'); + if (this.env.action == 'show') { + lock = this.set_busy(true, 'movingmessage'); } else this.show_contentframe(false); @@ -2334,7 +2424,7 @@ return false; } // if there isn't a defined trash mailbox or we are in it - else if (!this.env.trash_mailbox || this.env.mailbox == this.env.trash_mailbox) + else if (!this.env.trash_mailbox || this.env.mailbox == this.env.trash_mailbox) this.permanently_remove_messages(); // if there is a trash mailbox defined and we're not currently in it else { @@ -2365,7 +2455,7 @@ // @private this._with_selected_messages = function(action, lock, add_url) { - var a_uids = [], count = 0; + var a_uids = [], count = 0, msg; if (this.env.uid) a_uids[0] = this.env.uid; @@ -2395,7 +2485,7 @@ } } - // also send search request to get the right messages + // also send search request to get the right messages if (this.env.search_request) add_url += '&_search='+this.env.search_request; @@ -2409,6 +2499,11 @@ this.delete_excessive_thread_rows(); add_url += '&_uid='+this.uids_to_list(a_uids); + + if (!lock) { + msg = action == 'moveto' ? 'movingmessage' : 'deletingmessage'; + lock = this.display_message(this.get_label(msg), 'loading'); + } // send request to server this.http_post(action, '_mbox='+urlencode(this.env.mailbox)+add_url, lock); @@ -2473,13 +2568,14 @@ for (var i=0; i<a_uids.length; i++) this.set_message(a_uids[i], 'unread', (flag=='unread' ? true : false)); - var url = '_uid='+this.uids_to_list(a_uids)+'&_flag='+flag; + var url = '_uid='+this.uids_to_list(a_uids)+'&_flag='+flag, + lock = this.display_message(this.get_label('markingmessage'), 'loading'); // also send search request to get the right messages if (this.env.search_request) url += '&_search='+this.env.search_request; - this.http_post('mark', url); + this.http_post('mark', url, lock); for (var i=0; i<a_uids.length; i++) this.update_thread_root(a_uids[i], flag); @@ -2492,13 +2588,14 @@ for (var i=0; i<a_uids.length; i++) this.set_message(a_uids[i], 'flagged', (flag=='flagged' ? true : false)); - var url = '_uid='+this.uids_to_list(a_uids)+'&_flag='+flag; + var url = '_uid='+this.uids_to_list(a_uids)+'&_flag='+flag, + lock = this.display_message(this.get_label('markingmessage'), 'loading'); // also send search request to get the right messages if (this.env.search_request) url += '&_search='+this.env.search_request; - this.http_post('mark', url); + this.http_post('mark', url, lock); }; // mark all message rows as deleted/undeleted @@ -2537,13 +2634,14 @@ for (var i=0, len=a_uids.length; i<len; i++) this.set_message(a_uids[i], 'deleted', false); - var url = '_uid='+this.uids_to_list(a_uids)+'&_flag=undelete'; + var url = '_uid='+this.uids_to_list(a_uids)+'&_flag=undelete', + lock = this.display_message(this.get_label('markingmessage'), 'loading'); // also send search request to get the right messages if (this.env.search_request) url += '&_search='+this.env.search_request; - this.http_post('mark', url); + this.http_post('mark', url, lock); return true; }; @@ -2580,7 +2678,8 @@ this.delete_excessive_thread_rows(); } - add_url = '&_from='+(this.env.action ? this.env.action : ''); + add_url = '&_from='+(this.env.action ? this.env.action : ''), + lock = this.display_message(this.get_label('markingmessage'), 'loading'); // ?? if (r_uids.length) @@ -2595,8 +2694,8 @@ if (this.env.search_request) add_url += '&_search='+this.env.search_request; - this.http_post('mark', '_uid='+this.uids_to_list(a_uids)+'&_flag=delete'+add_url); - return true; + this.http_post('mark', '_uid='+this.uids_to_list(a_uids)+'&_flag=delete'+add_url, lock); + return true; }; // flag as read without mark request (called from backend) @@ -2634,8 +2733,7 @@ // lock interface if it's the active mailbox if (mbox == this.env.mailbox) { - lock = true; - this.set_busy(true, 'loading'); + lock = this.set_busy(true, 'loading'); add_url = '&_reload=1'; } @@ -2654,8 +2752,7 @@ // lock interface if it's the active mailbox if (mbox == this.env.mailbox) { - lock = true; - this.set_busy(true, 'loading'); + lock = this.set_busy(true, 'loading'); add_url = '&_reload=1'; } @@ -2704,17 +2801,18 @@ if (!this.gui_objects.messageform) return false; - //this.messageform = this.gui_objects.messageform; - var input_from = $("[name='_from']"); - var input_to = $("[name='_to']"); - var input_subject = $("input[name='_subject']"); - var input_message = $("[name='_message']").get(0); - var html_mode = $("input[name='_is_html']").val() == '1'; + var input_from = $("[name='_from']"), + input_to = $("[name='_to']"), + input_subject = $("input[name='_subject']"), + input_message = $("[name='_message']").get(0), + html_mode = $("input[name='_is_html']").val() == '1', + ac_fields = ['cc', 'bcc', 'replyto', 'mailreplyto', 'mailfollowupto']; // init live search events this.init_address_input_events(input_to); - this.init_address_input_events($("[name='_cc']")); - this.init_address_input_events($("[name='_bcc']")); + for (var i in ac_fields) { + this.init_address_input_events($("[name='_"+ac_fields[i]+"']")); + } if (!html_mode) { this.set_caret_pos(input_message, this.env.top_posting ? 0 : $(input_message).val().length); @@ -2743,9 +2841,8 @@ this.init_address_input_events = function(obj) { - var handler = function(e){ return ref.ksearch_keypress(e,this); }; - obj.bind((bw.safari || bw.ie ? 'keydown' : 'keypress'), handler); - obj.attr('autocomplete', 'off'); + obj[bw.ie || bw.safari || bw.chrome ? 'keydown' : 'keypress'](function(e){ return ref.ksearch_keydown(e, this); }) + .attr('autocomplete', 'off'); }; // checks the input fields before sending a message @@ -2938,8 +3035,10 @@ sig_separator = this.env.sig_above && (this.env.compose_mode == 'reply' || this.env.compose_mode == 'forward') ? '---' : '-- '; // enable manual signature insert - if (this.env.signatures && this.env.signatures[id]) + if (this.env.signatures && this.env.signatures[id]) { this.enable_command('insert-sig', true); + this.env.compose_commands.push('insert-sig'); + } else this.enable_command('insert-sig', false); @@ -3218,12 +3317,12 @@ // reset vars this.env.current_page = 1; - this.set_busy(true, 'searching'); + var lock = this.set_busy(true, 'searching'); this.http_request('search', '_q='+urlencode(value) + (this.env.mailbox ? '&_mbox='+urlencode(this.env.mailbox) : '') + (this.env.source ? '&_source='+urlencode(this.env.source) : '') + (this.env.group ? '&_gid='+urlencode(this.env.group) : '') - + (addurl ? addurl : ''), true); + + (addurl ? addurl : ''), lock); } return true; }; @@ -3240,8 +3339,9 @@ this.sent_successfully = function(type, msg) { - this.list_mailbox(); - this.display_message(msg, type, true); + this.display_message(msg, type); + // before redirect we need to wait some time for Chrome (#1486177) + window.setTimeout(function(){ ref.list_mailbox(); }, 500); }; @@ -3250,7 +3350,7 @@ /*********************************************************/ // handler for keyboard events on address-fields - this.ksearch_keypress = function(e, obj) + this.ksearch_keydown = function(e, obj) { if (this.ksearch_timer) clearTimeout(this.ksearch_timer); @@ -3277,10 +3377,10 @@ return rcube_event.cancel(e); case 9: // tab - if(mod == SHIFT_KEY) + if (mod == SHIFT_KEY) break; - case 13: // enter + case 13: // enter if (this.ksearch_selected===null || !this.ksearch_input || !this.ksearch_value) break; @@ -3326,14 +3426,14 @@ return; // get cursor pos - var inp_value = this.ksearch_input.value; - var cpos = this.get_caret_pos(this.ksearch_input); - var p = inp_value.lastIndexOf(this.ksearch_value, cpos); + var inp_value = this.ksearch_input.value, + cpos = this.get_caret_pos(this.ksearch_input), + p = inp_value.lastIndexOf(this.ksearch_value, cpos), + insert = '', - // replace search string with full address - var pre = this.ksearch_input.value.substring(0, p); - var end = this.ksearch_input.value.substring(p+this.ksearch_value.length, this.ksearch_input.value.length); - var insert = ''; + // replace search string with full address + pre = inp_value.substring(0, p), + end = inp_value.substring(p+this.ksearch_value.length, inp_value.length); // insert all members of a group if (typeof this.env.contacts[id] == 'object' && this.env.contacts[id].id) { @@ -3365,6 +3465,7 @@ this.ksearch_get_results = function() { var inp_value = this.ksearch_input ? this.ksearch_input.value : null; + if (inp_value === null) return; @@ -3372,16 +3473,29 @@ this.ksearch_pane.hide(); // get string from current cursor pos to last comma - var cpos = this.get_caret_pos(this.ksearch_input); - var p = inp_value.lastIndexOf(',', cpos-1); - var q = inp_value.substring(p+1, cpos); + var cpos = this.get_caret_pos(this.ksearch_input), + p = inp_value.lastIndexOf(',', cpos-1), + q = inp_value.substring(p+1, cpos), + min = this.env.autocomplete_min_length; // trim query string - q = q.replace(/(^\s+|\s+$)/g, ''); + q = $.trim(q); // Don't (re-)search if the last results are still active if (q == this.ksearch_value) return; + + if (q.length < min) { + if (!this.env.acinfo) { + var label = this.get_label('autocompletechars'); + label = label.replace('$min', min); + this.env.acinfo = this.display_message(label); + } + return; + } + else if (this.env.acinfo && q.length == min) { + this.hide_message(this.env.acinfo); + } var old_value = this.ksearch_value; this.ksearch_value = q; @@ -3394,8 +3508,8 @@ if (old_value && old_value.length && this.env.contacts && !this.env.contacts.length && q.indexOf(old_value) == 0) return; - this.display_message(this.get_label('searching'), 'loading', false); - this.http_post('autocomplete', '_search='+urlencode(q)); + var lock = this.display_message(this.get_label('searching'), 'loading'); + this.http_post('autocomplete', '_search='+urlencode(q), lock); }; this.ksearch_query_results = function(results, search) @@ -3404,7 +3518,6 @@ if (this.ksearch_value && search != this.ksearch_value) return; - this.hide_message(); this.env.contacts = results ? results : []; this.ksearch_display_results(this.env.contacts); }; @@ -3563,7 +3676,9 @@ this.enable_command('delete', 'compose', false); // send request to server - var url = (src ? '_source='+urlencode(src) : '') + (page ? (src?'&':'') + '_page='+page : ''); + var url = (src ? '_source='+urlencode(src) : '') + (page ? (src?'&':'') + '_page='+page : ''), + lock = this.set_busy(true, 'loading'); + this.env.source = src; this.env.group = group; @@ -3574,8 +3689,7 @@ if (this.env.search_request) url += '&_search='+this.env.search_request; - this.set_busy(true, 'loading'); - this.http_request('list', url, true); + this.http_request('list', url, lock); }; // load contact record @@ -3627,12 +3741,11 @@ } }; - this.delete_contacts = function() { // exit if no mailbox specified or if selection is empty var selection = this.contact_list.get_selection(); - if (!(selection.length || this.env.cid) || (!this.env.group && !confirm(this.get_label('deletecontactconfirm')))) + if (!(selection.length || this.env.cid) || !confirm(this.get_label('deletecontactconfirm'))) return; var id, a_cids = [], qs = ''; @@ -3656,10 +3769,7 @@ qs += '&_search='+this.env.search_request; // send request to server - if (this.env.group) - this.http_post('group-delmembers', '_cid='+urlencode(a_cids.join(','))+'&_source='+urlencode(this.env.source)+'&_gid='+urlencode(this.env.group)+qs); - else - this.http_post('delete', '_cid='+urlencode(a_cids.join(','))+'&_source='+urlencode(this.env.source)+'&_from='+(this.env.action ? this.env.action : '')+qs); + this.http_post('delete', '_cid='+urlencode(a_cids.join(','))+'&_source='+urlencode(this.env.source)+'&_from='+(this.env.action ? this.env.action : '')+qs); return true; }; @@ -3717,7 +3827,6 @@ this.enable_command('export', (this.contact_list.rowcount > 0)); }; - this.group_create = function() { @@ -3787,11 +3896,11 @@ var newname = this.name_input.val(); if (newname) { - this.set_busy(true, 'loading'); + var lock = this.set_busy(true, 'loading'); if (this.env.group_renaming) - this.http_post('group-rename', '_source='+urlencode(this.env.source)+'&_gid='+urlencode(this.env.group)+'&_name='+urlencode(newname), true); + this.http_post('group-rename', '_source='+urlencode(this.env.source)+'&_gid='+urlencode(this.env.group)+'&_name='+urlencode(newname), lock); else - this.http_post('group-create', '_source='+urlencode(this.env.source)+'&_name='+urlencode(newname), true); + this.http_post('group-create', '_source='+urlencode(this.env.source)+'&_name='+urlencode(newname), lock); } return false; } @@ -3852,7 +3961,7 @@ if (li && (link = li.firstChild) && link.tagName.toLowerCase() == 'a') link.innerHTML = prop.name; - this.env.contactfolders[key].name = this.env.contactgroups[key].name = name; + this.env.contactfolders[key].name = this.env.contactgroups[key].name = prop.name; this.triggerEvent('group_update', { id:prop.id, source:prop.source, name:prop.name, li:li[0] }); }; @@ -3947,7 +4056,8 @@ this.focus_subscription = function(id) { var row, folder, - reg = RegExp('['+RegExp.escape(this.env.delimiter)+']?[^'+RegExp.escape(this.env.delimiter)+']+$'); + delim = RegExp.escape(this.env.delimiter), + reg = RegExp('['+delim+']?[^'+delim+']+$'); if (this.drag_active && this.env.folder && (row = document.getElementById(id))) if (this.env.subscriptionrows[id] && @@ -3960,7 +4070,7 @@ $(row).addClass('droptarget'); } } - else if (this.env.folder.match(new RegExp(RegExp.escape(this.env.delimiter)))) { + else if (this.env.folder.match(new RegExp(delim))) { this.set_env('dstfolder', this.env.delimiter); $(this.subscription_list.frame).addClass('droptarget'); } @@ -3993,15 +4103,17 @@ this.subscription_move_folder = function(list) { - var reg = RegExp('['+RegExp.escape(this.env.delimiter)+']?[^'+RegExp.escape(this.env.delimiter)+']+$'); + var delim = RegExp.escape(this.env.delimiter), + reg = RegExp('['+delim+']?[^'+delim+']+$'); + if (this.env.folder && this.env.dstfolder && (this.env.dstfolder != this.env.folder) && (this.env.dstfolder != this.env.folder.replace(reg, ''))) { - var reg = new RegExp('[^'+RegExp.escape(this.env.delimiter)+']*['+RegExp.escape(this.env.delimiter)+']', 'g'); + var reg = new RegExp('[^'+delim+']*['+delim+']', 'g'); var basename = this.env.folder.replace(reg, ''); var newname = this.env.dstfolder==this.env.delimiter ? basename : this.env.dstfolder+this.env.delimiter+basename; - this.set_busy(true, 'foldermoving'); - this.http_post('rename-folder', '_folder_oldname='+urlencode(this.env.folder)+'&_folder_newname='+urlencode(newname), true); + var lock = this.set_busy(true, 'foldermoving'); + this.http_post('rename-folder', '_folder_oldname='+urlencode(this.env.folder)+'&_folder_newname='+urlencode(newname), lock); } this.drag_active = false; this.unfocus_subscription(this.get_folder_row_id(this.env.dstfolder)); @@ -4025,8 +4137,8 @@ if (this.env.folder && name != '') name = this.env.folder+this.env.delimiter+name; - this.set_busy(true, 'foldercreating'); - this.http_post('create-folder', '_name='+urlencode(name), true); + var lock = this.set_busy(true, 'foldercreating'); + this.http_post('create-folder', '_name='+urlencode(name), lock); } else if (form.elements['_folder_name']) form.elements['_folder_name'].focus(); @@ -4046,12 +4158,14 @@ } if (id && this.env.subscriptionrows[id] && (row = document.getElementById(id))) { - var reg = new RegExp('.*['+RegExp.escape(this.env.delimiter)+']'); + var delim = RegExp.escape(this.env.delimiter), + reg = new RegExp('.*['+delim+']'); + this.name_input = document.createElement('input'); this.name_input.type = 'text'; this.name_input.value = this.env.subscriptionrows[id][0].replace(reg, ''); - reg = new RegExp('['+RegExp.escape(this.env.delimiter)+']?[^'+RegExp.escape(this.env.delimiter)+']+$'); + reg = new RegExp('['+delim+']?[^'+delim+']+$'); this.name_input.__parent = this.env.subscriptionrows[id][0].replace(reg, ''); this.name_input.onkeydown = function(e){ rcmail.name_input_keydown(e); }; @@ -4092,8 +4206,8 @@ if (this.name_input.__parent) newname = this.name_input.__parent + this.env.delimiter + newname; - this.set_busy(true, 'folderrenaming'); - this.http_post('rename-folder', '_folder_oldname='+urlencode(this.env.subscriptionrows[this.edit_folder][0])+'&_folder_newname='+urlencode(newname), true); + var lock = this.set_busy(true, 'folderrenaming'); + this.http_post('rename-folder', '_folder_oldname='+urlencode(this.env.subscriptionrows[this.edit_folder][0])+'&_folder_newname='+urlencode(newname), lock); } } // escape @@ -4110,8 +4224,8 @@ this.reset_folder_rename(); if (folder && confirm(this.get_label('deletefolderconfirm'))) { - this.set_busy(true, 'folderdeleting'); - this.http_post('delete-folder', '_mboxes='+urlencode(folder), true); + var lock = this.set_busy(true, 'folderdeleting'); + this.http_post('delete-folder', '_mboxes='+urlencode(folder), lock); this.set_env('folder', null); $(this.gui_objects.createfolderhint).html(''); @@ -4480,61 +4594,80 @@ document.title = title; }; - // display a system message - this.display_message = function(msg, type, hold) + // display a system message, list of types in common.css (below #message definition) + this.display_message = function(msg, type) { - if (!this.loaded) { - // save message in order to display after page loaded - this.pending_message = new Array(msg, type); - return true; - } - // pass command to parent window if (this.env.framed && parent.rcmail) - return parent.rcmail.display_message(msg, type, hold); + return parent.rcmail.display_message(msg, type); - if (!this.gui_objects.message) + if (!this.gui_objects.message) { + // save message in order to display after page loaded + if (type != 'loading') + this.pending_message = new Array(msg, type); return false; + } - if (this.message_timer) - clearTimeout(this.message_timer); + type = type ? type : 'notice'; - var cont = msg; - if (type) - cont = '<div class="'+type+'">'+cont+'</div>'; + var date = new Date(), + id = type + date.getTime(); - var obj = $(this.gui_objects.message).html(cont).show(); - this.gui_objects.message.__type = type; + if (type == 'loading') { + if (!msg) + msg = this.get_label('loading'); - if (type!='loading') - obj.bind('mousedown', function(){ ref.hide_message(); return true; }); + // The same message of type 'loading' is already displayed + if (this.messages[msg]) { + this.messages[msg].elements.push(id); + return id; + } + } - if (!hold) - this.message_timer = window.setTimeout(function(){ ref.hide_message(true); }, this.message_time); - }; + var ref = this, + obj = $('<div>').addClass(type).html(msg), + cont = $(this.gui_objects.message).show(); - // make a message row disapear - this.hide_message = function(fade) - { - var msg; - if (this.gui_objects.message) - msg = this.gui_objects.message; - else if (this.env.framed && parent.rcmail) - msg = parent.rcmail.gui_objects.message; - - if (msg) { - $(msg).unbind()[(fade?'fadeOut':'hide')](); - msg.__type = null; + if (type == 'loading') { + obj.appendTo(cont); + this.messages[msg] = {'obj': obj, 'elements': [id]}; + window.setTimeout(function() { rcmail.hide_message(id); }, this.env.request_timeout * 1000); + return id; + } + else { + obj.appendTo(cont).bind('mousedown', function() { return ref.hide_message(obj); }); + window.setTimeout(function() { ref.hide_message(obj, true); }, + this.message_time * (type == 'error' ? 2 : 1)); + return obj; } }; - // get type of currently displayed message - this.message_type = function() + // make a message to disapear + this.hide_message = function(obj, fade) { - if (this.gui_objects.message) - return this.gui_objects.message.__type; - else if (this.env.framed && parent.rcmail && parent.rcmail.gui_objects.message) - return parent.rcmail.gui_objects.message.__type; + // pass command to parent window + if (this.env.framed && parent.rcmail) + return parent.rcmail.hide_message(obj, fade); + + if (typeof(obj) == 'object') { + // custom message + $(obj)[fade?'fadeOut':'hide'](); + } + else { + // 'loading' message + var k, n, m = this.messages; + for (k in m) { + for (n in m[k].elements) { + if (m[k] && m[k].elements[n] == obj) { + m[k].elements.splice(n, 1); + if (!m[k].elements.length) { + m[k].obj[fade?'fadeOut':'hide'](); + delete m[k]; + } + } + } + } + } }; // mark a mailbox as selected and set environment variable @@ -4612,6 +4745,7 @@ this.env.subject_col = null; this.env.flagged_col = null; + this.env.status_col = null; if ((n = $.inArray('subject', this.env.coltypes)) >= 0) { this.set_env('subject_col', n); @@ -4620,6 +4754,8 @@ } if ((n = $.inArray('flag', this.env.coltypes)) >= 0) this.set_env('flagged_col', n); + if ((n = $.inArray('status', this.env.coltypes)) >= 0) + this.set_env('status_col', n); this.message_list.init_header(); }; @@ -4743,14 +4879,8 @@ // display fetched raw headers this.set_headers = function(content) { - if (this.gui_objects.all_headers_row && this.gui_objects.all_headers_box && content) { + if (this.gui_objects.all_headers_row && this.gui_objects.all_headers_box && content) $(this.gui_objects.all_headers_box).html(content).show(); - - if (this.env.framed && parent.rcmail) - parent.rcmail.set_busy(false); - else - this.set_busy(false); - } }; // display all-headers row and fetch raw message headers @@ -4765,8 +4895,8 @@ // fetch headers only once if (!this.gui_objects.all_headers_box.innerHTML) { - this.display_message(this.get_label('loading'), 'loading', true); - this.http_post('headers', '_uid='+this.env.uid); + var lock = this.display_message(this.get_label('loading'), 'loading'); + this.http_post('headers', '_uid='+this.env.uid, lock); } }; @@ -4851,22 +4981,22 @@ this.html2plain = function(htmlText, id) { var rcmail = this, - url = '?_task=utils&_action=html2text'; + url = '?_task=utils&_action=html2text', + lock = this.set_busy(true, 'converting'); - this.set_busy(true, 'converting'); console.log('HTTP POST: ' + url); $.ajax({ type: 'POST', url: url, data: htmlText, contentType: 'application/octet-stream', - error: function(o) { rcmail.http_error(o); }, - success: function(data) { rcmail.set_busy(false); $(document.getElementById(id)).val(data); console.log(data); } + error: function(o, status, err) { rcmail.http_error(o, status, err, lock); }, + success: function(data) { rcmail.set_busy(false, null, lock); $(document.getElementById(id)).val(data); console.log(data); } }); }; this.plain2html = function(plainText, id) { - this.set_busy(true, 'converting'); + var lock = this.set_busy(true, 'converting'); $(document.getElementById(id)).val('<pre>'+plainText+'</pre>'); - this.set_busy(false); + this.set_busy(false, null, lock); }; @@ -4925,7 +5055,11 @@ // send request console.log('HTTP GET: ' + url); - $.get(url, { _unlock:(lock?1:0) }, function(data){ ref.http_response(data); }, 'json'); + $.ajax({ + type: 'GET', url: url, data: { _unlock:(lock?lock:0) }, dataType: 'json', + success: function(data){ ref.http_response(data); }, + error: function(o, status, err) { rcmail.http_error(o, status, err, lock); } + }); }; // send a http POST request to the server @@ -4943,10 +5077,10 @@ if (postdata && typeof(postdata) == 'object') { postdata._remote = 1; - postdata._unlock = (lock ? 1 : 0); + postdata._unlock = (lock ? lock : 0); } else - postdata += (postdata ? '&' : '') + '_remote=1' + (lock ? '&_unlock=1' : ''); + postdata += (postdata ? '&' : '') + '_remote=1' + (lock ? '&_unlock='+lock : ''); // trigger plugin hook var result = this.triggerEvent('request'+action, postdata); @@ -4960,12 +5094,19 @@ // send request console.log('HTTP POST: ' + url); - $.post(url, postdata, function(data){ ref.http_response(data); }, 'json'); + $.ajax({ + type: 'POST', url: url, data: postdata, dataType: 'json', + success: function(data){ ref.http_response(data); }, + error: function(o, status, err) { rcmail.http_error(o, status, err, lock); } + }); }; // handle HTTP response this.http_response = function(response) { + if (!response) + return; + if (response.unlock) this.set_busy(false); @@ -5009,6 +5150,8 @@ if (this.env.action == 'show') { // re-enable commands on move/delete error this.enable_command(this.env.message_commands, true); + if (!this.env.list_post) + this.enable_command('reply-list', false); } else if (this.task == 'addressbook') { this.triggerEvent('listupdate', { folder:this.env.source, rowcount:this.contact_list.rowcount }); @@ -5058,16 +5201,19 @@ break; } + if (response.unlock) + this.hide_message(response.unlock); + this.triggerEvent('responseafter', {response: response}); this.triggerEvent('responseafter'+response.action, {response: response}); }; // handle HTTP request errors - this.http_error = function(request, status, err) + this.http_error = function(request, status, err, lock) { var errmsg = request.statusText; - this.set_busy(false); + this.set_busy(false, null, lock); request.abort(); if (errmsg) @@ -5099,10 +5245,10 @@ if (this.busy) return; - var addurl = '_t=' + (new Date().getTime()) + '&_mbox=' + urlencode(this.env.mailbox); + var lock, addurl = '_t=' + (new Date().getTime()) + '&_mbox=' + urlencode(this.env.mailbox); if (refresh) { - this.set_busy(true, 'checkingmail'); + lock = this.set_busy(true, 'checkingmail'); addurl += '&_refresh=1'; // reset check-recent interval this.start_keepalive(); @@ -5115,7 +5261,7 @@ if (this.env.search_request) addurl += '&_search=' + this.env.search_request; - this.http_request('check-recent', addurl, true); + this.http_request('check-recent', addurl, lock); }; -- Gitblit v1.9.1