From 275dccfca1d7541b6e543e846691160f81e5ce58 Mon Sep 17 00:00:00 2001 From: thomascube <thomas@roundcube.net> Date: Wed, 06 Oct 2010 04:00:36 -0400 Subject: [PATCH] Tagging files of release 0.4.1 --- installer/test.php | 61 ++++++++++++++++-------------- 1 files changed, 32 insertions(+), 29 deletions(-) diff --git a/installer/test.php b/installer/test.php index 5740a64..45de5e8 100644 --- a/installer/test.php +++ b/installer/test.php @@ -88,18 +88,18 @@ ?> <h3>Check if directories are writable</h3> -<p>RoundCube may need to write/save files into these directories</p> +<p>Roundcube may need to write/save files into these directories</p> <?php if ($RCI->configured) { $pass = false; - $dirs[] = $RCI->config['temp_dir']; + $dirs[] = $RCI->config['temp_dir'] ? $RCI->config['temp_dir'] : 'temp'; if($RCI->config['log_driver'] != 'syslog') - $dirs[] = $RCI->config['log_dir']; + $dirs[] = $RCI->config['log_dir'] ? $RCI->config['log_dir'] : 'logs'; foreach ($dirs as $dir) { - $dirpath = $dir{0} == '/' ? $dir : INSTALL_PATH . $dir; + $dirpath = $dir[0] == '/' ? $dir : INSTALL_PATH . $dir; if (is_writable(realpath($dirpath))) { $RCI->pass($dir); $pass = true; @@ -119,7 +119,7 @@ ?> -<h3>Check configured database settings</h3> +<h3>Check DB config</h3> <?php $db_working = false; @@ -164,15 +164,14 @@ echo '<p><input type="submit" name="initdb" value="Initialize database" /></p>'; $db_working = false; } - /* - else if (!$RCI->db_schema_check($update = !empty($_POST['updatedb']))) { + else if ($RCI->db_schema_check($DB, $update = !empty($_POST['updatedb']))) { $RCI->fail('DB Schema', "Database schema differs"); - - echo $update ? '<p class="warning">Failed to update the database schema! Please manually execute the SQL statements from the SQL/*.update.sql file on your database</p>' : - '<p><input type="submit" name="updatedb" value="Update schema now" /></p>'; + $db_map = array('pgsql' => 'postgres', 'mysqli' => 'mysql', 'sqlsrv' => 'mssql'); + $updatefile = INSTALL_PATH . 'SQL/' . (isset($db_map[$DB->db_provider]) ? $db_map[$DB->db_provider] : $DB->db_provider) . '.update.sql'; + echo '<p class="warning">Please manually execute the SQL statements from '.$updatefile.' on your database.<br/>'; + echo 'See comments in the file and execute queries that are superscribed with the currently installed version number.</p>'; $db_working = false; } - */ else { $RCI->pass('DB Schema'); echo '<br />'; @@ -213,10 +212,10 @@ ?> -<h3>Test SMTP settings</h3> +<h3>Test SMTP config</h3> <p> -Server: <?php echo $RCI->getprop('smtp_server', 'PHP mail()'); ?><br /> +Server: <?php echo rcube_parse_host($RCI->getprop('smtp_server', 'PHP mail()')); ?><br /> Port: <?php echo $RCI->getprop('smtp_port'); ?><br /> <?php @@ -246,28 +245,26 @@ <?php -if (isset($_POST['sendmail']) && !empty($_POST['_from']) && !empty($_POST['_to'])) { - - require_once 'rcube_smtp.inc'; - +if (isset($_POST['sendmail'])) { + echo '<p>Trying to send email...<br />'; - + if (preg_match('/^' . $RCI->email_pattern . '$/i', trim($_POST['_from'])) && preg_match('/^' . $RCI->email_pattern . '$/i', trim($_POST['_to']))) { - + $headers = array( 'From' => trim($_POST['_from']), 'To' => trim($_POST['_to']), - 'Subject' => 'Test message from RoundCube', + 'Subject' => 'Test message from Roundcube', ); - $body = 'This is a test to confirm that RoundCube can send email.'; + $body = 'This is a test to confirm that Roundcube can send email.'; $smtp_response = array(); // send mail using configured SMTP server if ($RCI->getprop('smtp_server')) { $CONFIG = $RCI->config; - + if (!empty($_POST['_smtp_user'])) { $CONFIG['smtp_user'] = $_POST['_smtp_user']; } @@ -275,12 +272,17 @@ $CONFIG['smtp_pass'] = $_POST['_smtp_pass']; } - $mail_object = new rcube_mail_mime(); + $mail_object = new Mail_mime(); $send_headers = $mail_object->headers($headers); - - $status = smtp_mail($headers['From'], $headers['To'], - ($foo = $mail_object->txtHeaders($send_headers)), - $body, $smtp_response); + + $SMTP = new rcube_smtp(); + $SMTP->connect(rcube_parse_host($RCI->getprop('smtp_server')), + $RCI->getprop('smtp_port'), $CONFIG['smtp_user'], $CONFIG['smtp_pass']); + + $status = $SMTP->send_mail($headers['From'], $headers['To'], + ($foo = $mail_object->txtHeaders($send_headers)), $body); + + $smtp_response = $SMTP->get_response(); } else { // use mail() $header_str = 'From: ' . $headers['From']; @@ -326,7 +328,7 @@ <p><input type="submit" name="sendmail" value="Send test mail" /></p> -<h3>Test IMAP configuration</h3> +<h3>Test IMAP config</h3> <?php @@ -403,7 +405,8 @@ <p class="warning"> After completing the installation and the final tests please <b>remove</b> the whole -installer folder from the document root of the webserver.<br /> +installer folder from the document root of the webserver or make sure that +enable_installer option in main.inc.php is disabled.<br /> <br /> These files may expose sensitive configuration data like server passwords and encryption keys -- Gitblit v1.9.1