From 03aa84f78412d350f3e8721257251baf948bc7b6 Mon Sep 17 00:00:00 2001 From: Aleksander Machniak <alec@alec.pl> Date: Sun, 17 May 2015 08:52:24 -0400 Subject: [PATCH] Fix bug where some files could have "executable" extension when stored in temp folder (#1490377) --- program/include/rcmail.php | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/program/include/rcmail.php b/program/include/rcmail.php index 2a154d9..e3e45e2 100644 --- a/program/include/rcmail.php +++ b/program/include/rcmail.php @@ -2073,16 +2073,15 @@ if (!empty($_GET['_thumbnail'])) { $temp_dir = $this->config->get('temp_dir'); $thumbnail_size = 80; - list(,$ext) = explode('/', $file['mimetype']); $mimetype = $file['mimetype']; $file_ident = $file['id'] . ':' . $file['mimetype'] . ':' . $file['size']; $cache_basename = $temp_dir . '/' . md5($file_ident . ':' . $this->user->ID . ':' . $thumbnail_size); - $cache_file = $cache_basename . '.' . $ext; + $cache_file = $cache_basename . '.thumb'; // render thumbnail image if not done yet if (!is_file($cache_file)) { if (!$file['path']) { - $orig_name = $filename = $cache_basename . '.orig.' . $ext; + $orig_name = $filename = $cache_basename . '.tmp'; file_put_contents($orig_name, $file['data']); } else { -- Gitblit v1.9.1