From ddcebbd982d81dabf8cb1c89f60f9b876a23b58c Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Thu, 04 Sep 2014 13:32:44 -0400 Subject: [PATCH] Merged #149 "Repo creation with initial commit fails if user does not have an email address" --- src/main/java/com/gitblit/servlet/EnforceAuthenticationFilter.java | 32 +++++++++----------------------- 1 files changed, 9 insertions(+), 23 deletions(-) diff --git a/src/main/java/com/gitblit/servlet/EnforceAuthenticationFilter.java b/src/main/java/com/gitblit/servlet/EnforceAuthenticationFilter.java index 6655c6e..c015021 100644 --- a/src/main/java/com/gitblit/servlet/EnforceAuthenticationFilter.java +++ b/src/main/java/com/gitblit/servlet/EnforceAuthenticationFilter.java @@ -18,9 +18,6 @@ import java.io.IOException; import java.text.MessageFormat; -import javax.inject.Inject; -import javax.inject.Singleton; -import javax.servlet.Filter; import javax.servlet.FilterChain; import javax.servlet.FilterConfig; import javax.servlet.ServletException; @@ -34,10 +31,11 @@ import com.gitblit.IStoredSettings; import com.gitblit.Keys; -import com.gitblit.Keys.web; -import com.gitblit.manager.IRuntimeManager; +import com.gitblit.dagger.DaggerFilter; import com.gitblit.manager.IAuthenticationManager; import com.gitblit.models.UserModel; + +import dagger.ObjectGraph; /** * This filter enforces authentication via HTTP Basic Authentication, if the settings indicate so. @@ -47,30 +45,18 @@ * @author Laurens Vrijnsen * */ -@Singleton -public class EnforceAuthenticationFilter implements Filter { +public class EnforceAuthenticationFilter extends DaggerFilter { protected transient Logger logger = LoggerFactory.getLogger(getClass()); - private final IStoredSettings settings; + private IStoredSettings settings; - private final IAuthenticationManager authenticationManager; + private IAuthenticationManager authenticationManager; - @Inject - public EnforceAuthenticationFilter( - IRuntimeManager runtimeManager, - IAuthenticationManager authenticationManager) { - - super(); - this.settings = runtimeManager.getSettings(); - this.authenticationManager = authenticationManager; - } - - /* - * @see javax.servlet.Filter#init(javax.servlet.FilterConfig) - */ @Override - public void init(FilterConfig filterConfig) throws ServletException { + protected void inject(ObjectGraph dagger, FilterConfig filterConfig) { + this.settings = dagger.get(IStoredSettings.class); + this.authenticationManager = dagger.get(IAuthenticationManager.class); } /* -- Gitblit v1.9.1