From dbd9e1538976518e8514961f4dc7d0771eb6634b Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Mon, 17 Nov 2014 09:06:34 -0500 Subject: [PATCH] Merged #88 "Image diff could display before & after images" --- src/main/java/com/gitblit/wicket/pages/BlobDiffPage.java | 20 ++++++++++++++++++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/gitblit/wicket/pages/BlobDiffPage.java b/src/main/java/com/gitblit/wicket/pages/BlobDiffPage.java index 9cc3eae..71516ec 100644 --- a/src/main/java/com/gitblit/wicket/pages/BlobDiffPage.java +++ b/src/main/java/com/gitblit/wicket/pages/BlobDiffPage.java @@ -15,12 +15,15 @@ */ package com.gitblit.wicket.pages; +import java.util.List; + import org.apache.wicket.PageParameters; import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.link.BookmarkablePageLink; import org.eclipse.jgit.lib.Repository; import org.eclipse.jgit.revwalk.RevCommit; +import com.gitblit.Keys; import com.gitblit.utils.DiffUtils; import com.gitblit.utils.DiffUtils.DiffOutputType; import com.gitblit.utils.JGitUtils; @@ -43,16 +46,29 @@ Repository r = getRepository(); RevCommit commit = getCommit(); + final List<String> imageExtensions = app().settings().getStrings(Keys.web.imageExtensions); + String diff; if (StringUtils.isEmpty(baseObjectId)) { // use first parent - diff = DiffUtils.getDiff(r, commit, blobPath, DiffOutputType.HTML).content; + RevCommit parent = commit.getParentCount() == 0 ? null : commit.getParent(0); + ImageDiffHandler handler = new ImageDiffHandler(getContextUrl(), repositoryName, + parent.getName(), commit.getName(), imageExtensions); + diff = DiffUtils.getDiff(r, commit, blobPath, DiffOutputType.HTML, handler).content; + if (handler.getImgDiffCount() > 0) { + addBottomScript("scripts/imgdiff.js"); // Tiny support script for image diffs + } add(new BookmarkablePageLink<Void>("patchLink", PatchPage.class, WicketUtils.newPathParameter(repositoryName, objectId, blobPath))); } else { // base commit specified RevCommit baseCommit = JGitUtils.getCommit(r, baseObjectId); - diff = DiffUtils.getDiff(r, baseCommit, commit, blobPath, DiffOutputType.HTML).content; + ImageDiffHandler handler = new ImageDiffHandler(getContextUrl(), repositoryName, + baseCommit.getName(), commit.getName(), imageExtensions); + diff = DiffUtils.getDiff(r, baseCommit, commit, blobPath, DiffOutputType.HTML, handler).content; + if (handler.getImgDiffCount() > 0) { + addBottomScript("scripts/imgdiff.js"); // Tiny support script for image diffs + } add(new BookmarkablePageLink<Void>("patchLink", PatchPage.class, WicketUtils.newBlobDiffParameter(repositoryName, baseObjectId, objectId, blobPath))); -- Gitblit v1.9.1