From db91a34ccb5135f733c7431fdba49669131e97da Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Sat, 19 Nov 2011 07:33:59 -0500
Subject: [PATCH] Reorganizing the recent activity feature

---
 tests/com/gitblit/tests/JGitUtilsTest.java |   42 +++++++++++++++++++++++-------------------
 1 files changed, 23 insertions(+), 19 deletions(-)

diff --git a/tests/com/gitblit/tests/JGitUtilsTest.java b/tests/com/gitblit/tests/JGitUtilsTest.java
index 44d7254..7cd79ad 100644
--- a/tests/com/gitblit/tests/JGitUtilsTest.java
+++ b/tests/com/gitblit/tests/JGitUtilsTest.java
@@ -17,6 +17,7 @@
 
 import java.io.File;
 import java.io.FileOutputStream;
+import java.text.SimpleDateFormat;
 import java.util.Arrays;
 import java.util.Date;
 import java.util.List;
@@ -42,7 +43,6 @@
 import com.gitblit.models.PathModel.PathChangeModel;
 import com.gitblit.models.RefModel;
 import com.gitblit.utils.JGitUtils;
-import com.gitblit.utils.JGitUtils.SearchType;
 import com.gitblit.utils.StringUtils;
 
 public class JGitUtilsTest extends TestCase {
@@ -199,7 +199,7 @@
 	}
 
 	public void testCreateOrphanedBranch() throws Exception {
-		Repository repository = JGitUtils.createRepository(GitBlitSuite.REPOSITORIES, "orphantest");		
+		Repository repository = JGitUtils.createRepository(GitBlitSuite.REPOSITORIES, "orphantest");
 		assertTrue(JGitUtils.createOrphanBranch(repository,
 				"x" + Long.toHexString(System.currentTimeMillis()).toUpperCase()));
 		FileUtils.delete(repository.getDirectory(), FileUtils.RECURSIVE);
@@ -288,55 +288,59 @@
 	public void testRevlog() throws Exception {
 		assertTrue(JGitUtils.getRevLog(null, 0).size() == 0);
 		List<RevCommit> commits = JGitUtils.getRevLog(null, 10);
-		assertTrue(commits.size() == 0);
+		assertEquals(0, commits.size());
 
 		Repository repository = GitBlitSuite.getHelloworldRepository();
 		// get most recent 10 commits
 		commits = JGitUtils.getRevLog(repository, 10);
-		assertTrue(commits.size() == 10);
+		assertEquals(10, commits.size());
 
 		// test paging and offset by getting the 10th most recent commit
 		RevCommit lastCommit = JGitUtils.getRevLog(repository, null, 9, 1).get(0);
-		assertTrue(commits.get(9).equals(lastCommit));
+		assertEquals(lastCommit, commits.get(9));
 
 		// grab the two most recent commits to java.java
 		commits = JGitUtils.getRevLog(repository, null, "java.java", 0, 2);
-		assertTrue(commits.size() == 2);
+		assertEquals(2, commits.size());
+		
+		// grab the commits since 2008-07-15
+		commits = JGitUtils.getRevLog(repository, null, new SimpleDateFormat("yyyy-MM-dd").parse("2008-07-15"));
+		assertEquals(12, commits.size());
 		repository.close();
 	}
 
 	public void testSearchTypes() throws Exception {
-		assertTrue(SearchType.forName("commit").equals(SearchType.COMMIT));
-		assertTrue(SearchType.forName("committer").equals(SearchType.COMMITTER));
-		assertTrue(SearchType.forName("author").equals(SearchType.AUTHOR));
-		assertTrue(SearchType.forName("unknown").equals(SearchType.COMMIT));
+		assertTrue(com.gitblit.Constants.SearchType.forName("commit").equals(com.gitblit.Constants.SearchType.COMMIT));
+		assertTrue(com.gitblit.Constants.SearchType.forName("committer").equals(com.gitblit.Constants.SearchType.COMMITTER));
+		assertTrue(com.gitblit.Constants.SearchType.forName("author").equals(com.gitblit.Constants.SearchType.AUTHOR));
+		assertTrue(com.gitblit.Constants.SearchType.forName("unknown").equals(com.gitblit.Constants.SearchType.COMMIT));
 
-		assertTrue(SearchType.COMMIT.toString().equals("commit"));
-		assertTrue(SearchType.COMMITTER.toString().equals("committer"));
-		assertTrue(SearchType.AUTHOR.toString().equals("author"));
+		assertTrue(com.gitblit.Constants.SearchType.COMMIT.toString().equals("commit"));
+		assertTrue(com.gitblit.Constants.SearchType.COMMITTER.toString().equals("committer"));
+		assertTrue(com.gitblit.Constants.SearchType.AUTHOR.toString().equals("author"));
 	}
 
 	public void testSearchRevlogs() throws Exception {
-		assertTrue(JGitUtils.searchRevlogs(null, null, "java", SearchType.COMMIT, 0, 0).size() == 0);
-		List<RevCommit> results = JGitUtils.searchRevlogs(null, null, "java", SearchType.COMMIT, 0,
+		assertTrue(JGitUtils.searchRevlogs(null, null, "java", com.gitblit.Constants.SearchType.COMMIT, 0, 0).size() == 0);
+		List<RevCommit> results = JGitUtils.searchRevlogs(null, null, "java", com.gitblit.Constants.SearchType.COMMIT, 0,
 				3);
 		assertTrue(results.size() == 0);
 
 		// test commit message search
 		Repository repository = GitBlitSuite.getHelloworldRepository();
-		results = JGitUtils.searchRevlogs(repository, null, "java", SearchType.COMMIT, 0, 3);
+		results = JGitUtils.searchRevlogs(repository, null, "java", com.gitblit.Constants.SearchType.COMMIT, 0, 3);
 		assertTrue(results.size() == 3);
 
 		// test author search
-		results = JGitUtils.searchRevlogs(repository, null, "timothy", SearchType.AUTHOR, 0, -1);
+		results = JGitUtils.searchRevlogs(repository, null, "timothy", com.gitblit.Constants.SearchType.AUTHOR, 0, -1);
 		assertTrue(results.size() == 1);
 
 		// test committer search
-		results = JGitUtils.searchRevlogs(repository, null, "mike", SearchType.COMMITTER, 0, 10);
+		results = JGitUtils.searchRevlogs(repository, null, "mike", com.gitblit.Constants.SearchType.COMMITTER, 0, 10);
 		assertTrue(results.size() == 10);
 
 		// test paging and offset
-		RevCommit commit = JGitUtils.searchRevlogs(repository, null, "mike", SearchType.COMMITTER,
+		RevCommit commit = JGitUtils.searchRevlogs(repository, null, "mike", com.gitblit.Constants.SearchType.COMMITTER,
 				9, 1).get(0);
 		assertTrue(results.get(9).equals(commit));
 

--
Gitblit v1.9.1