From cb285cbfddfc0b633d6b8cdb4dc0d2bd2b8b51ef Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Thu, 05 Jan 2012 17:34:05 -0500 Subject: [PATCH] Fixed bug in receive hook for repositories in subfolders --- src/com/gitblit/utils/RpcUtils.java | 171 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 163 insertions(+), 8 deletions(-) diff --git a/src/com/gitblit/utils/RpcUtils.java b/src/com/gitblit/utils/RpcUtils.java index faa910b..02a63a4 100644 --- a/src/com/gitblit/utils/RpcUtils.java +++ b/src/com/gitblit/utils/RpcUtils.java @@ -24,12 +24,15 @@ import com.gitblit.Constants; import com.gitblit.Constants.RpcRequest; +import com.gitblit.GitBlitException.UnknownRequestException; import com.gitblit.models.FederationModel; import com.gitblit.models.FederationProposal; import com.gitblit.models.FederationSet; +import com.gitblit.models.FeedModel; import com.gitblit.models.RepositoryModel; import com.gitblit.models.ServerSettings; import com.gitblit.models.ServerStatus; +import com.gitblit.models.TeamModel; import com.gitblit.models.UserModel; import com.google.gson.reflect.TypeToken; @@ -51,6 +54,9 @@ }.getType(); private static final Type USERS_TYPE = new TypeToken<Collection<UserModel>>() { + }.getType(); + + private static final Type TEAMS_TYPE = new TypeToken<Collection<TeamModel>>() { }.getType(); private static final Type REGISTRATIONS_TYPE = new TypeToken<Collection<FederationModel>>() { @@ -95,7 +101,28 @@ req = RpcRequest.LIST_REPOSITORIES; } return remoteURL + Constants.RPC_PATH + "?req=" + req.name().toLowerCase() - + (name == null ? "" : ("&name=" + name)); + + (name == null ? "" : ("&name=" + StringUtils.encodeURL(name))); + } + + /** + * Returns the version of the RPC protocol on the server. + * + * @param serverUrl + * @param account + * @param password + * @return the protocol version + * @throws IOException + */ + public static int getProtocolVersion(String serverUrl, String account, char[] password) + throws IOException { + String url = asLink(serverUrl, RpcRequest.GET_PROTOCOL); + int protocol = 1; + try { + protocol = JsonUtils.retrieveJson(url, Integer.class, account, password); + } catch (UnknownRequestException e) { + // v0.7.0 (protocol 1) did not have this request type + } + return protocol; } /** @@ -134,6 +161,24 @@ } /** + * Tries to pull the gitblit team definitions from the remote gitblit + * instance. + * + * @param serverUrl + * @param account + * @param password + * @return a collection of UserModel objects + * @throws IOException + */ + public static List<TeamModel> getTeams(String serverUrl, String account, char[] password) + throws IOException { + String url = asLink(serverUrl, RpcRequest.LIST_TEAMS); + Collection<TeamModel> models = JsonUtils.retrieveJson(url, TEAMS_TYPE, account, password); + List<TeamModel> list = new ArrayList<TeamModel>(models); + return list; + } + + /** * Create a repository on the Gitblit server. * * @param repository @@ -145,6 +190,10 @@ */ public static boolean createRepository(RepositoryModel repository, String serverUrl, String account, char[] password) throws IOException { + // ensure repository name ends with .git + if (!repository.name.endsWith(".git")) { + repository.name += ".git"; + } return doAction(RpcRequest.CREATE_REPOSITORY, null, repository, serverUrl, account, password); @@ -231,6 +280,53 @@ } /** + * Create a team on the Gitblit server. + * + * @param team + * @param serverUrl + * @param account + * @param password + * @return true if the action succeeded + * @throws IOException + */ + public static boolean createTeam(TeamModel team, String serverUrl, String account, + char[] password) throws IOException { + return doAction(RpcRequest.CREATE_TEAM, null, team, serverUrl, account, password); + + } + + /** + * Send a revised version of the team model to the Gitblit server. + * + * @param team + * @param serverUrl + * @param account + * @param password + * @return true if the action succeeded + * @throws IOException + */ + public static boolean updateTeam(String teamname, TeamModel team, String serverUrl, + String account, char[] password) throws IOException { + return doAction(RpcRequest.EDIT_TEAM, teamname, team, serverUrl, account, password); + + } + + /** + * Deletes a team from the Gitblit server. + * + * @param team + * @param serverUrl + * @param account + * @param password + * @return true if the action succeeded + * @throws IOException + */ + public static boolean deleteTeam(TeamModel team, String serverUrl, String account, + char[] password) throws IOException { + return doAction(RpcRequest.DELETE_TEAM, null, team, serverUrl, account, password); + } + + /** * Retrieves the list of users that can access the specified repository. * * @param repository @@ -248,7 +344,7 @@ } /** - * Sets the repository membership list. + * Sets the repository user membership list. * * @param repository * @param memberships @@ -262,6 +358,41 @@ List<String> memberships, String serverUrl, String account, char[] password) throws IOException { return doAction(RpcRequest.SET_REPOSITORY_MEMBERS, repository.name, memberships, serverUrl, + account, password); + } + + /** + * Retrieves the list of teams that can access the specified repository. + * + * @param repository + * @param serverUrl + * @param account + * @param password + * @return list of teams + * @throws IOException + */ + public static List<String> getRepositoryTeams(RepositoryModel repository, String serverUrl, + String account, char[] password) throws IOException { + String url = asLink(serverUrl, RpcRequest.LIST_REPOSITORY_TEAMS, repository.name); + Collection<String> list = JsonUtils.retrieveJson(url, NAMES_TYPE, account, password); + return new ArrayList<String>(list); + } + + /** + * Sets the repository team membership list. + * + * @param repository + * @param teams + * @param serverUrl + * @param account + * @param password + * @return true if the action succeeded + * @throws IOException + */ + public static boolean setRepositoryTeams(RepositoryModel repository, + List<String> teams, String serverUrl, String account, char[] password) + throws IOException { + return doAction(RpcRequest.SET_REPOSITORY_TEAMS, repository.name, teams, serverUrl, account, password); } @@ -389,7 +520,7 @@ } /** - * Retrieves a map of all branches in the Gitblit server keyed by + * Retrieves a map of local branches in the Gitblit server keyed by * repository. * * @param serverUrl @@ -398,12 +529,36 @@ * @return * @throws IOException */ - public static Map<String, Collection<String>> getAllBranches(String serverUrl, - String account, char[] password) throws IOException { + public static Map<String, Collection<String>> getBranches(String serverUrl, String account, + char[] password) throws IOException { String url = asLink(serverUrl, RpcRequest.LIST_BRANCHES); - Map<String, Collection<String>> allReferences = JsonUtils.retrieveJson(url, - BRANCHES_TYPE, account, password); - return allReferences; + Map<String, Collection<String>> branches = JsonUtils.retrieveJson(url, BRANCHES_TYPE, + account, password); + return branches; + } + + /** + * Retrieves a list of available branch feeds in the Gitblit server. + * + * @param serverUrl + * @param account + * @param password + * @return + * @throws IOException + */ + public static List<FeedModel> getBranchFeeds(String serverUrl, String account, char[] password) + throws IOException { + List<FeedModel> feeds = new ArrayList<FeedModel>(); + Map<String, Collection<String>> allBranches = getBranches(serverUrl, account, password); + for (Map.Entry<String, Collection<String>> entry : allBranches.entrySet()) { + for (String branch : entry.getValue()) { + FeedModel feed = new FeedModel(); + feed.repository = entry.getKey(); + feed.branch = branch; + feeds.add(feed); + } + } + return feeds; } /** -- Gitblit v1.9.1