From cb285cbfddfc0b633d6b8cdb4dc0d2bd2b8b51ef Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Thu, 05 Jan 2012 17:34:05 -0500 Subject: [PATCH] Fixed bug in receive hook for repositories in subfolders --- src/com/gitblit/utils/GitBlitDiffFormatter.java | 44 +++++++++++++++++++++++++++++++++++--------- 1 files changed, 35 insertions(+), 9 deletions(-) diff --git a/src/com/gitblit/utils/GitBlitDiffFormatter.java b/src/com/gitblit/utils/GitBlitDiffFormatter.java index 54cb6c2..0e393fe 100644 --- a/src/com/gitblit/utils/GitBlitDiffFormatter.java +++ b/src/com/gitblit/utils/GitBlitDiffFormatter.java @@ -1,3 +1,18 @@ +/* + * Copyright 2011 gitblit.com. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ package com.gitblit.utils; import java.io.ByteArrayOutputStream; @@ -6,11 +21,17 @@ import org.eclipse.jgit.diff.RawText; +/** + * Generates an html snippet of a diff in Gitblit's style. + * + * @author James Moger + * + */ public class GitBlitDiffFormatter extends GitWebDiffFormatter { private final OutputStream os; - private int left = 0, right = 0; + private int left, right; public GitBlitDiffFormatter(OutputStream os) { super(os); @@ -31,7 +52,8 @@ * @throws IOException */ @Override - protected void writeHunkHeader(int aStartLine, int aEndLine, int bStartLine, int bEndLine) throws IOException { + protected void writeHunkHeader(int aStartLine, int aEndLine, int bStartLine, int bEndLine) + throws IOException { os.write("<tr><th>..</th><th>..</th><td class='hunk_header'>".getBytes()); os.write('@'); os.write('@'); @@ -46,7 +68,8 @@ } @Override - protected void writeLine(final char prefix, final RawText text, final int cur) throws IOException { + protected void writeLine(final char prefix, final RawText text, final int cur) + throws IOException { os.write("<tr>".getBytes()); switch (prefix) { case '+': @@ -89,7 +112,7 @@ public String getHtml() { String html = os.toString(); String[] lines = html.split("\n"); - StringBuilder sb = new StringBuilder(); + StringBuilder sb = new StringBuilder(); boolean inFile = false; String oldnull = "a/dev/null"; for (String line : lines) { @@ -97,11 +120,16 @@ // skip index lines } else if (line.startsWith("new file")) { // skip new file lines + } else if (line.startsWith("\\ No newline")) { + // skip no new line + } else if (line.startsWith("---") || line.startsWith("+++")) { + // skip --- +++ lines } else if (line.startsWith("diff")) { if (line.indexOf(oldnull) > -1) { // a is null, use b line = line.substring(("diff --git " + oldnull).length()).trim(); - line = line.substring(2); // trim b/ + // trim b/ + line = line.substring(2); } else { // use a line = line.substring("diff --git a/".length()).trim(); @@ -112,13 +140,11 @@ inFile = false; } sb.append("<div class='header'>").append(line).append("</div>"); - sb.append("<div class=\"diff\">"); + sb.append("<div class=\"diff\">"); sb.append("<table><tbody>"); inFile = true; - } else if (line.startsWith("---") || line.startsWith("+++")) { - // skip --- +++ lines } else { - sb.append(line).append('\n'); + sb.append(line); } } sb.append("</table></div>"); -- Gitblit v1.9.1