From bfc22d47158b685ff8c6a686faf0f213a65fa0e1 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gmail.com> Date: Thu, 25 Sep 2014 08:22:32 -0400 Subject: [PATCH] Merged #186 "Support email subject-line links" --- src/main/java/com/gitblit/wicket/pages/EditTicketPage.java | 12 +++++++----- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/gitblit/wicket/pages/EditTicketPage.java b/src/main/java/com/gitblit/wicket/pages/EditTicketPage.java index 46781fa..1adc713 100644 --- a/src/main/java/com/gitblit/wicket/pages/EditTicketPage.java +++ b/src/main/java/com/gitblit/wicket/pages/EditTicketPage.java @@ -37,6 +37,7 @@ import com.gitblit.Constants; import com.gitblit.Constants.AccessPermission; +import com.gitblit.Constants.AuthorizationControl; import com.gitblit.models.RegistrantAccessPermission; import com.gitblit.models.TicketModel; import com.gitblit.models.TicketModel.Change; @@ -133,7 +134,7 @@ form.add(new TextField<String>("title", titleModel)); form.add(new TextField<String>("topic", topicModel)); - final IModel<String> markdownPreviewModel = new Model<String>(); + final IModel<String> markdownPreviewModel = Model.of(ticket.body == null ? "" : ticket.body); descriptionPreview = new Label("descriptionPreview", markdownPreviewModel); descriptionPreview.setEscapeModelStrings(false); descriptionPreview.setOutputMarkupId(true); @@ -163,13 +164,14 @@ // responsible Set<String> userlist = new TreeSet<String>(ticket.getParticipants()); - if (UserModel.ANONYMOUS.canPush(getRepositoryModel())) { - // anonymous push + if (UserModel.ANONYMOUS.canPush(getRepositoryModel()) + || AuthorizationControl.AUTHENTICATED == getRepositoryModel().authorizationControl) { + // authorization is ANONYMOUS or AUTHENTICATED (i.e. all users can be set responsible) userlist.addAll(app().users().getAllUsernames()); } else { - // authenticated push + // authorization is by NAMED users (users with PUSH permission can be set responsible) for (RegistrantAccessPermission rp : app().repositories().getUserAccessPermissions(getRepositoryModel())) { - if (rp.permission.atLeast(AccessPermission.PUSH) && !rp.isTeam()) { + if (rp.permission.atLeast(AccessPermission.PUSH)) { userlist.add(rp.registrant); } } -- Gitblit v1.9.1