From b701ed7c4e138c4aaa3acb029f6e35fdf01388e4 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Thu, 01 Nov 2012 17:32:13 -0400 Subject: [PATCH] Ignore permission definitions for admins, it just confuses things --- src/com/gitblit/models/UserModel.java | 17 ++++++++++------- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/com/gitblit/models/UserModel.java b/src/com/gitblit/models/UserModel.java index 0c9b9cc..23322c2 100644 --- a/src/com/gitblit/models/UserModel.java +++ b/src/com/gitblit/models/UserModel.java @@ -138,23 +138,26 @@ */ public List<RegistrantAccessPermission> getRepositoryPermissions() { List<RegistrantAccessPermission> list = new ArrayList<RegistrantAccessPermission>(); + if (canAdmin()) { + // user has REWIND access to all repositories + return list; + } for (Map.Entry<String, AccessPermission> entry : permissions.entrySet()) { String registrant = entry.getKey(); + AccessPermission ap = entry.getValue(); String source = null; - boolean editable = true; + boolean mutable = true; PermissionType pType = PermissionType.EXPLICIT; - if (canAdmin()) { - pType = PermissionType.ADMINISTRATOR; - editable = false; - } else if (isMyPersonalRepository(registrant)) { + if (isMyPersonalRepository(registrant)) { pType = PermissionType.OWNER; - editable = false; + ap = AccessPermission.REWIND; + mutable = false; } else if (StringUtils.findInvalidCharacter(registrant) != null) { // a regex will have at least 1 invalid character pType = PermissionType.REGEX; source = registrant; } - list.add(new RegistrantAccessPermission(registrant, entry.getValue(), pType, RegistrantType.REPOSITORY, source, editable)); + list.add(new RegistrantAccessPermission(registrant, ap, pType, RegistrantType.REPOSITORY, source, mutable)); } Collections.sort(list); return list; -- Gitblit v1.9.1