From aa6d43e8b28ff73d69a920e9b3a7b284cfce00c3 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Fri, 29 Nov 2013 11:05:51 -0500 Subject: [PATCH] Extract SessionManager from GitBlit singleton --- src/main/java/com/gitblit/wicket/pages/BlamePage.java | 19 +++++++++++-------- 1 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/main/java/com/gitblit/wicket/pages/BlamePage.java b/src/main/java/com/gitblit/wicket/pages/BlamePage.java index 5148915..5268263 100644 --- a/src/main/java/com/gitblit/wicket/pages/BlamePage.java +++ b/src/main/java/com/gitblit/wicket/pages/BlamePage.java @@ -30,18 +30,20 @@ import org.eclipse.jgit.lib.ObjectId; import org.eclipse.jgit.revwalk.RevCommit; -import com.gitblit.GitBlit; import com.gitblit.Keys; import com.gitblit.models.AnnotatedLine; import com.gitblit.models.PathModel; import com.gitblit.utils.DiffUtils; import com.gitblit.utils.JGitUtils; import com.gitblit.utils.StringUtils; +import com.gitblit.wicket.CacheControl; +import com.gitblit.wicket.CacheControl.LastModified; import com.gitblit.wicket.WicketUtils; import com.gitblit.wicket.panels.CommitHeaderPanel; import com.gitblit.wicket.panels.LinkPanel; import com.gitblit.wicket.panels.PathBreadcrumbsPanel; +@CacheControl(LastModified.BOOT) public class BlamePage extends RepositoryPage { public BlamePage(PageParameters params) { @@ -68,11 +70,11 @@ add(new PathBreadcrumbsPanel("breadcrumbs", repositoryName, blobPath, objectId)); - String format = GitBlit.getString(Keys.web.datetimestampLongFormat, + String format = app().settings().getString(Keys.web.datetimestampLongFormat, "EEEE, MMMM d, yyyy HH:mm Z"); final DateFormat df = new SimpleDateFormat(format); df.setTimeZone(getTimeZone()); - + PathModel pathModel = null; List<PathModel> paths = JGitUtils.getFilesInPath(getRepository(), StringUtils.getRootPath(blobPath), commit); for (PathModel path : paths) { @@ -81,15 +83,15 @@ break; } } - + if (pathModel == null) { add(new Label("annotation").setVisible(false)); add(new Label("missingBlob", missingBlob(blobPath, commit)).setEscapeModelStrings(false)); return; } - + add(new Label("missingBlob").setVisible(false)); - + List<AnnotatedLine> lines = DiffUtils.blame(getRepository(), blobPath, objectId); ListDataProvider<AnnotatedLine> blameDp = new ListDataProvider<AnnotatedLine>(lines); DataView<AnnotatedLine> blameView = new DataView<AnnotatedLine>("annotation", blameDp) { @@ -99,6 +101,7 @@ private boolean showInitials = true; private String zeroId = ObjectId.zeroId().getName(); + @Override public void populateItem(final Item<AnnotatedLine> item) { AnnotatedLine entry = item.getModelObject(); item.add(new Label("line", "" + entry.lineNumber)); @@ -154,12 +157,12 @@ protected String getPageName() { return getString("gb.blame"); } - + @Override protected Class<? extends BasePage> getRepoNavPageClass() { return TreePage.class; } - + protected String missingBlob(String blobPath, RevCommit commit) { StringBuilder sb = new StringBuilder(); sb.append("<div class=\"alert alert-error\">"); -- Gitblit v1.9.1