From a5e762ba4ab82f0c6ef71d853c5103f19bbf8e22 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Thu, 11 Oct 2012 08:10:20 -0400 Subject: [PATCH] Tweak canFork description --- tests/com/gitblit/tests/GroovyScriptTest.java | 81 +++++++++++++++++++++++++++++++++++----- 1 files changed, 71 insertions(+), 10 deletions(-) diff --git a/tests/com/gitblit/tests/GroovyScriptTest.java b/tests/com/gitblit/tests/GroovyScriptTest.java index 5051100..3d3621d 100644 --- a/tests/com/gitblit/tests/GroovyScriptTest.java +++ b/tests/com/gitblit/tests/GroovyScriptTest.java @@ -20,7 +20,11 @@ import groovy.lang.Binding; import groovy.util.GroovyScriptEngine; +import java.io.BufferedWriter; import java.io.File; +import java.io.FileWriter; +import java.io.PrintWriter; +import java.io.StringWriter; import java.text.MessageFormat; import java.util.ArrayList; import java.util.Arrays; @@ -69,6 +73,7 @@ public void testSendMail() throws Exception { MockGitblit gitblit = new MockGitblit(); MockLogger logger = new MockLogger(); + MockClientLogger clientLogger = new MockClientLogger(); List<ReceiveCommand> commands = new ArrayList<ReceiveCommand>(); commands.add(new ReceiveCommand(ObjectId .fromString("c18877690322dfc6ae3e37bb7f7085a24e94e887"), ObjectId @@ -80,7 +85,7 @@ RepositoryModel repository = GitBlit.self().getRepositoryModel("helloworld.git"); repository.mailingLists.add("list@helloworld.git"); - test("sendmail.groovy", gitblit, logger, commands, repository); + test("sendmail.groovy", gitblit, logger, clientLogger, commands, repository); assertEquals(1, logger.messages.size()); assertEquals(1, gitblit.messages.size()); MockMail m = gitblit.messages.get(0); @@ -92,26 +97,28 @@ public void testProtectRefsCreateBranch() throws Exception { MockGitblit gitblit = new MockGitblit(); MockLogger logger = new MockLogger(); + MockClientLogger clientLogger = new MockClientLogger(); List<ReceiveCommand> commands = new ArrayList<ReceiveCommand>(); commands.add(new ReceiveCommand(ObjectId.zeroId(), ObjectId .fromString("3fa7c46d11b11d61f1cbadc6888be5d0eae21969"), "refs/heads/master")); RepositoryModel repository = new RepositoryModel("ex@mple.git", "", "admin", new Date()); - test("protect-refs.groovy", gitblit, logger, commands, repository); + test("protect-refs.groovy", gitblit, logger, clientLogger, commands, repository); } @Test public void testProtectRefsCreateTag() throws Exception { MockGitblit gitblit = new MockGitblit(); MockLogger logger = new MockLogger(); + MockClientLogger clientLogger = new MockClientLogger(); List<ReceiveCommand> commands = new ArrayList<ReceiveCommand>(); commands.add(new ReceiveCommand(ObjectId.zeroId(), ObjectId .fromString("3fa7c46d11b11d61f1cbadc6888be5d0eae21969"), "refs/tags/v1.0")); RepositoryModel repository = new RepositoryModel("ex@mple.git", "", "admin", new Date()); - test("protect-refs.groovy", gitblit, logger, commands, repository); + test("protect-refs.groovy", gitblit, logger, clientLogger, commands, repository); assertEquals(0, logger.messages.size()); } @@ -119,6 +126,7 @@ public void testProtectRefsFastForward() throws Exception { MockGitblit gitblit = new MockGitblit(); MockLogger logger = new MockLogger(); + MockClientLogger clientLogger = new MockClientLogger(); List<ReceiveCommand> commands = new ArrayList<ReceiveCommand>(); commands.add(new ReceiveCommand(ObjectId .fromString("c18877690322dfc6ae3e37bb7f7085a24e94e887"), ObjectId @@ -126,7 +134,7 @@ RepositoryModel repository = new RepositoryModel("ex@mple.git", "", "admin", new Date()); - test("protect-refs.groovy", gitblit, logger, commands, repository); + test("protect-refs.groovy", gitblit, logger, clientLogger, commands, repository); assertEquals(0, logger.messages.size()); } @@ -134,6 +142,7 @@ public void testProtectRefsDeleteMasterBranch() throws Exception { MockGitblit gitblit = new MockGitblit(); MockLogger logger = new MockLogger(); + MockClientLogger clientLogger = new MockClientLogger(); List<ReceiveCommand> commands = new ArrayList<ReceiveCommand>(); ReceiveCommand command = new ReceiveCommand(ObjectId .fromString("3fa7c46d11b11d61f1cbadc6888be5d0eae21969"), ObjectId.zeroId(), @@ -142,7 +151,7 @@ RepositoryModel repository = new RepositoryModel("ex@mple.git", "", "admin", new Date()); - test("protect-refs.groovy", gitblit, logger, commands, repository); + test("protect-refs.groovy", gitblit, logger, clientLogger, commands, repository); assertEquals(ReceiveCommand.Result.REJECTED_NODELETE, command.getResult()); assertEquals(0, logger.messages.size()); } @@ -151,6 +160,7 @@ public void testProtectRefsDeleteOtherBranch() throws Exception { MockGitblit gitblit = new MockGitblit(); MockLogger logger = new MockLogger(); + MockClientLogger clientLogger = new MockClientLogger(); List<ReceiveCommand> commands = new ArrayList<ReceiveCommand>(); commands.add(new ReceiveCommand(ObjectId .fromString("3fa7c46d11b11d61f1cbadc6888be5d0eae21969"), ObjectId.zeroId(), @@ -158,7 +168,7 @@ RepositoryModel repository = new RepositoryModel("ex@mple.git", "", "admin", new Date()); - test("protect-refs.groovy", gitblit, logger, commands, repository); + test("protect-refs.groovy", gitblit, logger, clientLogger, commands, repository); assertEquals(0, logger.messages.size()); } @@ -166,6 +176,7 @@ public void testProtectRefsDeleteTag() throws Exception { MockGitblit gitblit = new MockGitblit(); MockLogger logger = new MockLogger(); + MockClientLogger clientLogger = new MockClientLogger(); List<ReceiveCommand> commands = new ArrayList<ReceiveCommand>(); ReceiveCommand command = new ReceiveCommand(ObjectId .fromString("3fa7c46d11b11d61f1cbadc6888be5d0eae21969"), ObjectId.zeroId(), @@ -174,7 +185,7 @@ RepositoryModel repository = new RepositoryModel("ex@mple.git", "", "admin", new Date()); - test("protect-refs.groovy", gitblit, logger, commands, repository); + test("protect-refs.groovy", gitblit, logger, clientLogger, commands, repository); assertEquals(ReceiveCommand.Result.REJECTED_NODELETE, command.getResult()); assertEquals(0, logger.messages.size()); } @@ -183,6 +194,7 @@ public void testBlockPush() throws Exception { MockGitblit gitblit = new MockGitblit(); MockLogger logger = new MockLogger(); + MockClientLogger clientLogger = new MockClientLogger(); List<ReceiveCommand> commands = new ArrayList<ReceiveCommand>(); commands.add(new ReceiveCommand(ObjectId .fromString("c18877690322dfc6ae3e37bb7f7085a24e94e887"), ObjectId @@ -191,14 +203,40 @@ RepositoryModel repository = new RepositoryModel("ex@mple.git", "", "admin", new Date()); try { - test("blockpush.groovy", gitblit, logger, commands, repository); + test("blockpush.groovy", gitblit, logger, clientLogger, commands, repository); assertTrue("blockpush should have failed!", false); } catch (GitBlitException e) { assertTrue(e.getMessage().contains("failed")); } } + + @Test + public void testClientLogging() throws Exception { + MockGitblit gitblit = new MockGitblit(); + MockLogger logger = new MockLogger(); + MockClientLogger clientLogger = new MockClientLogger(); + List<ReceiveCommand> commands = new ArrayList<ReceiveCommand>(); + commands.add(new ReceiveCommand(ObjectId + .fromString("c18877690322dfc6ae3e37bb7f7085a24e94e887"), ObjectId + .fromString("3fa7c46d11b11d61f1cbadc6888be5d0eae21969"), "refs/heads/master")); + + RepositoryModel repository = new RepositoryModel("ex@mple.git", "", "admin", new Date()); + + File groovyDir = GitBlit.getGroovyScriptsFolder(); + File tempScript = File.createTempFile("testClientLogging", "groovy", groovyDir); + tempScript.deleteOnExit(); + + BufferedWriter writer = new BufferedWriter(new FileWriter(tempScript)); + + writer.write("clientLogger.info('this is a test message')\n"); + writer.flush(); + writer.close(); - private void test(String script, MockGitblit gitblit, MockLogger logger, + test(tempScript.getName(), gitblit, logger, clientLogger, commands, repository); + assertTrue("Message Missing", clientLogger.messages.contains("this is a test message")); + } + + private void test(String script, MockGitblit gitblit, MockLogger logger, MockClientLogger clientLogger, List<ReceiveCommand> commands, RepositoryModel repository) throws Exception { UserModel user = new UserModel("mock"); @@ -215,6 +253,7 @@ binding.setVariable("commands", commands); binding.setVariable("url", gitblitUrl); binding.setVariable("logger", logger); + binding.setVariable("clientLogger", clientLogger); Object result = gse.run(script, binding); if (result instanceof Boolean) { @@ -266,6 +305,28 @@ messages.add(message); } } + + class MockClientLogger { + List<String> messages = new ArrayList<String>(); + + public void info(String message) { + messages.add(message); + } + + public void error(String message) { + messages.add(message); + } + + public void error(String message, Throwable t) { + PrintWriter writer = new PrintWriter(new StringWriter()); + if (!StringUtils.isEmpty(message)) { + writer.append(message); + writer.append('\n'); + } + t.printStackTrace(writer); + messages.add(writer.toString()); + } + } class MockMail { final Collection<String> toAddresses; @@ -284,4 +345,4 @@ + message; } } -} \ No newline at end of file +} -- Gitblit v1.9.1