From 9effe1630d97039b3e01cd9b58ed07e75be1d63c Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Mon, 25 Feb 2013 08:40:30 -0500 Subject: [PATCH] Merge pull request #75 from thefake/master --- src/com/gitblit/wicket/panels/LogPanel.java | 89 +++++++++++++++++++++++++++++++------------- 1 files changed, 63 insertions(+), 26 deletions(-) diff --git a/src/com/gitblit/wicket/panels/LogPanel.java b/src/com/gitblit/wicket/panels/LogPanel.java index 23afc37..0539764 100644 --- a/src/com/gitblit/wicket/panels/LogPanel.java +++ b/src/com/gitblit/wicket/panels/LogPanel.java @@ -1,3 +1,18 @@ +/* + * Copyright 2011 gitblit.com. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ package com.gitblit.wicket.panels; import java.util.Date; @@ -14,35 +29,35 @@ import org.eclipse.jgit.lib.Repository; import org.eclipse.jgit.revwalk.RevCommit; +import com.gitblit.Constants; import com.gitblit.GitBlit; import com.gitblit.Keys; +import com.gitblit.models.RefModel; import com.gitblit.utils.JGitUtils; -import com.gitblit.utils.JGitUtils.SearchType; import com.gitblit.utils.StringUtils; -import com.gitblit.wicket.LinkPanel; import com.gitblit.wicket.WicketUtils; import com.gitblit.wicket.pages.CommitDiffPage; import com.gitblit.wicket.pages.CommitPage; import com.gitblit.wicket.pages.LogPage; -import com.gitblit.wicket.pages.SearchPage; -import com.gitblit.wicket.pages.SummaryPage; +import com.gitblit.wicket.pages.GitSearchPage; import com.gitblit.wicket.pages.TreePage; public class LogPanel extends BasePanel { private static final long serialVersionUID = 1L; - - private boolean hasMore = false; - public LogPanel(String wicketId, final String repositoryName, final String objectId, Repository r, int limit, int pageOffset) { + private boolean hasMore; + + public LogPanel(String wicketId, final String repositoryName, final String objectId, + Repository r, int limit, int pageOffset, boolean showRemoteRefs) { super(wicketId); boolean pageResults = limit <= 0; - int itemsPerPage = GitBlit.self().settings().getInteger(Keys.web.itemsPerPage, 50); + int itemsPerPage = GitBlit.getInteger(Keys.web.itemsPerPage, 50); if (itemsPerPage <= 1) { itemsPerPage = 50; } - final Map<ObjectId, List<String>> allRefs = JGitUtils.getAllRefs(r); + final Map<ObjectId, List<RefModel>> allRefs = JGitUtils.getAllRefs(r, showRemoteRefs); List<RevCommit> commits; if (pageResults) { // Paging result set @@ -53,48 +68,58 @@ } // inaccurate way to determine if there are more commits. - // works unless commits.size() represents the exact end. + // works unless commits.size() represents the exact end. hasMore = commits.size() >= itemsPerPage; // header if (pageResults) { // shortlog page - // show repository summary page link - add(new LinkPanel("header", "title", repositoryName, SummaryPage.class, WicketUtils.newRepositoryParameter(repositoryName))); + add(new Label("header", objectId)); } else { // summary page // show shortlog page link - add(new LinkPanel("header", "title", new StringResourceModel("gb.log", this, null), LogPage.class, WicketUtils.newRepositoryParameter(repositoryName))); + add(new LinkPanel("header", "title", objectId, LogPage.class, + WicketUtils.newRepositoryParameter(repositoryName))); } + final int hashLen = GitBlit.getInteger(Keys.web.shortCommitIdLength, 6); ListDataProvider<RevCommit> dp = new ListDataProvider<RevCommit>(commits); DataView<RevCommit> logView = new DataView<RevCommit>("commit", dp) { private static final long serialVersionUID = 1L; - int counter = 0; + int counter; public void populateItem(final Item<RevCommit> item) { final RevCommit entry = item.getModelObject(); final Date date = JGitUtils.getCommitDate(entry); - item.add(WicketUtils.createDateLabel("commitDate", date, getTimeZone())); + item.add(WicketUtils.createDateLabel("commitDate", date, getTimeZone(), getTimeUtils())); // author search link String author = entry.getAuthorIdent().getName(); - LinkPanel authorLink = new LinkPanel("commitAuthor", "list", author, SearchPage.class, WicketUtils.newSearchParameter(repositoryName, objectId, author, SearchType.AUTHOR)); - setPersonSearchTooltip(authorLink, author, SearchType.AUTHOR); + LinkPanel authorLink = new LinkPanel("commitAuthor", "list", author, + GitSearchPage.class, WicketUtils.newSearchParameter(repositoryName, + objectId, author, Constants.SearchType.AUTHOR)); + setPersonSearchTooltip(authorLink, author, Constants.SearchType.AUTHOR); item.add(authorLink); - + // merge icon if (entry.getParentCount() > 1) { item.add(WicketUtils.newImage("commitIcon", "commit_merge_16x16.png")); } else { item.add(WicketUtils.newBlankImage("commitIcon")); } - + // short message String shortMessage = entry.getShortMessage(); - String trimmedMessage = StringUtils.trimShortLog(shortMessage); - LinkPanel shortlog = new LinkPanel("commitShortMessage", "list subject", trimmedMessage, CommitPage.class, WicketUtils.newObjectParameter(repositoryName, entry.getName())); + String trimmedMessage = shortMessage; + if (allRefs.containsKey(entry.getId())) { + trimmedMessage = StringUtils.trimString(shortMessage, Constants.LEN_SHORTLOG_REFS); + } else { + trimmedMessage = StringUtils.trimString(shortMessage, Constants.LEN_SHORTLOG); + } + LinkPanel shortlog = new LinkPanel("commitShortMessage", "list subject", + trimmedMessage, CommitPage.class, WicketUtils.newObjectParameter( + repositoryName, entry.getName())); if (!shortMessage.equals(trimmedMessage)) { WicketUtils.setHtmlTooltip(shortlog, shortMessage); } @@ -102,9 +127,19 @@ item.add(new RefsPanel("commitRefs", repositoryName, entry, allRefs)); - item.add(new BookmarkablePageLink<Void>("view", CommitPage.class, WicketUtils.newObjectParameter(repositoryName, entry.getName()))); - item.add(new BookmarkablePageLink<Void>("diff", CommitDiffPage.class, WicketUtils.newObjectParameter(repositoryName, entry.getName()))); - item.add(new BookmarkablePageLink<Void>("tree", TreePage.class, WicketUtils.newObjectParameter(repositoryName, entry.getName()))); + // commit hash link + LinkPanel commitHash = new LinkPanel("hashLink", null, entry.getName().substring(0, hashLen), + CommitPage.class, WicketUtils.newObjectParameter( + repositoryName, entry.getName())); + WicketUtils.setCssClass(commitHash, "shortsha1"); + WicketUtils.setHtmlTooltip(commitHash, entry.getName()); + item.add(commitHash); + + item.add(new BookmarkablePageLink<Void>("diff", CommitDiffPage.class, WicketUtils + .newObjectParameter(repositoryName, entry.getName())).setEnabled(entry + .getParentCount() > 0)); + item.add(new BookmarkablePageLink<Void>("tree", TreePage.class, WicketUtils + .newObjectParameter(repositoryName, entry.getName()))); WicketUtils.setAlternatingBackground(item, counter); counter++; @@ -124,7 +159,9 @@ // more if (commits.size() == limit) { // show more - add(new LinkPanel("moreLogs", "link", new StringResourceModel("gb.moreLogs", this, null), LogPage.class, WicketUtils.newRepositoryParameter(repositoryName))); + add(new LinkPanel("moreLogs", "link", new StringResourceModel("gb.moreLogs", + this, null), LogPage.class, + WicketUtils.newRepositoryParameter(repositoryName))); } else { // no more add(new Label("moreLogs", "").setVisible(false)); @@ -132,7 +169,7 @@ } } } - + public boolean hasMore() { return hasMore; } -- Gitblit v1.9.1