From 9effe1630d97039b3e01cd9b58ed07e75be1d63c Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Mon, 25 Feb 2013 08:40:30 -0500 Subject: [PATCH] Merge pull request #75 from thefake/master --- src/com/gitblit/FileSettings.java | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/com/gitblit/FileSettings.java b/src/com/gitblit/FileSettings.java index 666bda0..3a42cad 100644 --- a/src/com/gitblit/FileSettings.java +++ b/src/com/gitblit/FileSettings.java @@ -87,8 +87,14 @@ String content = FileUtils.readContent(propertiesFile, "\n"); for (Map.Entry<String, String> setting:settings.entrySet()) { String regex = "(?m)^(" + regExEscape(setting.getKey()) + "\\s*+=\\s*+)" - + "(?:[^\r\n\\\\]++|\\\\(?:\r?\n|\r|.))*+$"; + + "(?:[^\r\n\\\\]++|\\\\(?:\r?\n|\r|.))*+$"; + String oldContent = content; content = content.replaceAll(regex, setting.getKey() + " = " + setting.getValue()); + if (content.equals(oldContent)) { + // did not replace value because it does not exist in the file + // append new setting to content (issue-85) + content += "\n" + setting.getKey() + " = " + setting.getValue(); + } } FileUtils.writeContent(propertiesFile, content); // manually set the forceReload flag because not all JVMs support real @@ -98,7 +104,7 @@ } private String regExEscape(String input) { - return input.replace(".", "\\."); + return input.replace(".", "\\.").replace("$", "\\$").replace("{", "\\{"); } /** -- Gitblit v1.9.1