From 9cc56a1f60eff2ce1db40b7078eab92e78602e1c Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Sun, 13 Jan 2013 16:49:37 -0500
Subject: [PATCH] Fix submodule links on commit, comitdiff, and tree page (issue-178)

---
 src/com/gitblit/FileUserService.java |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/com/gitblit/FileUserService.java b/src/com/gitblit/FileUserService.java
index d411b68..056df82 100644
--- a/src/com/gitblit/FileUserService.java
+++ b/src/com/gitblit/FileUserService.java
@@ -329,8 +329,7 @@
 			UserModel oldUser = getUserModel(username);
 			List<String> roles;
 			if (model.permissions == null) {
-				// legacy, use repository list
-				roles = new ArrayList<String>(model.repositories);
+				roles = new ArrayList<String>();
 			} else {
 				// discrete repository permissions
 				roles = new ArrayList<String>();
@@ -797,7 +796,10 @@
 							repositories.add(role);
 						}
 					}
-					team.addRepositoryPermissions(repositories);
+					if (!team.canAdmin) {
+						// only read permissions for non-admin teams
+						team.addRepositoryPermissions(repositories);
+					}
 					team.addUsers(users);
 					team.addMailingLists(mailingLists);
 					team.preReceiveScripts.addAll(preReceive);

--
Gitblit v1.9.1