From 9bb31c888eaa3f3949c190c0d0848ec480526ae5 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Fri, 02 May 2014 16:05:37 -0400 Subject: [PATCH] Documentation --- src/main/java/com/gitblit/wicket/pages/RepositoryPage.java | 83 +++++++++++++++++++++++++---------------- 1 files changed, 51 insertions(+), 32 deletions(-) diff --git a/src/main/java/com/gitblit/wicket/pages/RepositoryPage.java b/src/main/java/com/gitblit/wicket/pages/RepositoryPage.java index 70a2b9e..5ea99fd 100644 --- a/src/main/java/com/gitblit/wicket/pages/RepositoryPage.java +++ b/src/main/java/com/gitblit/wicket/pages/RepositoryPage.java @@ -29,6 +29,7 @@ import org.apache.wicket.Component; import org.apache.wicket.PageParameters; +import org.apache.wicket.RestartResponseException; import org.apache.wicket.behavior.SimpleAttributeModifier; import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.form.DropDownChoice; @@ -46,18 +47,19 @@ import org.slf4j.LoggerFactory; import com.gitblit.Constants; -import com.gitblit.GitBlit; import com.gitblit.GitBlitException; import com.gitblit.Keys; -import com.gitblit.PagesServlet; -import com.gitblit.SyndicationServlet; import com.gitblit.models.ProjectModel; import com.gitblit.models.RefModel; import com.gitblit.models.RepositoryModel; import com.gitblit.models.SubmoduleModel; import com.gitblit.models.UserModel; import com.gitblit.models.UserRepositoryPreferences; +import com.gitblit.servlet.PagesServlet; +import com.gitblit.servlet.SyndicationServlet; +import com.gitblit.tickets.TicketIndexer.Lucene; import com.gitblit.utils.ArrayUtils; +import com.gitblit.utils.BugtraqProcessor; import com.gitblit.utils.DeepCopier; import com.gitblit.utils.JGitUtils; import com.gitblit.utils.RefLogUtils; @@ -67,6 +69,7 @@ import com.gitblit.wicket.PageRegistration; import com.gitblit.wicket.PageRegistration.OtherPageLink; import com.gitblit.wicket.SessionlessForm; +import com.gitblit.wicket.TicketsUI; import com.gitblit.wicket.WicketUtils; import com.gitblit.wicket.panels.LinkPanel; import com.gitblit.wicket.panels.NavigationPanel; @@ -95,9 +98,9 @@ public RepositoryPage(PageParameters params) { super(params); repositoryName = WicketUtils.getRepositoryName(params); - String root =StringUtils.getFirstPathElement(repositoryName); + String root = StringUtils.getFirstPathElement(repositoryName); if (StringUtils.isEmpty(root)) { - projectName = GitBlit.getString(Keys.web.repositoryRootGroupName, "main"); + projectName = app().settings().getString(Keys.web.repositoryRootGroupName, "main"); } else { projectName = root; } @@ -108,7 +111,7 @@ } if (!getRepositoryModel().hasCommits) { - setResponsePage(EmptyRepositoryPage.class, params); + throw new RestartResponseException(EmptyRepositoryPage.class, params); } if (getRepositoryModel().isCollectingGarbage) { @@ -139,7 +142,7 @@ UserRepositoryPreferences prefs = user.getPreferences().getRepositoryPreferences(getRepositoryModel().name); prefs.starred = star; try { - GitBlit.self().updateUserModel(user.username, user, false); + app().gitblit().reviseUser(user.username, user); } catch (GitBlitException e) { logger.error("Failed to update user " + user.username, e); error(getString("gb.failedToUpdateUser"), false); @@ -176,6 +179,10 @@ return getClass(); } + protected BugtraqProcessor bugtraqProcessor() { + return new BugtraqProcessor(app().settings()); + } + private Map<String, PageRegistration> registerPages() { PageParameters params = null; if (!StringUtils.isEmpty(repositoryName)) { @@ -196,16 +203,21 @@ } pages.put("commits", new PageRegistration("gb.commits", LogPage.class, params)); pages.put("tree", new PageRegistration("gb.tree", TreePage.class, params)); - pages.put("compare", new PageRegistration("gb.compare", ComparePage.class, params, true)); - if (GitBlit.getBoolean(Keys.web.allowForking, true)) { + if (app().tickets().isReady() && (app().tickets().isAcceptingNewTickets(getRepositoryModel()) || app().tickets().hasTickets(getRepositoryModel()))) { + PageParameters tParams = new PageParameters(params); + for (String state : TicketsUI.openStatii) { + tParams.add(Lucene.status.name(), state); + } + pages.put("tickets", new PageRegistration("gb.tickets", TicketsPage.class, tParams)); + } + pages.put("docs", new PageRegistration("gb.docs", DocsPage.class, params, true)); + if (app().settings().getBoolean(Keys.web.allowForking, true)) { pages.put("forks", new PageRegistration("gb.forks", ForksPage.class, params, true)); } + pages.put("compare", new PageRegistration("gb.compare", ComparePage.class, params, true)); // conditional links // per-repository extra page links - if (model.useDocs) { - pages.put("docs", new PageRegistration("gb.docs", DocsPage.class, params, true)); - } if (JGitUtils.getPagesBranch(r) != null) { OtherPageLink pagesLink = new OtherPageLink("gb.pages", PagesServlet.asLink( getRequest().getRelativePathPrefixToContextRoot(), repositoryName, null), true); @@ -214,11 +226,11 @@ // Conditionally add edit link showAdmin = false; - if (GitBlit.getBoolean(Keys.web.authenticateAdminPages, true)) { - boolean allowAdmin = GitBlit.getBoolean(Keys.web.allowAdministration, false); + if (app().settings().getBoolean(Keys.web.authenticateAdminPages, true)) { + boolean allowAdmin = app().settings().getBoolean(Keys.web.allowAdministration, false); showAdmin = allowAdmin && GitBlitWebSession.get().canAdmin(); } else { - showAdmin = GitBlit.getBoolean(Keys.web.allowAdministration, false); + showAdmin = app().settings().getBoolean(Keys.web.allowAdministration, false); } isOwner = GitBlitWebSession.get().isLoggedIn() && (model.isOwner(GitBlitWebSession.get() @@ -227,13 +239,13 @@ } protected boolean allowForkControls() { - return GitBlit.getBoolean(Keys.web.allowForking, true); + return app().settings().getBoolean(Keys.web.allowForking, true); } @Override protected void setupPage(String repositoryName, String pageName) { String projectName = StringUtils.getFirstPathElement(repositoryName); - ProjectModel project = GitBlit.self().getProjectModel(projectName); + ProjectModel project = app().projects().getProjectModel(projectName); if (project.isUserProject()) { // user-as-project add(new LinkPanel("projectTitle", null, project.getDisplayName(), @@ -250,7 +262,6 @@ } add(new LinkPanel("repositoryName", null, name, SummaryPage.class, WicketUtils.newRepositoryParameter(repositoryName))); - add(new Label("pageName", pageName).setRenderBodyOnly(true)); UserModel user = GitBlitWebSession.get().getUser(); if (user == null) { @@ -269,7 +280,7 @@ add(new Label("originRepository").setVisible(false)); } } else { - RepositoryModel origin = GitBlit.self().getRepositoryModel(model.originRepository); + RepositoryModel origin = app().repositories().getRepositoryModel(model.originRepository); if (origin == null) { // no origin repository add(new Label("originRepository").setVisible(false)); @@ -285,6 +296,14 @@ SummaryPage.class, WicketUtils.newRepositoryParameter(model.originRepository))); add(forkFrag); } + } + + // new ticket button + if (user.isAuthenticated && app().tickets().isAcceptingNewTickets(getRepositoryModel())) { + String newTicketUrl = getRequestCycle().urlFor(NewTicketPage.class, WicketUtils.newRepositoryParameter(repositoryName)).toString(); + addToolbarButton("newTicketLink", "fa fa-ticket", getString("gb.new"), newTicketUrl); + } else { + add(new Label("newTicketLink").setVisible(false)); } // (un)star link allows a user to star a repository @@ -308,12 +327,12 @@ } // fork controls - if (!allowForkControls() || user == null || !user.isAuthenticated) { + if (!allowForkControls() || !user.isAuthenticated) { // must be logged-in to fork, hide all fork controls add(new ExternalLink("forkLink", "").setVisible(false)); add(new ExternalLink("myForkLink", "").setVisible(false)); } else { - String fork = GitBlit.self().getFork(user.username, model.name); + String fork = app().repositories().getFork(user.username, model.name); boolean hasFork = fork != null; boolean canFork = user.canFork(model); @@ -365,7 +384,7 @@ protected Repository getRepository() { if (r == null) { - Repository r = GitBlit.self().getRepository(repositoryName); + Repository r = app().repositories().getRepository(repositoryName); if (r == null) { error(getString("gb.canNotLoadRepository") + " " + repositoryName, true); return null; @@ -377,10 +396,10 @@ protected RepositoryModel getRepositoryModel() { if (m == null) { - RepositoryModel model = GitBlit.self().getRepositoryModel( + RepositoryModel model = app().repositories().getRepositoryModel( GitBlitWebSession.get().getUser(), repositoryName); if (model == null) { - if (GitBlit.self().hasRepository(repositoryName, true)) { + if (app().repositories().hasRepository(repositoryName, true)) { // has repository, but unauthorized authenticationError(getString("gb.unauthorizedAccessForRepository") + " " + repositoryName); } else { @@ -452,7 +471,7 @@ return model; } else { // extract the repository name from the clone url - List<String> patterns = GitBlit.getStrings(Keys.git.submoduleUrlPatterns); + List<String> patterns = app().settings().getStrings(Keys.git.submoduleUrlPatterns); String submoduleName = StringUtils.extractRepositoryPath(model.url, patterns.toArray(new String[0])); // determine the current path for constructing paths relative @@ -491,7 +510,7 @@ // create a unique, ordered set of candidate paths Set<String> paths = new LinkedHashSet<String>(candidates); for (String candidate : paths) { - if (GitBlit.self().hasRepository(candidate)) { + if (app().repositories().hasRepository(candidate)) { model.hasSubmodule = true; model.gitblitPath = candidate; return model; @@ -505,7 +524,7 @@ } protected String getShortObjectId(String objectId) { - return objectId.substring(0, GitBlit.getInteger(Keys.web.shortCommitIdLength, 6)); + return objectId.substring(0, app().settings().getInteger(Keys.web.shortCommitIdLength, 6)); } protected void addRefs(Repository r, RevCommit c) { @@ -514,7 +533,7 @@ protected void addFullText(String wicketId, String text) { RepositoryModel model = getRepositoryModel(); - String content = GitBlit.self().processCommitMessage(model, text); + String content = bugtraqProcessor().processCommitMessage(r, model, text); String html; switch (model.commitMessageRenderer) { case MARKDOWN: @@ -535,7 +554,7 @@ String address = identity == null ? "" : identity.getEmailAddress(); name = StringUtils.removeNewlines(name); address = StringUtils.removeNewlines(address); - boolean showEmail = GitBlit.getBoolean(Keys.web.showEmailAddresses, false); + boolean showEmail = app().settings().getBoolean(Keys.web.showEmailAddresses, false); if (!showEmail || StringUtils.isEmpty(name) || StringUtils.isEmpty(address)) { String value = name; if (StringUtils.isEmpty(value)) { @@ -666,7 +685,7 @@ DropDownChoice<Constants.SearchType> searchType = new DropDownChoice<Constants.SearchType>( "searchType", Arrays.asList(Constants.SearchType.values())); searchType.setModel(searchTypeModel); - add(searchType.setVisible(GitBlit.getBoolean(Keys.web.showSearchTypeSelection, false))); + add(searchType.setVisible(app().settings().getBoolean(Keys.web.showSearchTypeSelection, false))); TextField<String> searchBox = new TextField<String>("searchBox", searchBoxModel); add(searchBox); } @@ -697,8 +716,8 @@ } } Class<? extends BasePage> searchPageClass = GitSearchPage.class; - RepositoryModel model = GitBlit.self().getRepositoryModel(repositoryName); - if (GitBlit.getBoolean(Keys.web.allowLuceneIndexing, true) + RepositoryModel model = app().repositories().getRepositoryModel(repositoryName); + if (app().settings().getBoolean(Keys.web.allowLuceneIndexing, true) && !ArrayUtils.isEmpty(model.indexedBranches)) { // this repository is Lucene-indexed searchPageClass = LuceneSearchPage.class; -- Gitblit v1.9.1