From 94e12c168f5eec300fd23d0de25c7dc93a96c429 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Mon, 03 Mar 2014 17:51:21 -0500 Subject: [PATCH] Eliminate Gravatar profile linking and improve api --- src/main/java/com/gitblit/git/GitblitReceivePack.java | 22 +++++++++++++--------- 1 files changed, 13 insertions(+), 9 deletions(-) diff --git a/src/main/java/com/gitblit/git/GitblitReceivePack.java b/src/main/java/com/gitblit/git/GitblitReceivePack.java index c373465..35f0d86 100644 --- a/src/main/java/com/gitblit/git/GitblitReceivePack.java +++ b/src/main/java/com/gitblit/git/GitblitReceivePack.java @@ -87,9 +87,9 @@ protected GroovyScriptEngine gse; - private final IStoredSettings settings; + protected final IStoredSettings settings; - private final IGitblit gitblit; + protected final IGitblit gitblit; public GitblitReceivePack( IGitblit gitblit, @@ -224,13 +224,13 @@ } } - // reset branch commit cache on REWIND and DELETE for (ReceiveCommand cmd : commands) { String ref = cmd.getRefName(); if (ref.startsWith(Constants.R_HEADS)) { switch (cmd.getType()) { case UPDATE_NONFASTFORWARD: case DELETE: + // reset branch commit cache on REWIND and DELETE CommitCache.instance().clear(repository.name, ref); break; default: @@ -400,14 +400,14 @@ } protected void sendHeader(String msg, Object... objects) { - sendMessage("--->", msg, objects); + sendInfo("--> ", msg, objects); } - protected void sendMessage(String msg, Object... objects) { - sendMessage(" ", msg, objects); + protected void sendInfo(String msg, Object... objects) { + sendInfo(" ", msg, objects); } - protected void sendMessage(String prefix, String msg, Object... objects) { + protected void sendInfo(String prefix, String msg, Object... objects) { String text; if (ArrayUtils.isEmpty(objects)) { text = msg; @@ -416,7 +416,9 @@ text = MessageFormat.format(msg, objects); super.sendMessage(prefix + text); } - LOGGER.info(text + " (" + user.username + ")"); + if (!StringUtils.isEmpty(msg)) { + LOGGER.info(text + " (" + user.username + ")"); + } } protected void sendError(String msg, Object... objects) { @@ -428,7 +430,9 @@ text = MessageFormat.format(msg, objects); super.sendError(text); } - LOGGER.error(text + " (" + user.username + ")"); + if (!StringUtils.isEmpty(msg)) { + LOGGER.error(text + " (" + user.username + ")"); + } } /** -- Gitblit v1.9.1