From 91acc355fee5232b3e2089cd6cb7b1214c1207b0 Mon Sep 17 00:00:00 2001 From: Steven Oliver <oliver.steven@gmail.com> Date: Fri, 02 Jan 2015 21:00:52 -0500 Subject: [PATCH] GitBlit no longer uses Google charts --- src/main/java/com/gitblit/wicket/pages/BlobDiffPage.java | 34 +++++++++++++++++++++++++++++----- 1 files changed, 29 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/gitblit/wicket/pages/BlobDiffPage.java b/src/main/java/com/gitblit/wicket/pages/BlobDiffPage.java index d86d2e6..ae737a5 100644 --- a/src/main/java/com/gitblit/wicket/pages/BlobDiffPage.java +++ b/src/main/java/com/gitblit/wicket/pages/BlobDiffPage.java @@ -15,22 +15,26 @@ */ package com.gitblit.wicket.pages; +import java.util.List; + import org.apache.wicket.PageParameters; import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.link.BookmarkablePageLink; import org.eclipse.jgit.lib.Repository; import org.eclipse.jgit.revwalk.RevCommit; -import com.gitblit.GitBlit; import com.gitblit.Keys; import com.gitblit.utils.DiffUtils; import com.gitblit.utils.DiffUtils.DiffOutputType; import com.gitblit.utils.JGitUtils; import com.gitblit.utils.StringUtils; +import com.gitblit.wicket.CacheControl; +import com.gitblit.wicket.CacheControl.LastModified; import com.gitblit.wicket.WicketUtils; import com.gitblit.wicket.panels.CommitHeaderPanel; import com.gitblit.wicket.panels.PathBreadcrumbsPanel; +@CacheControl(LastModified.BOOT) public class BlobDiffPage extends RepositoryPage { public BlobDiffPage(PageParameters params) { @@ -42,19 +46,29 @@ Repository r = getRepository(); RevCommit commit = getCommit(); - DiffOutputType diffType = DiffOutputType.forName(GitBlit.getString(Keys.web.diffStyle, - DiffOutputType.GITBLIT.name())); + final List<String> imageExtensions = app().settings().getStrings(Keys.web.imageExtensions); String diff; if (StringUtils.isEmpty(baseObjectId)) { // use first parent - diff = DiffUtils.getDiff(r, commit, blobPath, diffType); + RevCommit parent = commit.getParentCount() == 0 ? null : commit.getParent(0); + ImageDiffHandler handler = new ImageDiffHandler(this, repositoryName, + parent.getName(), commit.getName(), imageExtensions); + diff = DiffUtils.getDiff(r, commit, blobPath, DiffOutputType.HTML, handler).content; + if (handler.getImgDiffCount() > 0) { + addBottomScript("scripts/imgdiff.js"); // Tiny support script for image diffs + } add(new BookmarkablePageLink<Void>("patchLink", PatchPage.class, WicketUtils.newPathParameter(repositoryName, objectId, blobPath))); } else { // base commit specified RevCommit baseCommit = JGitUtils.getCommit(r, baseObjectId); - diff = DiffUtils.getDiff(r, baseCommit, commit, blobPath, diffType); + ImageDiffHandler handler = new ImageDiffHandler(this, repositoryName, + baseCommit.getName(), commit.getName(), imageExtensions); + diff = DiffUtils.getDiff(r, baseCommit, commit, blobPath, DiffOutputType.HTML, handler).content; + if (handler.getImgDiffCount() > 0) { + addBottomScript("scripts/imgdiff.js"); // Tiny support script for image diffs + } add(new BookmarkablePageLink<Void>("patchLink", PatchPage.class, WicketUtils.newBlobDiffParameter(repositoryName, baseObjectId, objectId, blobPath))); @@ -82,4 +96,14 @@ protected String getPageName() { return getString("gb.diff"); } + + @Override + protected boolean isCommitPage() { + return true; + } + + @Override + protected Class<? extends BasePage> getRepoNavPageClass() { + return TreePage.class; + } } -- Gitblit v1.9.1