From 85fbc79605d886b2b4ec02aa8cfb5b8b05436576 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Thu, 10 Apr 2014 18:58:07 -0400 Subject: [PATCH] Authenticate SSH upload pack --- src/main/java/com/gitblit/manager/ServicesManager.java | 34 +++++++++++++++++++++++++++------- 1 files changed, 27 insertions(+), 7 deletions(-) diff --git a/src/main/java/com/gitblit/manager/ServicesManager.java b/src/main/java/com/gitblit/manager/ServicesManager.java index 6cc9456..f75c6d1 100644 --- a/src/main/java/com/gitblit/manager/ServicesManager.java +++ b/src/main/java/com/gitblit/manager/ServicesManager.java @@ -32,17 +32,18 @@ import com.gitblit.Constants.AccessPermission; import com.gitblit.Constants.AccessRestrictionType; import com.gitblit.Constants.FederationToken; -import com.gitblit.GitBlit; import com.gitblit.IStoredSettings; import com.gitblit.Keys; import com.gitblit.fanout.FanoutNioService; import com.gitblit.fanout.FanoutService; import com.gitblit.fanout.FanoutSocketService; -import com.gitblit.git.GitDaemon; import com.gitblit.models.FederationModel; import com.gitblit.models.RepositoryModel; import com.gitblit.models.UserModel; import com.gitblit.service.FederationPullService; +import com.gitblit.transport.git.GitDaemon; +import com.gitblit.transport.ssh.SshDaemon; +import com.gitblit.utils.IdGenerator; import com.gitblit.utils.StringUtils; import com.gitblit.utils.TimeUtils; @@ -62,13 +63,15 @@ private final IStoredSettings settings; - private final GitBlit gitblit; + private final IGitblit gitblit; private FanoutService fanoutService; private GitDaemon gitDaemon; - public ServicesManager(GitBlit gitblit) { + private SshDaemon sshDaemon; + + public ServicesManager(IGitblit gitblit) { this.settings = gitblit.getSettings(); this.gitblit = gitblit; } @@ -78,6 +81,7 @@ configureFederation(); configureFanout(); configureGitDaemon(); + configureSshDaemon(); return this; } @@ -90,6 +94,9 @@ } if (gitDaemon != null) { gitDaemon.stop(); + } + if (sshDaemon != null) { + sshDaemon.stop(); } return this; } @@ -136,6 +143,20 @@ } } else { logger.info("Git Daemon is disabled."); + } + } + + protected void configureSshDaemon() { + int port = settings.getInteger(Keys.git.sshPort, 0); + String bindInterface = settings.getString(Keys.git.sshBindInterface, "localhost"); + if (port > 0) { + try { + sshDaemon = new SshDaemon(gitblit, new IdGenerator()); + sshDaemon.start(); + } catch (IOException e) { + sshDaemon = null; + logger.error(MessageFormat.format("Failed to start SSH daemon on {0}:{1,number,0}", bindInterface, port), e); + } } } @@ -209,11 +230,11 @@ private class FederationPuller extends FederationPullService { public FederationPuller(FederationModel registration) { - super(Arrays.asList(registration)); + super(gitblit, Arrays.asList(registration)); } public FederationPuller(List<FederationModel> registrations) { - super(registrations); + super(gitblit, registrations); } @Override @@ -226,6 +247,5 @@ "Next pull of {0} @ {1} scheduled for {2,date,yyyy-MM-dd HH:mm}", registration.name, registration.url, registration.nextPull)); } - } } -- Gitblit v1.9.1