From 7ad6d3a8eeb80f0b269eaaf6373ebbbc7eab7e80 Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Tue, 23 Jul 2013 18:04:30 -0400
Subject: [PATCH] Documentation

---
 src/test/java/com/gitblit/tests/RpcTests.java |   33 ++++++++++++++++++++++++++++-----
 1 files changed, 28 insertions(+), 5 deletions(-)

diff --git a/src/test/java/com/gitblit/tests/RpcTests.java b/src/test/java/com/gitblit/tests/RpcTests.java
index f8fdf6f..2f0cffe 100644
--- a/src/test/java/com/gitblit/tests/RpcTests.java
+++ b/src/test/java/com/gitblit/tests/RpcTests.java
@@ -37,6 +37,7 @@
 import com.gitblit.Constants.AuthorizationControl;
 import com.gitblit.Constants.PermissionType;
 import com.gitblit.Constants.RegistrantType;
+import com.gitblit.GitBlitException.NotAllowedException;
 import com.gitblit.GitBlitException.UnauthorizedException;
 import com.gitblit.Keys;
 import com.gitblit.RpcServlet;
@@ -101,6 +102,20 @@
 
 		list = RpcUtils.getUsers(url, "admin", "admin".toCharArray());
 		assertTrue("User list is empty!", list.size() > 0);
+	}
+	
+	@Test
+	public void testGetUser() throws IOException {
+		UserModel user = null;
+		try {
+			user = RpcUtils.getUser("admin", url, null, null);
+		} catch (NotAllowedException e) {
+		}
+		assertNull("Server allows anyone to get user!", user);
+
+		user = RpcUtils.getUser("admin", url, "admin", "admin".toCharArray());
+		assertEquals("User is not the admin!", "admin", user.username);
+		assertTrue("User is not an administrator!", user.canAdmin());
 	}
 
 	@Test
@@ -172,6 +187,7 @@
 		model.authorizationControl = AuthorizationControl.AUTHENTICATED;
 
 		// create
+		RpcUtils.deleteRepository(model, url, account, password.toCharArray());
 		assertTrue("Failed to create repository!",
 				RpcUtils.createRepository(model, url, account, password.toCharArray()));
 
@@ -183,24 +199,31 @@
 		// rename and change access restriciton
 		String originalName = model.name;
 		model.name = "garbagerepo2.git";
-		model.accessRestriction = AccessRestrictionType.PUSH;
+		model.accessRestriction = AccessRestrictionType.CLONE;
 		model.authorizationControl = AuthorizationControl.NAMED;
+		RpcUtils.deleteRepository(model, url, account, password.toCharArray());
 		assertTrue("Failed to update repository!", RpcUtils.updateRepository(originalName, model,
 				url, account, password.toCharArray()));
 
 		retrievedRepository = findRepository(model.name);
 		assertNotNull("Failed to find " + model.name, retrievedRepository);
 		assertTrue("Access retriction type is wrong",
-				AccessRestrictionType.PUSH.equals(retrievedRepository.accessRestriction));
+				AccessRestrictionType.CLONE.equals(retrievedRepository.accessRestriction));
 
+		// restore VIEW restriction
+		retrievedRepository.accessRestriction = AccessRestrictionType.VIEW;
+		assertTrue("Failed to update repository!", RpcUtils.updateRepository(retrievedRepository.name, retrievedRepository,
+				url, account, password.toCharArray()));
+		retrievedRepository = findRepository(retrievedRepository.name);
+		
 		// memberships
 		UserModel testMember = new UserModel("justadded");
 		assertTrue(RpcUtils.createUser(testMember, url, account, password.toCharArray()));
 
 		List<RegistrantAccessPermission> permissions = RpcUtils.getRepositoryMemberPermissions(retrievedRepository, url, account,
 				password.toCharArray());
-		assertEquals("Membership permissions is not empty!", 0, permissions.size());
-		permissions.add(new RegistrantAccessPermission(testMember.username, AccessPermission.PUSH, PermissionType.EXPLICIT, RegistrantType.USER, null, true));
+		assertEquals("Unexpected permissions! " + permissions.toString(), 1, permissions.size());
+		permissions.add(new RegistrantAccessPermission(testMember.username, AccessPermission.VIEW, PermissionType.EXPLICIT, RegistrantType.USER, null, true));
 		assertTrue(
 				"Failed to set member permissions!",
 				RpcUtils.setRepositoryMemberPermissions(retrievedRepository, permissions, url, account,
@@ -211,7 +234,7 @@
 		for (RegistrantAccessPermission permission : permissions) {
 			if (permission.registrant.equalsIgnoreCase(testMember.username)) {
 				foundMember = true;
-				assertEquals(AccessPermission.PUSH, permission.permission);
+				assertEquals(AccessPermission.VIEW, permission.permission);
 				break;
 			}
 		}

--
Gitblit v1.9.1