From 75a907eeabb2983bda2bd1081eacb8a7d94db63b Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Mon, 24 Nov 2014 09:34:46 -0500 Subject: [PATCH] Add .bat and .cmd to the pretty print extensions --- src/main/java/com/gitblit/utils/DiffUtils.java | 172 ++++++++++++++++++++++++++++++++++++++++++++++++++------- 1 files changed, 150 insertions(+), 22 deletions(-) diff --git a/src/main/java/com/gitblit/utils/DiffUtils.java b/src/main/java/com/gitblit/utils/DiffUtils.java index 3c52cb0..b30a203 100644 --- a/src/main/java/com/gitblit/utils/DiffUtils.java +++ b/src/main/java/com/gitblit/utils/DiffUtils.java @@ -52,6 +52,27 @@ private static final Logger LOGGER = LoggerFactory.getLogger(DiffUtils.class); /** + * Callback interface for binary diffs. All the getDiff methods here take an optional handler; + * if given and the {@link DiffOutputType} is {@link DiffOutputType#HTML HTML}, it is responsible + * for displaying a binary diff. + */ + public interface BinaryDiffHandler { + + /** + * Renders a binary diff. The result must be valid HTML, it will be inserted into an HTML table cell. + * May return {@code null} if the default behavior (which is typically just a textual note "Bnary + * files differ") is desired. + * + * @param diffEntry + * current diff entry + * + * @return the rendered diff as HTML, or {@code null} if the default is desired. + */ + public String renderBinaryDiff(final DiffEntry diffEntry); + + } + + /** * Enumeration for the diff output types. */ public static enum DiffOutputType { @@ -66,23 +87,23 @@ return null; } } - + /** - * Encapsulates the output of a diff. + * Encapsulates the output of a diff. */ public static class DiffOutput implements Serializable { private static final long serialVersionUID = 1L; - + public final DiffOutputType type; public final String content; public final DiffStat stat; - + DiffOutput(DiffOutputType type, String content, DiffStat stat) { this.type = type; this.content = content; this.stat = stat; } - + public PathChangeModel getPath(String path) { if (stat == null) { return null; @@ -98,15 +119,15 @@ public static class DiffStat implements Serializable { private static final long serialVersionUID = 1L; - + public final List<PathChangeModel> paths = new ArrayList<PathChangeModel>(); - + private final String commitId; - + public DiffStat(String commitId) { this.commitId = commitId; } - + public PathChangeModel addPath(DiffEntry entry) { PathChangeModel pcm = PathChangeModel.from(entry, commitId); paths.add(pcm); @@ -128,7 +149,7 @@ } return val; } - + public PathChangeModel getPath(String path) { PathChangeModel stat = null; for (PathChangeModel p : paths) { @@ -138,7 +159,7 @@ } } return stat; - } + } @Override public String toString() { @@ -150,15 +171,15 @@ return sb.toString(); } } - + public static class NormalizedDiffStat implements Serializable { - + private static final long serialVersionUID = 1L; - + public final int insertions; public final int deletions; public final int blanks; - + NormalizedDiffStat(int insertions, int deletions, int blanks) { this.insertions = insertions; this.deletions = deletions; @@ -181,6 +202,23 @@ } /** + * Returns the complete diff of the specified commit compared to its primary parent. + * + * @param repository + * @param commit + * @param outputType + * @param handler + * to use for rendering binary diffs if {@code outputType} is {@link DiffOutputType#HTML HTML}. + * May be {@code null}, resulting in the default behavior. + * @return the diff + */ + public static DiffOutput getCommitDiff(Repository repository, RevCommit commit, + DiffOutputType outputType, BinaryDiffHandler handler) { + return getDiff(repository, null, commit, null, outputType, handler); + } + + + /** * Returns the diff for the specified file or folder from the specified * commit compared to its primary parent. * @@ -196,6 +234,24 @@ } /** + * Returns the diff for the specified file or folder from the specified + * commit compared to its primary parent. + * + * @param repository + * @param commit + * @param path + * @param outputType + * @param handler + * to use for rendering binary diffs if {@code outputType} is {@link DiffOutputType#HTML HTML}. + * May be {@code null}, resulting in the default behavior. + * @return the diff + */ + public static DiffOutput getDiff(Repository repository, RevCommit commit, String path, + DiffOutputType outputType, BinaryDiffHandler handler) { + return getDiff(repository, null, commit, path, outputType, handler); + } + + /** * Returns the complete diff between the two specified commits. * * @param repository @@ -207,6 +263,23 @@ public static DiffOutput getDiff(Repository repository, RevCommit baseCommit, RevCommit commit, DiffOutputType outputType) { return getDiff(repository, baseCommit, commit, null, outputType); + } + + /** + * Returns the complete diff between the two specified commits. + * + * @param repository + * @param baseCommit + * @param commit + * @param outputType + * @param handler + * to use for rendering binary diffs if {@code outputType} is {@link DiffOutputType#HTML HTML}. + * May be {@code null}, resulting in the default behavior. + * @return the diff + */ + public static DiffOutput getDiff(Repository repository, RevCommit baseCommit, RevCommit commit, + DiffOutputType outputType, BinaryDiffHandler handler) { + return getDiff(repository, baseCommit, commit, null, outputType, handler); } /** @@ -225,18 +298,41 @@ */ public static DiffOutput getDiff(Repository repository, RevCommit baseCommit, RevCommit commit, String path, DiffOutputType outputType) { + return getDiff(repository, baseCommit, commit, path, outputType, null); + } + + /** + * Returns the diff between two commits for the specified file. + * + * @param repository + * @param baseCommit + * if base commit is null the diff is to the primary parent of + * the commit. + * @param commit + * @param path + * if the path is specified, the diff is restricted to that file + * or folder. if unspecified, the diff is for the entire commit. + * @param outputType + * @param handler + * to use for rendering binary diffs if {@code outputType} is {@link DiffOutputType#HTML HTML}. + * May be {@code null}, resulting in the default behavior. + * @return the diff + */ + public static DiffOutput getDiff(Repository repository, RevCommit baseCommit, RevCommit commit, String path, DiffOutputType outputType, + final BinaryDiffHandler handler) { DiffStat stat = null; String diff = null; try { - final ByteArrayOutputStream os = new ByteArrayOutputStream(); + ByteArrayOutputStream os = null; RawTextComparator cmp = RawTextComparator.DEFAULT; DiffFormatter df; switch (outputType) { case HTML: - df = new GitBlitDiffFormatter(os, commit.getName()); + df = new GitBlitDiffFormatter(commit.getName(), path, handler); break; case PLAIN: default: + os = new ByteArrayOutputStream(); df = new DiffFormatter(os); break; } @@ -271,6 +367,7 @@ } else { df.format(diffEntries); } + df.flush(); if (df instanceof GitBlitDiffFormatter) { // workaround for complex private methods in DiffFormatter diff = ((GitBlitDiffFormatter) df).getHtml(); @@ -278,11 +375,10 @@ } else { diff = os.toString(); } - df.flush(); } catch (Throwable t) { LOGGER.error("failed to generate commit diff!", t); } - + return new DiffOutput(outputType, diff, stat); } @@ -344,6 +440,38 @@ LOGGER.error("failed to generate commit diff!", t); } return diff; + } + + /** + * Returns the diffstat between the two commits for the specified file or folder. + * + * @param repository + * @param base + * if base commit is unspecified, the diffstat is generated against + * the primary parent of the specified tip. + * @param tip + * @param path + * if path is specified, the diffstat is generated only for the + * specified file or folder. if unspecified, the diffstat is + * generated for the entire diff between the two commits. + * @return patch as a string + */ + public static DiffStat getDiffStat(Repository repository, String base, String tip) { + RevCommit baseCommit = null; + RevCommit tipCommit = null; + RevWalk revWalk = new RevWalk(repository); + try { + tipCommit = revWalk.parseCommit(repository.resolve(tip)); + if (!StringUtils.isEmpty(base)) { + baseCommit = revWalk.parseCommit(repository.resolve(base)); + } + return getDiffStat(repository, baseCommit, tipCommit, null); + } catch (Exception e) { + LOGGER.error("failed to generate diffstat!", e); + } finally { + revWalk.dispose(); + } + return null; } public static DiffStat getDiffStat(Repository repository, RevCommit commit) { @@ -442,10 +570,10 @@ } return lines; } - + /** * Normalizes a diffstat to an N-segment display. - * + * * @params segments * @param insertions * @param deletions @@ -482,7 +610,7 @@ sd = segments - si; sb = 0; } - + return new NormalizedDiffStat(si, sd, sb); } } -- Gitblit v1.9.1