From 6c5511020457c39961d069071ac60f7140ec724f Mon Sep 17 00:00:00 2001 From: Lukasz Jader <ljaderdev@gmail.com> Date: Wed, 19 Sep 2012 16:24:10 -0400 Subject: [PATCH] Update polish translation of EmptyRepositoryPage --- src/com/gitblit/wicket/AuthorizationStrategy.java | 39 ++++++++++++++++++++++----------------- 1 files changed, 22 insertions(+), 17 deletions(-) diff --git a/src/com/gitblit/wicket/AuthorizationStrategy.java b/src/com/gitblit/wicket/AuthorizationStrategy.java index 892153e..16a4ec8 100644 --- a/src/com/gitblit/wicket/AuthorizationStrategy.java +++ b/src/com/gitblit/wicket/AuthorizationStrategy.java @@ -16,16 +16,18 @@ package com.gitblit.wicket; import org.apache.wicket.Component; -import org.apache.wicket.RestartResponseAtInterceptPageException; +import org.apache.wicket.RestartResponseException; import org.apache.wicket.authorization.IUnauthorizedComponentInstantiationListener; import org.apache.wicket.authorization.strategies.page.AbstractPageAuthorizationStrategy; import com.gitblit.GitBlit; import com.gitblit.Keys; -import com.gitblit.wicket.models.UserModel; +import com.gitblit.models.UserModel; +import com.gitblit.wicket.pages.BasePage; import com.gitblit.wicket.pages.RepositoriesPage; -public class AuthorizationStrategy extends AbstractPageAuthorizationStrategy implements IUnauthorizedComponentInstantiationListener { +public class AuthorizationStrategy extends AbstractPageAuthorizationStrategy implements + IUnauthorizedComponentInstantiationListener { public AuthorizationStrategy() { } @@ -33,25 +35,32 @@ @SuppressWarnings({ "unchecked", "rawtypes" }) @Override protected boolean isPageAuthorized(Class pageClass) { + if (RepositoriesPage.class.equals(pageClass)) { + // allow all requests to get to the RepositoriesPage with its inline + // authentication form + return true; + } + if (BasePage.class.isAssignableFrom(pageClass)) { - boolean authenticateView = GitBlit.self().settings().getBoolean(Keys.web.authenticateViewPages, true); - boolean authenticateAdmin = GitBlit.self().settings().getBoolean(Keys.web.authenticateAdminPages, true); - boolean allowAdmin = GitBlit.self().settings().getBoolean(Keys.web.allowAdministration, true); - - GitBlitWebSession session = GitBlitWebSession.get(); + boolean authenticateView = GitBlit.getBoolean(Keys.web.authenticateViewPages, true); + boolean authenticateAdmin = GitBlit.getBoolean(Keys.web.authenticateAdminPages, true); + boolean allowAdmin = GitBlit.getBoolean(Keys.web.allowAdministration, true); + + GitBlitWebSession session = GitBlitWebSession.get(); if (authenticateView && !session.isLoggedIn()) { // authentication required + session.cacheRequest(pageClass); return false; } - + UserModel user = session.getUser(); - if (pageClass.isAnnotationPresent(AdminPage.class)) { + if (pageClass.isAnnotationPresent(RequiresAdminRole.class)) { // admin page if (allowAdmin) { if (authenticateAdmin) { // authenticate admin if (user != null) { - return user.canAdmin(); + return user.canAdmin; } return false; } else { @@ -59,7 +68,7 @@ return true; } } else { - //admin prohibited + // admin prohibited return false; } } @@ -70,11 +79,7 @@ @Override public void onUnauthorizedInstantiation(Component component) { if (component instanceof BasePage) { - GitBlitWebSession session = GitBlitWebSession.get(); - if (!session.isLoggedIn()) - throw new RestartResponseAtInterceptPageException(LoginPage.class); - else - throw new RestartResponseAtInterceptPageException(RepositoriesPage.class); + throw new RestartResponseException(RepositoriesPage.class); } } } -- Gitblit v1.9.1