From 68fb1791fa8033d464d50e45481d04c3e3d0a025 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Thu, 17 Apr 2014 23:08:07 -0400 Subject: [PATCH] [findbugs] Add null check when testing if a user is disabled in SessionPage --- src/main/java/com/gitblit/wicket/pages/SessionPage.java | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/gitblit/wicket/pages/SessionPage.java b/src/main/java/com/gitblit/wicket/pages/SessionPage.java index 909342a..7a58175 100644 --- a/src/main/java/com/gitblit/wicket/pages/SessionPage.java +++ b/src/main/java/com/gitblit/wicket/pages/SessionPage.java @@ -56,8 +56,8 @@ // any changes to permissions or roles (issue-186) UserModel user = app().users().getUserModel(session.getUser().username); - if (user.disabled) { - // user was disabled during session + if (user == null || user.disabled) { + // user was deleted/disabled during session HttpServletResponse response = ((WebResponse) getRequestCycle().getResponse()) .getHttpServletResponse(); app().authentication().logout(response, user); -- Gitblit v1.9.1