From 668663dffb73722e2fae12d9f737d80cd54b3f03 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Tue, 24 Apr 2012 17:56:23 -0400 Subject: [PATCH] Updated the key generator to build nested key classes --- src/com/gitblit/GitBlit.java | 34 ++++++++++++++++++++-------------- 1 files changed, 20 insertions(+), 14 deletions(-) diff --git a/src/com/gitblit/GitBlit.java b/src/com/gitblit/GitBlit.java index 6ed54dc..2b7ba3c 100644 --- a/src/com/gitblit/GitBlit.java +++ b/src/com/gitblit/GitBlit.java @@ -1066,29 +1066,35 @@ config.setBoolean("gitblit", null, "showReadme", repository.showReadme); config.setBoolean("gitblit", null, "skipSizeCalculation", repository.skipSizeCalculation); config.setBoolean("gitblit", null, "skipSummaryMetrics", repository.skipSummaryMetrics); - config.setStringList("gitblit", null, "federationSets", repository.federationSets); config.setString("gitblit", null, "federationStrategy", repository.federationStrategy.name()); config.setBoolean("gitblit", null, "isFederated", repository.isFederated); - if (!ArrayUtils.isEmpty(repository.preReceiveScripts)) { - config.setStringList("gitblit", null, "preReceiveScript", repository.preReceiveScripts); - } - if (!ArrayUtils.isEmpty(repository.postReceiveScripts)) { - config.setStringList("gitblit", null, "postReceiveScript", - repository.postReceiveScripts); - } - if (!ArrayUtils.isEmpty(repository.mailingLists)) { - config.setStringList("gitblit", null, "mailingList", repository.mailingLists); - } - if (!ArrayUtils.isEmpty(repository.indexedBranches)) { - config.setStringList("gitblit", null, "indexBranch", repository.indexedBranches); - } + + updateList(config, "federationSets", repository.federationSets); + updateList(config, "preReceiveScript", repository.preReceiveScripts); + updateList(config, "postReceiveScript", repository.postReceiveScripts); + updateList(config, "mailingList", repository.mailingLists); + updateList(config, "indexBranch", repository.indexedBranches); + try { config.save(); } catch (IOException e) { logger.error("Failed to save repository config!", e); } } + + private void updateList(StoredConfig config, String field, List<String> list) { + // a null list is skipped, not cleared + // this is for RPC administration where an older manager might be used + if (list == null) { + return; + } + if (ArrayUtils.isEmpty(list)) { + config.unset("gitblit", null, field); + } else { + config.setStringList("gitblit", null, field, list); + } + } /** * Deletes the repository from the file system and removes the repository -- Gitblit v1.9.1