From 4fcac9d2cbdafb51e3ee9ca3b3da64fd86103174 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Tue, 26 Nov 2013 15:58:15 -0500 Subject: [PATCH] Remove artifact setting from manager dialog --- src/main/java/com/gitblit/wicket/pages/RootPage.java | 126 +++++++++++++++++++++++++++++++++-------- 1 files changed, 101 insertions(+), 25 deletions(-) diff --git a/src/main/java/com/gitblit/wicket/pages/RootPage.java b/src/main/java/com/gitblit/wicket/pages/RootPage.java index e8d1007..a59e202 100644 --- a/src/main/java/com/gitblit/wicket/pages/RootPage.java +++ b/src/main/java/com/gitblit/wicket/pages/RootPage.java @@ -33,6 +33,9 @@ import org.apache.wicket.MarkupContainer; import org.apache.wicket.PageParameters; +import org.apache.wicket.behavior.HeaderContributor; +import org.apache.wicket.markup.html.IHeaderContributor; +import org.apache.wicket.markup.html.IHeaderResponse; import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.form.PasswordTextField; import org.apache.wicket.markup.html.form.TextField; @@ -48,10 +51,12 @@ import com.gitblit.models.RepositoryModel; import com.gitblit.models.TeamModel; import com.gitblit.models.UserModel; +import com.gitblit.utils.ModelUtils; import com.gitblit.utils.StringUtils; import com.gitblit.wicket.GitBlitWebSession; import com.gitblit.wicket.PageRegistration; import com.gitblit.wicket.PageRegistration.DropDownMenuItem; +import com.gitblit.wicket.PageRegistration.DropDownToggleItem; import com.gitblit.wicket.SessionlessForm; import com.gitblit.wicket.WicketUtils; import com.gitblit.wicket.panels.GravatarImage; @@ -60,9 +65,9 @@ /** * Root page is a topbar, navigable page like Repositories, Users, or * Federation. - * + * * @author James Moger - * + * */ public abstract class RootPage extends BasePage { @@ -82,6 +87,51 @@ @Override protected void setupPage(String repositoryName, String pageName) { + + // CSS header overrides + add(new HeaderContributor(new IHeaderContributor() { + private static final long serialVersionUID = 1L; + + @Override + public void renderHead(IHeaderResponse response) { + StringBuilder buffer = new StringBuilder(); + buffer.append("<style type=\"text/css\">\n"); + buffer.append(".navbar-inner {\n"); + final String headerBackground = GitBlit.getString(Keys.web.headerBackgroundColor, null); + if (!StringUtils.isEmpty(headerBackground)) { + buffer.append(MessageFormat.format("background-color: {0};\n", headerBackground)); + } + final String headerBorder = GitBlit.getString(Keys.web.headerBorderColor, null); + if (!StringUtils.isEmpty(headerBorder)) { + buffer.append(MessageFormat.format("border-bottom: 1px solid {0} !important;\n", headerBorder)); + } + buffer.append("}\n"); + final String headerBorderFocus = GitBlit.getString(Keys.web.headerBorderFocusColor, null); + if (!StringUtils.isEmpty(headerBorderFocus)) { + buffer.append(".navbar ul li:focus, .navbar .active {\n"); + buffer.append(MessageFormat.format("border-bottom: 4px solid {0};\n", headerBorderFocus)); + buffer.append("}\n"); + } + final String headerForeground = GitBlit.getString(Keys.web.headerForegroundColor, null); + if (!StringUtils.isEmpty(headerForeground)) { + buffer.append(".navbar ul.nav li a {\n"); + buffer.append(MessageFormat.format("color: {0};\n", headerForeground)); + buffer.append("}\n"); + buffer.append(".navbar ul.nav .active a {\n"); + buffer.append(MessageFormat.format("color: {0};\n", headerForeground)); + buffer.append("}\n"); + } + final String headerHover = GitBlit.getString(Keys.web.headerHoverColor, null); + if (!StringUtils.isEmpty(headerHover)) { + buffer.append(".navbar ul.nav li a:hover {\n"); + buffer.append(MessageFormat.format("color: {0} !important;\n", headerHover)); + buffer.append("}\n"); + } + buffer.append("</style>\n"); + response.renderString(buffer.toString()); + } + })); + boolean authenticateView = GitBlit.getBoolean(Keys.web.authenticateViewPages, false); boolean authenticateAdmin = GitBlit.getBoolean(Keys.web.authenticateAdminPages, true); boolean allowAdmin = GitBlit.getBoolean(Keys.web.allowAdministration, true); @@ -100,7 +150,7 @@ setStatelessHint(true); } } - + if (authenticateView || authenticateAdmin) { if (GitBlitWebSession.get().isLoggedIn()) { UserMenu userFragment = new UserMenu("userPanel", "userMenuFragment", RootPage.this); @@ -112,14 +162,14 @@ } else { add(new Label("userPanel").setVisible(false)); } - + boolean showRegistrations = GitBlit.canFederate() && GitBlit.getBoolean(Keys.web.showFederationRegistrations, false); // navigation links List<PageRegistration> pages = new ArrayList<PageRegistration>(); if (!authenticateView || (authenticateView && GitBlitWebSession.get().isLoggedIn())) { - pages.add(new PageRegistration(GitBlitWebSession.get().isLoggedIn() ? "gb.myDashboard" : "gb.dashboard", DashboardPage.class, + pages.add(new PageRegistration(GitBlitWebSession.get().isLoggedIn() ? "gb.myDashboard" : "gb.dashboard", MyDashboardPage.class, getRootPageParameters())); pages.add(new PageRegistration("gb.repositories", RepositoriesPage.class, getRootPageParameters())); @@ -138,7 +188,7 @@ addDropDownMenus(pages); } } - + NavigationPanel navPanel = new NavigationPanel("navPanel", getRootNavPageClass(), pages); add(navPanel); @@ -158,7 +208,7 @@ super.setupPage(repositoryName, pageName); } - + protected Class<? extends BasePage> getRootNavPageClass() { return getClass(); } @@ -183,7 +233,7 @@ params.remove("db"); } return params; - } + } } return null; } @@ -220,7 +270,7 @@ } } } - + protected List<RepositoryModel> getRepositoryModels() { if (repositoryModels.isEmpty()) { final UserModel user = GitBlitWebSession.get().getUser(); @@ -256,7 +306,7 @@ List<String> sets = new ArrayList<String>(setMap.keySet()); Collections.sort(sets); for (String set : sets) { - filters.add(new DropDownMenuItem(MessageFormat.format("{0} ({1})", set, + filters.add(new DropDownToggleItem(MessageFormat.format("{0} ({1})", set, setMap.get(set).get()), "set", set, params)); } // divider @@ -268,7 +318,7 @@ List<TeamModel> teams = new ArrayList<TeamModel>(user.teams); Collections.sort(teams); for (TeamModel team : teams) { - filters.add(new DropDownMenuItem(MessageFormat.format("{0} ({1})", team.name, + filters.add(new DropDownToggleItem(MessageFormat.format("{0} ({1})", team.name, team.repositories.size()), "team", team.name, params)); } // divider @@ -283,7 +333,7 @@ for (String expression : expressions) { if (!StringUtils.isEmpty(expression)) { addedExpression = true; - filters.add(new DropDownMenuItem(null, "x", expression, params)); + filters.add(new DropDownToggleItem(null, "x", expression, params)); } } // if we added any custom expressions, add a divider @@ -297,20 +347,39 @@ protected List<DropDownMenuItem> getTimeFilterItems(PageParameters params) { // days back choices - additive parameters int daysBack = GitBlit.getInteger(Keys.web.activityDuration, 7); + int maxDaysBack = GitBlit.getInteger(Keys.web.activityDurationMaximum, 30); if (daysBack < 1) { daysBack = 7; } + if (daysBack > maxDaysBack) { + daysBack = maxDaysBack; + } + PageParameters clonedParams; + if (params == null) { + clonedParams = new PageParameters(); + } else { + clonedParams = new PageParameters(params); + } + + if (!clonedParams.containsKey("db")) { + clonedParams.put("db", daysBack); + } + List<DropDownMenuItem> items = new ArrayList<DropDownMenuItem>(); Set<Integer> choicesSet = new TreeSet<Integer>(GitBlit.getIntegers(Keys.web.activityDurationChoices)); if (choicesSet.isEmpty()) { - choicesSet.addAll(Arrays.asList(7, 14, 28, 60, 90, 180)); + choicesSet.addAll(Arrays.asList(1, 3, 7, 14, 21, 28)); } List<Integer> choices = new ArrayList<Integer>(choicesSet); Collections.sort(choices); String lastDaysPattern = getString("gb.lastNDays"); for (Integer db : choices) { - String txt = MessageFormat.format(lastDaysPattern, db); - items.add(new DropDownMenuItem(txt, "db", db.toString(), params)); + if (db == 1) { + items.add(new DropDownMenuItem(getString("gb.time.today"), "db", db.toString(), clonedParams)); + } else { + String txt = MessageFormat.format(lastDaysPattern, db); + items.add(new DropDownMenuItem(txt, "db", db.toString(), clonedParams)); + } } items.add(new DropDownMenuItem()); return items; @@ -326,7 +395,7 @@ String userName = WicketUtils.getUsername(params); if (StringUtils.isEmpty(projectName)) { if (!StringUtils.isEmpty(userName)) { - projectName = "~" + userName; + projectName = ModelUtils.getPersonalPath(userName); } } String repositoryName = WicketUtils.getRepositoryName(params); @@ -334,6 +403,7 @@ String regex = WicketUtils.getRegEx(params); String team = WicketUtils.getTeam(params); int daysBack = params.getInt("db", 0); + int maxDaysBack = GitBlit.getInteger(Keys.web.activityDurationMaximum, 30); List<RepositoryModel> availableModels = getRepositoryModels(); Set<RepositoryModel> models = new HashSet<RepositoryModel>(); @@ -351,7 +421,7 @@ if (!StringUtils.isEmpty(projectName)) { // try named project - hasParameter = true; + hasParameter = true; if (projectName.equalsIgnoreCase(GitBlit.getString(Keys.web.repositoryRootGroupName, "main"))) { // root project/group for (RepositoryModel model : availableModels) { @@ -424,6 +494,9 @@ // time-filter the list if (daysBack > 0) { + if (maxDaysBack > 0 && daysBack > maxDaysBack) { + daysBack = maxDaysBack; + } Calendar cal = Calendar.getInstance(); cal.set(Calendar.HOUR_OF_DAY, 0); cal.set(Calendar.MINUTE, 0); @@ -439,14 +512,14 @@ } models = timeFiltered; } - + List<RepositoryModel> list = new ArrayList<RepositoryModel>(models); Collections.sort(list); return list; } - + /** - * Inline login form. + * Inline login form. */ private class LoginForm extends Fragment { private static final long serialVersionUID = 1L; @@ -486,7 +559,7 @@ add(loginForm); } } - + /** * Menu for the authenticated user. */ @@ -511,13 +584,16 @@ } add(new Label("displayName", user.getDisplayName())); - - add(new BookmarkablePageLink<Void>("myProfile", + + add(new BookmarkablePageLink<Void>("newRepository", + EditRepositoryPage.class).setVisible(user.canAdmin() || user.canCreate())); + + add(new BookmarkablePageLink<Void>("myProfile", UserPage.class, WicketUtils.newUsernameParameter(user.username))); - add(new BookmarkablePageLink<Void>("changePassword", + add(new BookmarkablePageLink<Void>("changePassword", ChangePasswordPage.class).setVisible(editCredentials)); - + add(new BookmarkablePageLink<Void>("logout", LogoutPage.class).setVisible(standardLogin)); } -- Gitblit v1.9.1