From 3f5b8f5d9203aa7ffb7fbe9cdbaf9dba3da6cae6 Mon Sep 17 00:00:00 2001 From: Hybris95 <hybris_95@hotmail.com> Date: Thu, 01 May 2014 16:14:15 -0400 Subject: [PATCH] Fixes sort, page building and search functions on "my tickets" page. --- src/main/java/com/gitblit/servlet/FederationServlet.java | 40 +++++++++++++++++++++------------------- 1 files changed, 21 insertions(+), 19 deletions(-) diff --git a/src/main/java/com/gitblit/servlet/FederationServlet.java b/src/main/java/com/gitblit/servlet/FederationServlet.java index 8d352fe..8dbf0e1 100644 --- a/src/main/java/com/gitblit/servlet/FederationServlet.java +++ b/src/main/java/com/gitblit/servlet/FederationServlet.java @@ -32,7 +32,6 @@ import com.gitblit.Keys; import com.gitblit.manager.IFederationManager; import com.gitblit.manager.IRepositoryManager; -import com.gitblit.manager.IRuntimeManager; import com.gitblit.manager.IUserManager; import com.gitblit.models.FederationModel; import com.gitblit.models.FederationProposal; @@ -44,6 +43,8 @@ import com.gitblit.utils.StringUtils; import com.gitblit.utils.TimeUtils; +import dagger.ObjectGraph; + /** * Handles federation requests. * @@ -54,25 +55,20 @@ private static final long serialVersionUID = 1L; - private final IStoredSettings settings; + private IStoredSettings settings; - private final IUserManager userManager; + private IUserManager userManager; - private final IRepositoryManager repositoryManager; + private IRepositoryManager repositoryManager; - private final IFederationManager federationManager; + private IFederationManager federationManager; - public FederationServlet( - IRuntimeManager runtimeManager, - IUserManager userManager, - IRepositoryManager repositoryManager, - IFederationManager federationManager) { - - super(); - this.settings = runtimeManager.getSettings(); - this.userManager = userManager; - this.repositoryManager = repositoryManager; - this.federationManager = federationManager; + @Override + protected void inject(ObjectGraph dagger) { + this.settings = dagger.get(IStoredSettings.class); + this.userManager = dagger.get(IUserManager.class); + this.repositoryManager = dagger.get(IRepositoryManager.class); + this.federationManager = dagger.get(IFederationManager.class); } /** @@ -142,8 +138,11 @@ return; } - String url = HttpUtils.getGitblitURL(request); - federationManager.submitFederationProposal(proposal, url); + String gitblitUrl = settings.getString(Keys.web.canonicalUrl, null); + if (StringUtils.isEmpty(gitblitUrl)) { + gitblitUrl = HttpUtils.getGitblitURL(request); + } + federationManager.submitFederationProposal(proposal, gitblitUrl); logger.info(MessageFormat.format( "Submitted {0} federation proposal to pull {1} repositories from {2}", proposal.tokenType.name(), proposal.repositories.size(), proposal.url)); @@ -189,7 +188,10 @@ Object result = null; if (FederationRequest.PULL_REPOSITORIES.equals(reqType)) { - String gitblitUrl = HttpUtils.getGitblitURL(request); + String gitblitUrl = settings.getString(Keys.web.canonicalUrl, null); + if (StringUtils.isEmpty(gitblitUrl)) { + gitblitUrl = HttpUtils.getGitblitURL(request); + } result = federationManager.getRepositories(gitblitUrl, token); } else { if (FederationRequest.PULL_SETTINGS.equals(reqType)) { -- Gitblit v1.9.1