From 33d8d8b21c5586f1328c8c3e7f6049037ae5fd0d Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Fri, 04 Nov 2011 17:22:06 -0400
Subject: [PATCH] Moved SearchType enum to Constants

---
 src/com/gitblit/SyndicationServlet.java          |    5 -
 src/com/gitblit/wicket/pages/RepositoryPage.java |   20 +++---
 src/com/gitblit/wicket/panels/BasePanel.java     |    8 +-
 src/com/gitblit/utils/SyndicationUtils.java      |    4 -
 src/com/gitblit/wicket/WicketUtils.java          |    6 +-
 src/com/gitblit/wicket/pages/CommitPage.java     |    8 +-
 src/com/gitblit/wicket/panels/HistoryPanel.java  |    6 +-
 src/com/gitblit/wicket/pages/SearchPage.java     |    4 
 tests/com/gitblit/tests/JGitUtilsTest.java       |   27 ++++----
 src/com/gitblit/wicket/panels/SearchPanel.java   |    8 +-
 src/com/gitblit/wicket/panels/BranchesPanel.java |    6 +-
 src/com/gitblit/wicket/panels/LogPanel.java      |    6 +-
 src/com/gitblit/wicket/pages/TagPage.java        |    3 
 src/com/gitblit/Constants.java                   |   21 +++++++
 src/com/gitblit/utils/JGitUtils.java             |   23 -------
 15 files changed, 75 insertions(+), 80 deletions(-)

diff --git a/src/com/gitblit/Constants.java b/src/com/gitblit/Constants.java
index 2543ea1..3204a55 100644
--- a/src/com/gitblit/Constants.java
+++ b/src/com/gitblit/Constants.java
@@ -227,4 +227,25 @@
 			return name();
 		}
 	}
+
+	/**
+	 * Enumeration of the search types.
+	 */
+	public static enum SearchType {
+		AUTHOR, COMMITTER, COMMIT;
+	
+		public static SearchType forName(String name) {
+			for (SearchType type : values()) {
+				if (type.name().equalsIgnoreCase(name)) {
+					return type;
+				}
+			}
+			return COMMIT;
+		}
+	
+		@Override
+		public String toString() {
+			return name().toLowerCase();
+		}
+	}
 }
diff --git a/src/com/gitblit/SyndicationServlet.java b/src/com/gitblit/SyndicationServlet.java
index af0fab7..128df43 100644
--- a/src/com/gitblit/SyndicationServlet.java
+++ b/src/com/gitblit/SyndicationServlet.java
@@ -33,7 +33,6 @@
 import com.gitblit.models.SyndicatedEntryModel;
 import com.gitblit.utils.HttpUtils;
 import com.gitblit.utils.JGitUtils;
-import com.gitblit.utils.JGitUtils.SearchType;
 import com.gitblit.utils.StringUtils;
 import com.gitblit.utils.SyndicationUtils;
 
@@ -131,9 +130,9 @@
 		String objectId = request.getParameter("h");
 		String l = request.getParameter("l");
 		String searchString = request.getParameter("s");
-		SearchType searchType = SearchType.COMMIT;
+		Constants.SearchType searchType = Constants.SearchType.COMMIT;
 		if (!StringUtils.isEmpty(request.getParameter("st"))) {
-			SearchType type = SearchType.forName(request.getParameter("st"));
+			Constants.SearchType type = Constants.SearchType.forName(request.getParameter("st"));
 			if (type != null) {
 				searchType = type;
 			}
diff --git a/src/com/gitblit/utils/JGitUtils.java b/src/com/gitblit/utils/JGitUtils.java
index 80147d4..c61b3d9 100644
--- a/src/com/gitblit/utils/JGitUtils.java
+++ b/src/com/gitblit/utils/JGitUtils.java
@@ -925,27 +925,6 @@
 	}
 
 	/**
-	 * Enumeration of the search types.
-	 */
-	public static enum SearchType {
-		AUTHOR, COMMITTER, COMMIT;
-
-		public static SearchType forName(String name) {
-			for (SearchType type : values()) {
-				if (type.name().equalsIgnoreCase(name)) {
-					return type;
-				}
-			}
-			return COMMIT;
-		}
-
-		@Override
-		public String toString() {
-			return name().toLowerCase();
-		}
-	}
-
-	/**
 	 * Search the commit history for a case-insensitive match to the value.
 	 * Search results require a specified SearchType of AUTHOR, COMMITTER, or
 	 * COMMIT. Results may be paginated using offset and maxCount. If the
@@ -963,7 +942,7 @@
 	 * @return matching list of commits
 	 */
 	public static List<RevCommit> searchRevlogs(Repository repository, String objectId,
-			String value, final SearchType type, int offset, int maxCount) {
+			String value, final com.gitblit.Constants.SearchType type, int offset, int maxCount) {
 		final String lcValue = value.toLowerCase();
 		List<RevCommit> list = new ArrayList<RevCommit>();
 		if (maxCount == 0) {
diff --git a/src/com/gitblit/utils/SyndicationUtils.java b/src/com/gitblit/utils/SyndicationUtils.java
index 85d5f8d..4ba5622 100644
--- a/src/com/gitblit/utils/SyndicationUtils.java
+++ b/src/com/gitblit/utils/SyndicationUtils.java
@@ -22,13 +22,11 @@
 import java.net.URLConnection;
 import java.text.MessageFormat;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.List;
 
 import com.gitblit.Constants;
 import com.gitblit.GitBlitException;
 import com.gitblit.models.SyndicatedEntryModel;
-import com.gitblit.utils.JGitUtils.SearchType;
 import com.sun.syndication.feed.synd.SyndCategory;
 import com.sun.syndication.feed.synd.SyndCategoryImpl;
 import com.sun.syndication.feed.synd.SyndContent;
@@ -163,7 +161,7 @@
 	 * @throws {@link IOException}
 	 */
 	public static List<SyndicatedEntryModel> readSearchFeed(String url, String repository,
-			String branch, String fragment, SearchType searchType, int numberOfEntries,
+			String branch, String fragment, Constants.SearchType searchType, int numberOfEntries,
 			String username, char[] password) throws IOException {
 		// determine parameters
 		List<String> parameters = new ArrayList<String>();
diff --git a/src/com/gitblit/wicket/WicketUtils.java b/src/com/gitblit/wicket/WicketUtils.java
index e5b7f69..f47663c 100644
--- a/src/com/gitblit/wicket/WicketUtils.java
+++ b/src/com/gitblit/wicket/WicketUtils.java
@@ -39,13 +39,13 @@
 import org.wicketstuff.googlecharts.AbstractChartData;
 import org.wicketstuff.googlecharts.IChartData;
 
+import com.gitblit.Constants;
 import com.gitblit.Constants.FederationPullStatus;
 import com.gitblit.GitBlit;
 import com.gitblit.Keys;
 import com.gitblit.models.FederationModel;
 import com.gitblit.models.Metric;
 import com.gitblit.utils.HttpUtils;
-import com.gitblit.utils.JGitUtils.SearchType;
 import com.gitblit.utils.StringUtils;
 import com.gitblit.utils.TimeUtils;
 
@@ -311,7 +311,7 @@
 	}
 
 	public static PageParameters newSearchParameter(String repositoryName, String commitId,
-			String search, SearchType type) {
+			String search, Constants.SearchType type) {
 		if (StringUtils.isEmpty(commitId)) {
 			return new PageParameters("r=" + repositoryName + ",s=" + search + ",st=" + type.name());
 		}
@@ -320,7 +320,7 @@
 	}
 
 	public static PageParameters newSearchParameter(String repositoryName, String commitId,
-			String search, SearchType type, int pageNumber) {
+			String search, Constants.SearchType type, int pageNumber) {
 		if (StringUtils.isEmpty(commitId)) {
 			return new PageParameters("r=" + repositoryName + ",s=" + search + ",st=" + type.name()
 					+ ",page=" + pageNumber);
diff --git a/src/com/gitblit/wicket/pages/CommitPage.java b/src/com/gitblit/wicket/pages/CommitPage.java
index ad33446..dd3decb 100644
--- a/src/com/gitblit/wicket/pages/CommitPage.java
+++ b/src/com/gitblit/wicket/pages/CommitPage.java
@@ -31,13 +31,13 @@
 import org.eclipse.jgit.lib.Repository;
 import org.eclipse.jgit.revwalk.RevCommit;
 
+import com.gitblit.Constants;
 import com.gitblit.DownloadZipServlet;
 import com.gitblit.GitBlit;
 import com.gitblit.Keys;
 import com.gitblit.models.GitNote;
 import com.gitblit.models.PathModel.PathChangeModel;
 import com.gitblit.utils.JGitUtils;
-import com.gitblit.utils.JGitUtils.SearchType;
 import com.gitblit.wicket.WicketUtils;
 import com.gitblit.wicket.panels.CommitHeaderPanel;
 import com.gitblit.wicket.panels.CommitLegendPanel;
@@ -78,12 +78,12 @@
 		addRefs(r, c);
 
 		// author
-		add(createPersonPanel("commitAuthor", c.getAuthorIdent(), SearchType.AUTHOR));
+		add(createPersonPanel("commitAuthor", c.getAuthorIdent(), Constants.SearchType.AUTHOR));
 		add(WicketUtils.createTimestampLabel("commitAuthorDate", c.getAuthorIdent().getWhen(),
 				getTimeZone()));
 
 		// committer
-		add(createPersonPanel("commitCommitter", c.getCommitterIdent(), SearchType.COMMITTER));
+		add(createPersonPanel("commitCommitter", c.getCommitterIdent(), Constants.SearchType.COMMITTER));
 		add(WicketUtils.createTimestampLabel("commitCommitterDate",
 				c.getCommitterIdent().getWhen(), getTimeZone()));
 
@@ -125,7 +125,7 @@
 				GitNote entry = item.getModelObject();
 				item.add(new RefsPanel("refName", repositoryName, Arrays.asList(entry.notesRef)));
 				item.add(createPersonPanel("authorName", entry.notesRef.getAuthorIdent(),
-						SearchType.AUTHOR));
+						Constants.SearchType.AUTHOR));
 				item.add(WicketUtils.createTimestampLabel("authorDate", entry.notesRef
 						.getAuthorIdent().getWhen(), getTimeZone()));
 				item.add(new Label("noteContent", GitBlit.self().processCommitMessage(
diff --git a/src/com/gitblit/wicket/pages/RepositoryPage.java b/src/com/gitblit/wicket/pages/RepositoryPage.java
index 2d616a4..4c417d9 100644
--- a/src/com/gitblit/wicket/pages/RepositoryPage.java
+++ b/src/com/gitblit/wicket/pages/RepositoryPage.java
@@ -38,12 +38,12 @@
 import org.eclipse.jgit.lib.Repository;
 import org.eclipse.jgit.revwalk.RevCommit;
 
+import com.gitblit.Constants;
 import com.gitblit.GitBlit;
 import com.gitblit.Keys;
 import com.gitblit.SyndicationServlet;
 import com.gitblit.models.RepositoryModel;
 import com.gitblit.utils.JGitUtils;
-import com.gitblit.utils.JGitUtils.SearchType;
 import com.gitblit.utils.StringUtils;
 import com.gitblit.utils.TicgitUtils;
 import com.gitblit.wicket.GitBlitWebSession;
@@ -206,7 +206,7 @@
 	protected abstract String getPageName();
 
 	protected Component createPersonPanel(String wicketId, PersonIdent identity,
-			SearchType searchType) {
+			Constants.SearchType searchType) {
 		String name = identity == null ? "" : identity.getName();
 		String address = identity == null ? "" : identity.getEmailAddress();
 		boolean showEmail = GitBlit.getBoolean(Keys.web.showEmailAddresses, false);
@@ -241,10 +241,10 @@
 		}
 	}
 
-	protected void setPersonSearchTooltip(Component component, String value, SearchType searchType) {
-		if (searchType.equals(SearchType.AUTHOR)) {
+	protected void setPersonSearchTooltip(Component component, String value, Constants.SearchType searchType) {
+		if (searchType.equals(Constants.SearchType.AUTHOR)) {
 			WicketUtils.setHtmlTooltip(component, getString("gb.searchForAuthor") + " " + value);
-		} else if (searchType.equals(SearchType.COMMITTER)) {
+		} else if (searchType.equals(Constants.SearchType.COMMITTER)) {
 			WicketUtils.setHtmlTooltip(component, getString("gb.searchForCommitter") + " " + value);
 		}
 	}
@@ -298,13 +298,13 @@
 
 		private final IModel<String> searchBoxModel = new Model<String>("");
 
-		private final IModel<SearchType> searchTypeModel = new Model<SearchType>(SearchType.COMMIT);
+		private final IModel<Constants.SearchType> searchTypeModel = new Model<Constants.SearchType>(Constants.SearchType.COMMIT);
 
 		public SearchForm(String id, String repositoryName) {
 			super(id);
 			this.repositoryName = repositoryName;
-			DropDownChoice<SearchType> searchType = new DropDownChoice<SearchType>("searchType",
-					Arrays.asList(SearchType.values()));
+			DropDownChoice<Constants.SearchType> searchType = new DropDownChoice<Constants.SearchType>("searchType",
+					Arrays.asList(Constants.SearchType.values()));
 			searchType.setModel(searchTypeModel);
 			add(searchType.setVisible(GitBlit.getBoolean(Keys.web.showSearchTypeSelection, false)));
 			TextField<String> searchBox = new TextField<String>("searchBox", searchBoxModel);
@@ -320,13 +320,13 @@
 
 		@Override
 		public void onSubmit() {
-			SearchType searchType = searchTypeModel.getObject();
+			Constants.SearchType searchType = searchTypeModel.getObject();
 			String searchString = searchBoxModel.getObject();
 			if (searchString == null) {
 				// FIXME IE intermittently has no searchString. Wicket bug?
 				return;
 			}
-			for (SearchType type : SearchType.values()) {
+			for (Constants.SearchType type : Constants.SearchType.values()) {
 				if (searchString.toLowerCase().startsWith(type.name().toLowerCase() + ":")) {
 					searchType = type;
 					searchString = searchString.substring(type.name().toLowerCase().length() + 1)
diff --git a/src/com/gitblit/wicket/pages/SearchPage.java b/src/com/gitblit/wicket/pages/SearchPage.java
index 335c40d..d4728d7 100644
--- a/src/com/gitblit/wicket/pages/SearchPage.java
+++ b/src/com/gitblit/wicket/pages/SearchPage.java
@@ -18,7 +18,7 @@
 import org.apache.wicket.PageParameters;
 import org.apache.wicket.markup.html.link.BookmarkablePageLink;
 
-import com.gitblit.utils.JGitUtils.SearchType;
+import com.gitblit.Constants;
 import com.gitblit.wicket.WicketUtils;
 import com.gitblit.wicket.panels.SearchPanel;
 
@@ -29,7 +29,7 @@
 
 		String value = WicketUtils.getSearchString(params);
 		String type = WicketUtils.getSearchType(params);
-		SearchType searchType = SearchType.forName(type);
+		Constants.SearchType searchType = Constants.SearchType.forName(type);
 
 		int pageNumber = WicketUtils.getPage(params);
 		int prevPage = Math.max(0, pageNumber - 1);
diff --git a/src/com/gitblit/wicket/pages/TagPage.java b/src/com/gitblit/wicket/pages/TagPage.java
index a346670..b1ab071 100644
--- a/src/com/gitblit/wicket/pages/TagPage.java
+++ b/src/com/gitblit/wicket/pages/TagPage.java
@@ -27,7 +27,6 @@
 
 import com.gitblit.models.RefModel;
 import com.gitblit.utils.JGitUtils;
-import com.gitblit.utils.JGitUtils.SearchType;
 import com.gitblit.wicket.WicketUtils;
 import com.gitblit.wicket.panels.LinkPanel;
 import com.gitblit.wicket.panels.RefsPanel;
@@ -80,7 +79,7 @@
 				linkClass, linkParameters));
 		add(new Label("taggedObjectType", getString(typeKey)));
 
-		add(createPersonPanel("tagger", tagRef.getAuthorIdent(), SearchType.AUTHOR));
+		add(createPersonPanel("tagger", tagRef.getAuthorIdent(), com.gitblit.Constants.SearchType.AUTHOR));
 		Date when = new Date(0);
 		if (tagRef.getAuthorIdent() != null) {
 			when = tagRef.getAuthorIdent().getWhen();
diff --git a/src/com/gitblit/wicket/panels/BasePanel.java b/src/com/gitblit/wicket/panels/BasePanel.java
index 9dda03c..8ea2a69 100644
--- a/src/com/gitblit/wicket/panels/BasePanel.java
+++ b/src/com/gitblit/wicket/panels/BasePanel.java
@@ -22,9 +22,9 @@
 import org.apache.wicket.markup.html.panel.Panel;
 import org.apache.wicket.model.Model;
 
+import com.gitblit.Constants;
 import com.gitblit.GitBlit;
 import com.gitblit.Keys;
-import com.gitblit.utils.JGitUtils.SearchType;
 import com.gitblit.wicket.GitBlitWebSession;
 import com.gitblit.wicket.WicketUtils;
 
@@ -41,10 +41,10 @@
 				.getTimezone() : TimeZone.getDefault();
 	}
 
-	protected void setPersonSearchTooltip(Component component, String value, SearchType searchType) {
-		if (searchType.equals(SearchType.AUTHOR)) {
+	protected void setPersonSearchTooltip(Component component, String value, Constants.SearchType searchType) {
+		if (searchType.equals(Constants.SearchType.AUTHOR)) {
 			WicketUtils.setHtmlTooltip(component, getString("gb.searchForAuthor") + " " + value);
-		} else if (searchType.equals(SearchType.COMMITTER)) {
+		} else if (searchType.equals(Constants.SearchType.COMMITTER)) {
 			WicketUtils.setHtmlTooltip(component, getString("gb.searchForCommitter") + " " + value);
 		}
 	}
diff --git a/src/com/gitblit/wicket/panels/BranchesPanel.java b/src/com/gitblit/wicket/panels/BranchesPanel.java
index d45c0e6..6eb4019 100644
--- a/src/com/gitblit/wicket/panels/BranchesPanel.java
+++ b/src/com/gitblit/wicket/panels/BranchesPanel.java
@@ -29,11 +29,11 @@
 import org.apache.wicket.model.StringResourceModel;
 import org.eclipse.jgit.lib.Repository;
 
+import com.gitblit.Constants;
 import com.gitblit.SyndicationServlet;
 import com.gitblit.models.RefModel;
 import com.gitblit.models.RepositoryModel;
 import com.gitblit.utils.JGitUtils;
-import com.gitblit.utils.JGitUtils.SearchType;
 import com.gitblit.utils.StringUtils;
 import com.gitblit.wicket.WicketUtils;
 import com.gitblit.wicket.pages.BranchesPage;
@@ -95,8 +95,8 @@
 				String author = entry.getAuthorIdent().getName();
 				LinkPanel authorLink = new LinkPanel("branchAuthor", "list", author,
 						SearchPage.class, WicketUtils.newSearchParameter(model.name,
-								entry.getName(), author, SearchType.AUTHOR));
-				setPersonSearchTooltip(authorLink, author, SearchType.AUTHOR);
+								entry.getName(), author, Constants.SearchType.AUTHOR));
+				setPersonSearchTooltip(authorLink, author, Constants.SearchType.AUTHOR);
 				item.add(authorLink);
 
 				// short message
diff --git a/src/com/gitblit/wicket/panels/HistoryPanel.java b/src/com/gitblit/wicket/panels/HistoryPanel.java
index 9ad407c..16f95f2 100644
--- a/src/com/gitblit/wicket/panels/HistoryPanel.java
+++ b/src/com/gitblit/wicket/panels/HistoryPanel.java
@@ -30,13 +30,13 @@
 import org.eclipse.jgit.lib.Repository;
 import org.eclipse.jgit.revwalk.RevCommit;
 
+import com.gitblit.Constants;
 import com.gitblit.GitBlit;
 import com.gitblit.Keys;
 import com.gitblit.models.PathModel;
 import com.gitblit.models.PathModel.PathChangeModel;
 import com.gitblit.models.RefModel;
 import com.gitblit.utils.JGitUtils;
-import com.gitblit.utils.JGitUtils.SearchType;
 import com.gitblit.utils.StringUtils;
 import com.gitblit.wicket.WicketUtils;
 import com.gitblit.wicket.pages.BlobDiffPage;
@@ -109,8 +109,8 @@
 				String author = entry.getAuthorIdent().getName();
 				LinkPanel authorLink = new LinkPanel("commitAuthor", "list", author,
 						SearchPage.class, WicketUtils.newSearchParameter(repositoryName, objectId,
-								author, SearchType.AUTHOR));
-				setPersonSearchTooltip(authorLink, author, SearchType.AUTHOR);
+								author, Constants.SearchType.AUTHOR));
+				setPersonSearchTooltip(authorLink, author, Constants.SearchType.AUTHOR);
 				item.add(authorLink);
 
 				// merge icon
diff --git a/src/com/gitblit/wicket/panels/LogPanel.java b/src/com/gitblit/wicket/panels/LogPanel.java
index 66fddd2..90b6745 100644
--- a/src/com/gitblit/wicket/panels/LogPanel.java
+++ b/src/com/gitblit/wicket/panels/LogPanel.java
@@ -29,11 +29,11 @@
 import org.eclipse.jgit.lib.Repository;
 import org.eclipse.jgit.revwalk.RevCommit;
 
+import com.gitblit.Constants;
 import com.gitblit.GitBlit;
 import com.gitblit.Keys;
 import com.gitblit.models.RefModel;
 import com.gitblit.utils.JGitUtils;
-import com.gitblit.utils.JGitUtils.SearchType;
 import com.gitblit.utils.StringUtils;
 import com.gitblit.wicket.WicketUtils;
 import com.gitblit.wicket.pages.CommitDiffPage;
@@ -100,8 +100,8 @@
 				String author = entry.getAuthorIdent().getName();
 				LinkPanel authorLink = new LinkPanel("commitAuthor", "list", author,
 						SearchPage.class, WicketUtils.newSearchParameter(repositoryName, objectId,
-								author, SearchType.AUTHOR));
-				setPersonSearchTooltip(authorLink, author, SearchType.AUTHOR);
+								author, Constants.SearchType.AUTHOR));
+				setPersonSearchTooltip(authorLink, author, Constants.SearchType.AUTHOR);
 				item.add(authorLink);
 
 				// merge icon
diff --git a/src/com/gitblit/wicket/panels/SearchPanel.java b/src/com/gitblit/wicket/panels/SearchPanel.java
index d118790..44b499b 100644
--- a/src/com/gitblit/wicket/panels/SearchPanel.java
+++ b/src/com/gitblit/wicket/panels/SearchPanel.java
@@ -28,11 +28,11 @@
 import org.eclipse.jgit.lib.Repository;
 import org.eclipse.jgit.revwalk.RevCommit;
 
+import com.gitblit.Constants;
 import com.gitblit.GitBlit;
 import com.gitblit.Keys;
 import com.gitblit.models.RefModel;
 import com.gitblit.utils.JGitUtils;
-import com.gitblit.utils.JGitUtils.SearchType;
 import com.gitblit.utils.StringUtils;
 import com.gitblit.wicket.WicketUtils;
 import com.gitblit.wicket.pages.CommitDiffPage;
@@ -47,7 +47,7 @@
 	private boolean hasMore;
 
 	public SearchPanel(String wicketId, final String repositoryName, final String objectId,
-			final String value, SearchType searchType, Repository r, int limit, int pageOffset) {
+			final String value, Constants.SearchType searchType, Repository r, int limit, int pageOffset) {
 		super(wicketId);
 		boolean pageResults = limit <= 0;
 		int itemsPerPage = GitBlit.getInteger(Keys.web.itemsPerPage, 50);
@@ -93,8 +93,8 @@
 				String author = entry.getAuthorIdent().getName();
 				LinkPanel authorLink = new LinkPanel("commitAuthor", "list", author,
 						SearchPage.class, WicketUtils.newSearchParameter(repositoryName, objectId,
-								author, SearchType.AUTHOR));
-				setPersonSearchTooltip(authorLink, author, SearchType.AUTHOR);
+								author, Constants.SearchType.AUTHOR));
+				setPersonSearchTooltip(authorLink, author, Constants.SearchType.AUTHOR);
 				item.add(authorLink);
 
 				// merge icon
diff --git a/tests/com/gitblit/tests/JGitUtilsTest.java b/tests/com/gitblit/tests/JGitUtilsTest.java
index 0d7aa63..594d090 100644
--- a/tests/com/gitblit/tests/JGitUtilsTest.java
+++ b/tests/com/gitblit/tests/JGitUtilsTest.java
@@ -42,7 +42,6 @@
 import com.gitblit.models.PathModel.PathChangeModel;
 import com.gitblit.models.RefModel;
 import com.gitblit.utils.JGitUtils;
-import com.gitblit.utils.JGitUtils.SearchType;
 import com.gitblit.utils.StringUtils;
 
 public class JGitUtilsTest extends TestCase {
@@ -306,37 +305,37 @@
 	}
 
 	public void testSearchTypes() throws Exception {
-		assertTrue(SearchType.forName("commit").equals(SearchType.COMMIT));
-		assertTrue(SearchType.forName("committer").equals(SearchType.COMMITTER));
-		assertTrue(SearchType.forName("author").equals(SearchType.AUTHOR));
-		assertTrue(SearchType.forName("unknown").equals(SearchType.COMMIT));
+		assertTrue(com.gitblit.Constants.SearchType.forName("commit").equals(com.gitblit.Constants.SearchType.COMMIT));
+		assertTrue(com.gitblit.Constants.SearchType.forName("committer").equals(com.gitblit.Constants.SearchType.COMMITTER));
+		assertTrue(com.gitblit.Constants.SearchType.forName("author").equals(com.gitblit.Constants.SearchType.AUTHOR));
+		assertTrue(com.gitblit.Constants.SearchType.forName("unknown").equals(com.gitblit.Constants.SearchType.COMMIT));
 
-		assertTrue(SearchType.COMMIT.toString().equals("commit"));
-		assertTrue(SearchType.COMMITTER.toString().equals("committer"));
-		assertTrue(SearchType.AUTHOR.toString().equals("author"));
+		assertTrue(com.gitblit.Constants.SearchType.COMMIT.toString().equals("commit"));
+		assertTrue(com.gitblit.Constants.SearchType.COMMITTER.toString().equals("committer"));
+		assertTrue(com.gitblit.Constants.SearchType.AUTHOR.toString().equals("author"));
 	}
 
 	public void testSearchRevlogs() throws Exception {
-		assertTrue(JGitUtils.searchRevlogs(null, null, "java", SearchType.COMMIT, 0, 0).size() == 0);
-		List<RevCommit> results = JGitUtils.searchRevlogs(null, null, "java", SearchType.COMMIT, 0,
+		assertTrue(JGitUtils.searchRevlogs(null, null, "java", com.gitblit.Constants.SearchType.COMMIT, 0, 0).size() == 0);
+		List<RevCommit> results = JGitUtils.searchRevlogs(null, null, "java", com.gitblit.Constants.SearchType.COMMIT, 0,
 				3);
 		assertTrue(results.size() == 0);
 
 		// test commit message search
 		Repository repository = GitBlitSuite.getHelloworldRepository();
-		results = JGitUtils.searchRevlogs(repository, null, "java", SearchType.COMMIT, 0, 3);
+		results = JGitUtils.searchRevlogs(repository, null, "java", com.gitblit.Constants.SearchType.COMMIT, 0, 3);
 		assertTrue(results.size() == 3);
 
 		// test author search
-		results = JGitUtils.searchRevlogs(repository, null, "timothy", SearchType.AUTHOR, 0, -1);
+		results = JGitUtils.searchRevlogs(repository, null, "timothy", com.gitblit.Constants.SearchType.AUTHOR, 0, -1);
 		assertTrue(results.size() == 1);
 
 		// test committer search
-		results = JGitUtils.searchRevlogs(repository, null, "mike", SearchType.COMMITTER, 0, 10);
+		results = JGitUtils.searchRevlogs(repository, null, "mike", com.gitblit.Constants.SearchType.COMMITTER, 0, 10);
 		assertTrue(results.size() == 10);
 
 		// test paging and offset
-		RevCommit commit = JGitUtils.searchRevlogs(repository, null, "mike", SearchType.COMMITTER,
+		RevCommit commit = JGitUtils.searchRevlogs(repository, null, "mike", com.gitblit.Constants.SearchType.COMMITTER,
 				9, 1).get(0);
 		assertTrue(results.get(9).equals(commit));
 

--
Gitblit v1.9.1