From 332e93c9e8b2ef756ac2b2ec1055262046f988fa Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Fri, 30 Mar 2012 20:01:03 -0400 Subject: [PATCH] Merge pull request #10 from jonnybbb/master --- src/com/gitblit/wicket/pages/ChangePasswordPage.java | 18 ++++++++++++------ 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/src/com/gitblit/wicket/pages/ChangePasswordPage.java b/src/com/gitblit/wicket/pages/ChangePasswordPage.java index 660a813..4fb5d23 100644 --- a/src/com/gitblit/wicket/pages/ChangePasswordPage.java +++ b/src/com/gitblit/wicket/pages/ChangePasswordPage.java @@ -32,7 +32,7 @@ import com.gitblit.utils.StringUtils; import com.gitblit.wicket.GitBlitWebSession; -public class ChangePasswordPage extends StandardPage { +public class ChangePasswordPage extends RootSubPage { IModel<String> password = new Model<String>(""); IModel<String> confirmPassword = new Model<String>(""); @@ -62,7 +62,7 @@ String confirmPassword = ChangePasswordPage.this.confirmPassword.getObject(); // ensure passwords match if (!password.equals(confirmPassword)) { - error("Passwords do not match!"); + error(getString("gb.passwordsDoNotMatch")); return; } @@ -72,19 +72,23 @@ minLength = 4; } if (password.length() < minLength) { - error(MessageFormat.format( - "Password is too short. Minimum length is {0} characters.", minLength)); + error(MessageFormat.format(getString("gb.passwordTooShort"), minLength)); return; } + + UserModel user = GitBlitWebSession.get().getUser(); // convert to MD5 digest, if appropriate String type = GitBlit.getString(Keys.realm.passwordStorage, "md5"); if (type.equalsIgnoreCase("md5")) { // store MD5 digest of password password = StringUtils.MD5_TYPE + StringUtils.getMD5(password); + } else if (type.equalsIgnoreCase("combined-md5")) { + // store MD5 digest of username+password + password = StringUtils.COMBINED_MD5_TYPE + + StringUtils.getMD5(user.username.toLowerCase() + password); } - UserModel user = GitBlitWebSession.get().getUser(); user.password = password; try { GitBlit.self().updateUserModel(user.username, user, false); @@ -97,7 +101,7 @@ return; } setRedirect(false); - info("Password successfully changed."); + info(getString("gb.passwordChanged")); setResponsePage(RepositoriesPage.class); } }; @@ -115,6 +119,8 @@ @Override public void onSubmit() { + setRedirect(false); + error(getString("gb.passwordChangeAborted")); setResponsePage(RepositoriesPage.class); } }; -- Gitblit v1.9.1