From 2a7306a1d92522569a8bb6e5a7c0bcdd5cf4cfaa Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Thu, 26 May 2011 17:11:38 -0400
Subject: [PATCH] Findbugs. CodePro Audit. Checkstyle. Unit test refactoring.
---
src/com/gitblit/GitBlitServlet.java | 32 +++++++++++++++++++++-----------
1 files changed, 21 insertions(+), 11 deletions(-)
diff --git a/src/com/gitblit/GitBlitServlet.java b/src/com/gitblit/GitBlitServlet.java
index af0971d..91bd7b2 100644
--- a/src/com/gitblit/GitBlitServlet.java
+++ b/src/com/gitblit/GitBlitServlet.java
@@ -33,14 +33,15 @@
private static final long serialVersionUID = 1L;
- private final Logger logger = LoggerFactory.getLogger(GitBlitServlet.class);
+ private transient Logger logger = LoggerFactory.getLogger(GitBlitServlet.class);
public GitBlitServlet() {
super();
}
@Override
- protected void service(final HttpServletRequest req, final HttpServletResponse rsp) throws ServletException, IOException {
+ protected void service(final HttpServletRequest req, final HttpServletResponse rsp)
+ throws ServletException, IOException {
// admins have full git access to all repositories
if (req.isUserInRole(Constants.ADMIN_ROLE)) {
// admins can do whatever
@@ -57,12 +58,13 @@
if (forwardSlash > -1) {
String repository = url.substring(0, forwardSlash);
String function = url.substring(forwardSlash + 1);
- String query = req.getQueryString() == null ? "":req.getQueryString();
+ String query = req.getQueryString() == null ? "" : req.getQueryString();
RepositoryModel model = GitBlit.self().getRepositoryModel(repository);
- if (model != null) {
+ if (model != null) {
if (model.isFrozen || model.accessRestriction.atLeast(AccessRestrictionType.PUSH)) {
boolean authorizedUser = req.isUserInRole(repository);
- if (function.startsWith("git-receive-pack") || (query.indexOf("service=git-receive-pack") > -1)) {
+ if (function.startsWith("git-receive-pack")
+ || (query.indexOf("service=git-receive-pack") > -1)) {
// Push request
if (!model.isFrozen && authorizedUser) {
// clone-restricted or push-authorized
@@ -70,21 +72,29 @@
return;
} else {
// user is unauthorized to push to this repository
- logger.warn(MessageFormat.format("user {0} is not authorized to push to {1} ", req.getUserPrincipal().getName(), repository));
- rsp.sendError(HttpServletResponse.SC_FORBIDDEN, MessageFormat.format("you are not authorized to push to {0} ", repository));
+ logger.warn(MessageFormat.format(
+ "user {0} is not authorized to push to {1}", req
+ .getUserPrincipal().getName(), repository));
+ rsp.sendError(HttpServletResponse.SC_FORBIDDEN, MessageFormat.format(
+ "you are not authorized to push to {0}", repository));
return;
}
- } else if (function.startsWith("git-upload-pack") || (query.indexOf("service=git-upload-pack") > -1)) {
+ } else if (function.startsWith("git-upload-pack")
+ || (query.indexOf("service=git-upload-pack") > -1)) {
// Clone request
- boolean cloneRestricted = model.accessRestriction.atLeast(AccessRestrictionType.CLONE);
+ boolean cloneRestricted = model.accessRestriction
+ .atLeast(AccessRestrictionType.CLONE);
if (!cloneRestricted || (cloneRestricted && authorizedUser)) {
// push-restricted or clone-authorized
super.service(req, rsp);
return;
} else {
// user is unauthorized to clone this repository
- logger.warn(MessageFormat.format("user {0} is not authorized to clone {1} ", req.getUserPrincipal().getName(), repository));
- rsp.sendError(HttpServletResponse.SC_FORBIDDEN, MessageFormat.format("you are not authorized to clone {0} ", repository));
+ logger.warn(MessageFormat.format(
+ "user {0} is not authorized to clone {1}", req
+ .getUserPrincipal().getName(), repository));
+ rsp.sendError(HttpServletResponse.SC_FORBIDDEN, MessageFormat.format(
+ "you are not authorized to clone {0}", repository));
return;
}
}
--
Gitblit v1.9.1